====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc7-syzkaller-00123-g3a568e3a961b #0 Not tainted ------------------------------------------------------ syz-executor.4/15670 is trying to acquire lock: ffff88823bcf2100 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ffff88823bcf2100 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0x9b1/0x1100 fs/ntfs3/file.c:563 but task is already holding lock: ffff88823bcf2540 (mapping.invalidate_lock#13){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:847 [inline] ffff88823bcf2540 (mapping.invalidate_lock#13){++++}-{3:3}, at: ntfs_fallocate+0x39f/0x1100 fs/ntfs3/file.c:483 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (mapping.invalidate_lock#13){++++}-{3:3}: down_read+0xb1/0xa40 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:857 [inline] filemap_fault+0x658/0x1710 mm/filemap.c:3283 __do_fault+0x133/0x4e0 mm/memory.c:4207 do_read_fault mm/memory.c:4571 [inline] do_fault mm/memory.c:4708 [inline] do_pte_missing mm/memory.c:3672 [inline] handle_pte_fault mm/memory.c:4981 [inline] __handle_mm_fault mm/memory.c:5122 [inline] handle_mm_fault+0x428e/0x62b0 mm/memory.c:5287 do_user_addr_fault arch/x86/mm/fault.c:1413 [inline] handle_page_fault arch/x86/mm/fault.c:1505 [inline] exc_page_fault+0x2ac/0x860 arch/x86/mm/fault.c:1561 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 strncpy_from_user+0x111/0x2e0 lib/strncpy_from_user.c:139 getname_flags+0xf9/0x4f0 fs/namei.c:151 getname fs/namei.c:219 [inline] __do_sys_mkdirat fs/namei.c:4159 [inline] __se_sys_mkdirat fs/namei.c:4157 [inline] __x64_sys_mkdirat+0x7c/0xa0 fs/namei.c:4157 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&mm->mmap_lock){++++}-{3:3}: __might_fault+0xc1/0x120 mm/memory.c:5899 _copy_to_user+0x2a/0xa0 lib/usercopy.c:36 copy_to_user include/linux/uaccess.h:191 [inline] fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145 ni_fiemap+0xa5e/0x1230 fs/ntfs3/frecord.c:2065 ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1163 ioctl_fiemap fs/ioctl.c:220 [inline] do_vfs_ioctl+0x19ea/0x2b40 fs/ioctl.c:811 __do_sys_ioctl fs/ioctl.c:869 [inline] __se_sys_ioctl+0x81/0x170 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&ni->file.run_lock#3){++++}-{3:3}: down_write+0x3a/0x50 kernel/locking/rwsem.c:1573 ntfs_set_size+0x13d/0x1f0 fs/ntfs3/inode.c:836 ntfs_extend+0x155/0x480 fs/ntfs3/file.c:332 ntfs_file_write_iter+0x308/0x6d0 fs/ntfs3/file.c:1076 call_write_iter include/linux/fs.h:1956 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x782/0xaf0 fs/read_write.c:584 ksys_write+0x1a0/0x2c0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ntfs_fallocate+0x9b1/0x1100 fs/ntfs3/file.c:563 vfs_fallocate+0x551/0x6b0 fs/open.c:324 ksys_fallocate fs/open.c:347 [inline] __do_sys_fallocate fs/open.c:355 [inline] __se_sys_fallocate fs/open.c:353 [inline] __x64_sys_fallocate+0xbd/0x100 fs/open.c:353 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ni->ni_lock/4 --> &mm->mmap_lock --> mapping.invalidate_lock#13 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(mapping.invalidate_lock#13); lock(&mm->mmap_lock); lock(mapping.invalidate_lock#13); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz-executor.4/15670: #0: ffff888059986410 (sb_writers#29){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2644 [inline] #0: ffff888059986410 (sb_writers#29){.+.+}-{0:0}, at: vfs_fallocate+0x4c4/0x6b0 fs/open.c:323 #1: ffff88823bcf23a0 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #1: ffff88823bcf23a0 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: ntfs_fallocate+0x2dd/0x1100 fs/ntfs3/file.c:469 #2: ffff88823bcf2540 (mapping.invalidate_lock#13){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:847 [inline] #2: ffff88823bcf2540 (mapping.invalidate_lock#13){++++}-{3:3}, at: ntfs_fallocate+0x39f/0x1100 fs/ntfs3/file.c:483 stack backtrace: CPU: 0 PID: 15670 Comm: syz-executor.4 Not tainted 6.6.0-rc7-syzkaller-00123-g3a568e3a961b #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ntfs_fallocate+0x9b1/0x1100 fs/ntfs3/file.c:563 vfs_fallocate+0x551/0x6b0 fs/open.c:324 ksys_fallocate fs/open.c:347 [inline] __do_sys_fallocate fs/open.c:355 [inline] __se_sys_fallocate fs/open.c:353 [inline] __x64_sys_fallocate+0xbd/0x100 fs/open.c:353 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fbdf647cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fbdf71d10c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d RAX: ffffffffffffffda RBX: 00007fbdf659bf80 RCX: 00007fbdf647cae9 RDX: 0000000000006000 RSI: 0000000000000020 RDI: 0000000000000004 RBP: 00007fbdf64c847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000002000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fbdf659bf80 R15: 00007ffdcd471b98