EXT4-fs (loop3): orphan cleanup on readonly fs ====================================================== WARNING: possible circular locking dependency detected 6.3.0-rc7-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/7880 is trying to acquire lock: ffff888074b03eb8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x38e/0x1cf0 fs/ext4/inode.c:574 but task is already holding lock: ffff88801febe208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x4e/0x110 fs/quota/quota_v2.c:332 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669 down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4e/0x110 fs/quota/quota_v2.c:332 dquot_acquire+0x18c/0x680 fs/quota/dquot.c:435 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6770 dqget+0x98f/0xdb0 fs/quota/dquot.c:914 __dquot_initialize+0x2dd/0xe20 fs/quota/dquot.c:1492 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb21/0x13c0 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5509 [inline] ext4_fill_super+0x8239/0x8990 fs/ext4/super.c:5637 get_tree_bdev+0x402/0x620 fs/super.c:1303 vfs_get_tree+0x8c/0x270 fs/super.c:1510 do_new_mount+0x28f/0xae0 fs/namespace.c:3042 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3571 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 dquot_commit+0x5b/0x520 fs/quota/dquot.c:479 ext4_write_dquot+0x1f2/0x2c0 fs/ext4/super.c:6754 mark_dquot_dirty fs/quota/dquot.c:346 [inline] mark_all_dquot_dirty fs/quota/dquot.c:384 [inline] __dquot_alloc_space+0x54c/0xf50 fs/quota/dquot.c:1722 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x111a/0x45f0 fs/ext4/mballoc.c:5571 ext4_ext_map_blocks+0x1973/0x7210 fs/ext4/extents.c:4286 ext4_map_blocks+0xa4c/0x1cf0 fs/ext4/inode.c:651 ext4_getblk+0x1ef/0x7c0 fs/ext4/inode.c:863 ext4_bread+0x2e/0x180 fs/ext4/inode.c:919 ext4_append+0x323/0x5c0 fs/ext4/namei.c:83 ext4_init_new_dir+0x33e/0xa20 fs/ext4/namei.c:2955 ext4_mkdir+0x4f6/0xce0 fs/ext4/namei.c:3001 vfs_mkdir+0x29d/0x450 fs/namei.c:4038 ovl_do_mkdir fs/overlayfs/overlayfs.h:189 [inline] ovl_mkdir_real+0xd3/0x2d0 fs/overlayfs/dir.c:146 ovl_workdir_create+0x451/0x970 fs/overlayfs/super.c:799 ovl_get_indexdir+0x233/0x670 fs/overlayfs/super.c:1476 ovl_fill_super+0x1c19/0x2bd0 fs/overlayfs/super.c:2025 mount_nodev+0x56/0xe0 fs/super.c:1426 legacy_get_tree+0xef/0x190 fs/fs_context.c:610 vfs_get_tree+0x8c/0x270 fs/super.c:1510 do_new_mount+0x28f/0xae0 fs/namespace.c:3042 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3571 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669 down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x38e/0x1cf0 fs/ext4/inode.c:574 ext4_getblk+0x1ef/0x7c0 fs/ext4/inode.c:863 ext4_bread+0x2e/0x180 fs/ext4/inode.c:919 ext4_quota_read+0x1a5/0x2c0 fs/ext4/super.c:7089 read_blk fs/quota/quota_tree.c:55 [inline] find_tree_dqentry+0x18c/0xbd0 fs/quota/quota_tree.c:624 find_tree_dqentry+0x486/0xbd0 fs/quota/quota_tree.c:640 find_dqentry fs/quota/quota_tree.c:652 [inline] qtree_read_dquot+0x143/0x650 fs/quota/quota_tree.c:672 v2_read_dquot+0xc2/0x110 fs/quota/quota_v2.c:333 dquot_acquire+0x18c/0x680 fs/quota/dquot.c:435 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6770 dqget+0x98f/0xdb0 fs/quota/dquot.c:914 __dquot_initialize+0x2dd/0xe20 fs/quota/dquot.c:1492 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb21/0x13c0 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5509 [inline] ext4_fill_super+0x8239/0x8990 fs/ext4/super.c:5637 get_tree_bdev+0x402/0x620 fs/super.c:1303 vfs_get_tree+0x8c/0x270 fs/super.c:1510 do_new_mount+0x28f/0xae0 fs/namespace.c:3042 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3571 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 3 locks held by syz-executor.3/7880: #0: ffff88801febe0e0 (&type->s_umount_key#26/1){+.+.}-{3:3}, at: alloc_super+0x217/0x930 fs/super.c:228 #1: ffff88803237a0a8 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x68/0x680 fs/quota/dquot.c:432 #2: ffff88801febe208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_read_dquot+0x4e/0x110 fs/quota/quota_v2.c:332 stack backtrace: CPU: 0 PID: 7880 Comm: syz-executor.3 Not tainted 6.3.0-rc7-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/30/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x1e1/0x520 kernel/locking/lockdep.c:5669 down_read+0x3d/0x50 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x38e/0x1cf0 fs/ext4/inode.c:574 ext4_getblk+0x1ef/0x7c0 fs/ext4/inode.c:863 ext4_bread+0x2e/0x180 fs/ext4/inode.c:919 ext4_quota_read+0x1a5/0x2c0 fs/ext4/super.c:7089 read_blk fs/quota/quota_tree.c:55 [inline] find_tree_dqentry+0x18c/0xbd0 fs/quota/quota_tree.c:624 find_tree_dqentry+0x486/0xbd0 fs/quota/quota_tree.c:640 find_dqentry fs/quota/quota_tree.c:652 [inline] qtree_read_dquot+0x143/0x650 fs/quota/quota_tree.c:672 v2_read_dquot+0xc2/0x110 fs/quota/quota_v2.c:333 dquot_acquire+0x18c/0x680 fs/quota/dquot.c:435 ext4_acquire_dquot+0x2e6/0x400 fs/ext4/super.c:6770 dqget+0x98f/0xdb0 fs/quota/dquot.c:914 __dquot_initialize+0x2dd/0xe20 fs/quota/dquot.c:1492 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb21/0x13c0 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5509 [inline] ext4_fill_super+0x8239/0x8990 fs/ext4/super.c:5637 get_tree_bdev+0x402/0x620 fs/super.c:1303 vfs_get_tree+0x8c/0x270 fs/super.c:1510 do_new_mount+0x28f/0xae0 fs/namespace.c:3042 do_mount fs/namespace.c:3385 [inline] __do_sys_mount fs/namespace.c:3594 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3571 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f3ae128d69a Code: 48 c7 c2 b8 ff ff ff f7 d8 64 89 02 b8 ff ff ff ff eb d2 e8 b8 04 00 00 0f 1f 84 00 00 00 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f3ae1fc2f88 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00000000000004cc RCX: 00007f3ae128d69a RDX: 00000000200000c0 RSI: 0000000020000500 RDI: 00007f3ae1fc2fe0 RBP: 00007f3ae1fc3020 R08: 00007f3ae1fc3020 R09: 0000000000000013 R10: 0000000000000013 R11: 0000000000000202 R12: 00000000200000c0 R13: 0000000020000500 R14: 00007f3ae1fc2fe0 R15: 00000000200002c0 __quota_error: 43 callbacks suppressed Quota error (device loop3): do_check_range: Getting block 196613 out of range 1-5 Quota error (device loop3): qtree_read_dquot: Can't read quota structure for id 0 EXT4-fs (loop3): 1 truncate cleaned up EXT4-fs (loop3): mounted filesystem 00000000-0000-0000-0000-000000000000 without journal. Quota mode: writeback. EXT4-fs (loop3): unmounting filesystem 00000000-0000-0000-0000-000000000000.