====================================================== WARNING: possible circular locking dependency detected 6.5.0-rc6-syzkaller-00200-gd4ddefee5160 #0 Not tainted ------------------------------------------------------ syz-executor.2/21976 is trying to acquire lock: ffff888038df3c00 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ffff888038df3c00 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0xa4a/0x1160 fs/ntfs3/file.c:563 but task is already holding lock: ffff888038df4040 (mapping.invalidate_lock#4){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:816 [inline] ffff888038df4040 (mapping.invalidate_lock#4){++++}-{3:3}, at: ntfs_fallocate+0x3df/0x1160 fs/ntfs3/file.c:483 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (mapping.invalidate_lock#4){++++}-{3:3}: down_read+0x47/0x2f0 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:826 [inline] filemap_fault+0x647/0x1810 mm/filemap.c:3289 __do_fault+0x136/0x500 mm/memory.c:4198 do_read_fault mm/memory.c:4547 [inline] do_fault mm/memory.c:4670 [inline] do_pte_missing mm/memory.c:3664 [inline] handle_pte_fault mm/memory.c:4939 [inline] __handle_mm_fault mm/memory.c:5079 [inline] handle_mm_fault+0x4172/0x5410 mm/memory.c:5233 faultin_page mm/gup.c:959 [inline] __get_user_pages+0x74a/0x1340 mm/gup.c:1258 populate_vma_page_range+0x2c3/0x3b0 mm/gup.c:1649 __mm_populate+0x279/0x450 mm/gup.c:1758 mm_populate include/linux/mm.h:3213 [inline] vm_mmap_pgoff+0x300/0x410 mm/util.c:548 ksys_mmap_pgoff+0x4ff/0x6d0 mm/mmap.c:1409 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&mm->mmap_lock){++++}-{3:3}: __might_fault+0xba/0x120 mm/memory.c:5859 _copy_to_user+0x2a/0xa0 lib/usercopy.c:36 copy_to_user include/linux/uaccess.h:191 [inline] fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:144 ni_fiemap+0x100b/0x1230 fs/ntfs3/frecord.c:1948 ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1163 ioctl_fiemap fs/ioctl.c:219 [inline] do_vfs_ioctl+0x19db/0x2b30 fs/ioctl.c:810 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x81/0x170 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ntfs_fallocate+0xa4a/0x1160 fs/ntfs3/file.c:563 vfs_fallocate+0x551/0x6b0 fs/open.c:324 ksys_fallocate fs/open.c:347 [inline] __do_sys_fallocate fs/open.c:355 [inline] __se_sys_fallocate fs/open.c:353 [inline] __x64_sys_fallocate+0xbd/0x100 fs/open.c:353 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &ni->ni_lock/4 --> &mm->mmap_lock --> mapping.invalidate_lock#4 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(mapping.invalidate_lock#4); lock(&mm->mmap_lock); lock(mapping.invalidate_lock#4); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz-executor.2/21976: #0: ffff88807960c410 (sb_writers#14){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2552 [inline] #0: ffff88807960c410 (sb_writers#14){.+.+}-{0:0}, at: vfs_fallocate+0x4c4/0x6b0 fs/open.c:323 #1: ffff888038df3ea0 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:771 [inline] #1: ffff888038df3ea0 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: ntfs_fallocate+0x310/0x1160 fs/ntfs3/file.c:469 #2: ffff888038df4040 (mapping.invalidate_lock#4){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:816 [inline] #2: ffff888038df4040 (mapping.invalidate_lock#4){++++}-{3:3}, at: ntfs_fallocate+0x3df/0x1160 fs/ntfs3/file.c:483 stack backtrace: CPU: 0 PID: 21976 Comm: syz-executor.2 Not tainted 6.5.0-rc6-syzkaller-00200-gd4ddefee5160 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 07/26/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x375/0x4a0 kernel/locking/lockdep.c:2195 check_prev_add kernel/locking/lockdep.c:3142 [inline] check_prevs_add kernel/locking/lockdep.c:3261 [inline] validate_chain kernel/locking/lockdep.c:3876 [inline] __lock_acquire+0x39ff/0x7f70 kernel/locking/lockdep.c:5144 lock_acquire+0x1e3/0x520 kernel/locking/lockdep.c:5761 __mutex_lock_common+0x1d8/0x2530 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x1b/0x20 kernel/locking/mutex.c:799 ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ntfs_fallocate+0xa4a/0x1160 fs/ntfs3/file.c:563 vfs_fallocate+0x551/0x6b0 fs/open.c:324 ksys_fallocate fs/open.c:347 [inline] __do_sys_fallocate fs/open.c:355 [inline] __se_sys_fallocate fs/open.c:353 [inline] __x64_sys_fallocate+0xbd/0x100 fs/open.c:353 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fb92767cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb9284c10c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d RAX: ffffffffffffffda RBX: 00007fb92779bf80 RCX: 00007fb92767cae9 RDX: 0000000000000000 RSI: 0000000000000020 RDI: 0000000000000004 RBP: 00007fb9276c847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000020000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fb92779bf80 R15: 00007ffda98951d8 ntfs3: loop2: ino=21, "cgroup.controllers" attr_insert_range