====================================================== WARNING: possible circular locking dependency detected 6.1.64-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/14248 is trying to acquire lock: ffff000113744360 (&ni->ni_lock){+.+.}-{3:3}, at: ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:920 but task is already holding lock: ffff000113740910 (&ni->file.run_lock#2 ){++++}-{3:3}, at: ntfs_extend_mft+0x120/0x3f0 fs/ntfs3/fsntfs.c:482 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 ( &ni->file.run_lock#2){++++}-{3:3} : down_read+0x64/0x308 kernel/locking/rwsem.c:1520 mi_read+0x150/0x4d8 fs/ntfs3/record.c:129 mi_format_new+0x174/0x514 fs/ntfs3/record.c:379 ni_add_subrecord+0xd0/0x3c4 fs/ntfs3/frecord.c:371 ntfs_look_free_mft+0x4c8/0xd1c fs/ntfs3/fsntfs.c:686 ni_create_attr_list+0x764/0xf54 fs/ntfs3/frecord.c:873 ni_ins_attr_ext+0x300/0xa10 fs/ntfs3/frecord.c:974 ni_insert_attr+0x304/0x7bc fs/ntfs3/frecord.c:1141 ni_insert_nonresident+0x24c/0x658 fs/ntfs3/frecord.c:1476 indx_create_allocate fs/ntfs3/index.c:1440 [inline] indx_insert_into_root+0xd4c/0x1b00 fs/ntfs3/index.c:1673 indx_insert_entry+0x430/0x634 fs/ntfs3/index.c:1946 ntfs_create_inode+0x16ac/0x2a10 fs/ntfs3/inode.c:1574 ntfs_create+0x54/0x74 fs/ntfs3/namei.c:110 vfs_create+0x2cc/0x434 fs/namei.c:3116 do_mknodat+0x390/0x530 fs/namei.c:3966 __do_sys_mknodat fs/namei.c:3994 [inline] __se_sys_mknodat fs/namei.c:3991 [inline] __arm64_sys_mknodat+0xb0/0xcc fs/namei.c:3991 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (&wnd->rw_lock/1){+.+.}-{3:3}: down_write_nested+0x64/0x94 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x48/0x270 fs/ntfs3/fsntfs.c:713 ni_write_inode+0x3f0/0xfb8 fs/ntfs3/frecord.c:3344 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1030 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x614/0x1770 fs/fs-writeback.c:1677 writeback_sb_inodes+0x978/0x1718 fs/fs-writeback.c:1903 wb_writeback+0x414/0x1130 fs/fs-writeback.c:2077 wb_do_writeback fs/fs-writeback.c:2220 [inline] wb_workfn+0x3a8/0x1034 fs/fs-writeback.c:2260 process_one_work+0x7ac/0x1404 kernel/workqueue.c:2292 worker_thread+0x8e4/0xfec kernel/workqueue.c:2439 kthread+0x250/0x2d8 kernel/kthread.c:376 ret_from_fork+0x10/0x20 arch/arm64/kernel/entry.S:864 -> #0 (&ni->ni_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3824 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5048 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5661 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:920 ntfs_bad_inode+0x88/0x9c fs/ntfs3/fsntfs.c:885 attr_set_size+0x27d0/0x3430 fs/ntfs3/attrib.c:880 ntfs_extend_mft+0x264/0x3f0 fs/ntfs3/fsntfs.c:498 ntfs_look_free_mft+0x350/0xd1c fs/ntfs3/fsntfs.c:561 ni_create_attr_list+0x764/0xf54 fs/ntfs3/frecord.c:873 ni_ins_attr_ext+0x300/0xa10 fs/ntfs3/frecord.c:974 ni_insert_attr+0x304/0x7bc fs/ntfs3/frecord.c:1141 ni_insert_resident+0x100/0x384 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xa40/0x1280 fs/ntfs3/xattr.c:439 ntfs_setxattr+0x17c/0x724 fs/ntfs3/xattr.c:948 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x230/0x294 fs/xattr.c:617 path_setxattr+0x17c/0x258 fs/xattr.c:636 __do_sys_setxattr fs/xattr.c:652 [inline] __se_sys_setxattr fs/xattr.c:648 [inline] __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:648 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &ni->ni_lock --> &wnd->rw_lock/1 --> &ni->file.run_lock#2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->file.run_lock#2); lock(&wnd->rw_lock/1); lock(&ni->file.run_lock#2); lock(&ni->ni_lock); *** DEADLOCK *** 5 locks held by syz-executor.1/14248: #0: ffff0000e0272460 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:393 #1: ffff000113744d60 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff000113744d60 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: vfs_setxattr+0x17c/0x344 fs/xattr.c:308 #2: ffff000113744ac0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1111 [inline] #2: ffff000113744ac0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_set_ea+0x1cc/0x1280 fs/ntfs3/xattr.c:326 #3: ffff0000e0274120 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_look_free_mft+0x190/0xd1c fs/ntfs3/fsntfs.c:542 #4: ffff000113740910 (&ni->file.run_lock#2){++++}-{3:3}, at: ntfs_extend_mft+0x120/0x3f0 fs/ntfs3/fsntfs.c:482 stack backtrace: CPU: 0 PID: 14248 Comm: syz-executor.1 Not tainted 6.1.64-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/09/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3824 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5048 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5661 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:920 ntfs_bad_inode+0x88/0x9c fs/ntfs3/fsntfs.c:885 attr_set_size+0x27d0/0x3430 fs/ntfs3/attrib.c:880 ntfs_extend_mft+0x264/0x3f0 fs/ntfs3/fsntfs.c:498 ntfs_look_free_mft+0x350/0xd1c fs/ntfs3/fsntfs.c:561 ni_create_attr_list+0x764/0xf54 fs/ntfs3/frecord.c:873 ni_ins_attr_ext+0x300/0xa10 fs/ntfs3/frecord.c:974 ni_insert_attr+0x304/0x7bc fs/ntfs3/frecord.c:1141 ni_insert_resident+0x100/0x384 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xa40/0x1280 fs/ntfs3/xattr.c:439 ntfs_setxattr+0x17c/0x724 fs/ntfs3/xattr.c:948 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182 __vfs_setxattr_noperm+0x110/0x528 fs/xattr.c:216 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277 vfs_setxattr+0x1a8/0x344 fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x230/0x294 fs/xattr.c:617 path_setxattr+0x17c/0x258 fs/xattr.c:636 __do_sys_setxattr fs/xattr.c:652 [inline] __se_sys_setxattr fs/xattr.c:648 [inline] __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:648 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 ntfs3: loop1: Mark volume as dirty due to NTFS errors