====================================================== WARNING: possible circular locking dependency detected 6.1.0-syzkaller-14127-gec34c2b4ec38 #0 Not tainted ------------------------------------------------------ syz-executor.3/16990 is trying to acquire lock: ffff88802a510650 (sb_internal){.+.+}-{0:0}, at: evict+0x2ed/0x6b0 fs/inode.c:664 but task is already holding lock: ffff88802a512b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x326/0x1ce0 fs/ext4/migrate.c:437 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}: percpu_down_write+0x53/0x390 kernel/locking/percpu-rwsem.c:227 ext4_ind_migrate+0x23b/0x860 fs/ext4/migrate.c:624 ext4_ioctl_setflags fs/ext4/ioctl.c:696 [inline] ext4_fileattr_set+0x1582/0x1a50 fs/ext4/ioctl.c:1004 vfs_fileattr_set+0x7f9/0xbe0 fs/ioctl.c:696 ioctl_fssetxattr fs/ioctl.c:758 [inline] do_vfs_ioctl+0xf8d/0x15b0 fs/ioctl.c:845 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x10c/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: down_read+0x9c/0x450 kernel/locking/rwsem.c:1509 inode_lock_shared include/linux/fs.h:766 [inline] ext4_bmap+0x52/0x470 fs/ext4/inode.c:3243 bmap+0xae/0x120 fs/inode.c:1798 jbd2_journal_bmap+0xac/0x180 fs/jbd2/journal.c:977 __jbd2_journal_erase fs/jbd2/journal.c:1789 [inline] jbd2_journal_flush+0x853/0xc00 fs/jbd2/journal.c:2492 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline] __ext4_ioctl+0xb01/0x4b60 fs/ext4/ioctl.c:1590 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] mutex_lock_io_nested+0x143/0x11a0 kernel/locking/mutex.c:833 __jbd2_log_wait_for_space+0x238/0x460 fs/jbd2/checkpoint.c:110 add_transaction_credits+0xa2d/0xb70 fs/jbd2/transaction.c:298 start_this_handle+0x3ae/0x14a0 fs/jbd2/transaction.c:422 jbd2__journal_start+0x39d/0x9b0 fs/jbd2/transaction.c:520 __ext4_journal_start_sb+0x6e9/0x860 fs/ext4/ext4_jbd2.c:111 __ext4_journal_start fs/ext4/ext4_jbd2.h:326 [inline] ext4_evict_inode+0xa27/0x1eb0 fs/ext4/inode.c:251 evict+0x2ed/0x6b0 fs/inode.c:664 iput_final fs/inode.c:1747 [inline] iput.part.0+0x59b/0x880 fs/inode.c:1773 iput+0x5c/0x80 fs/inode.c:1763 do_unlinkat+0x406/0x640 fs/namei.c:4327 __do_sys_unlink fs/namei.c:4368 [inline] __se_sys_unlink fs/namei.c:4366 [inline] __x64_sys_unlink+0xca/0x110 fs/namei.c:4366 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (sb_internal){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1811 [inline] sb_start_intwrite include/linux/fs.h:1933 [inline] ext4_evict_inode+0x1327/0x1eb0 fs/ext4/inode.c:240 evict+0x2ed/0x6b0 fs/inode.c:664 iput_final fs/inode.c:1747 [inline] iput.part.0+0x59b/0x880 fs/inode.c:1773 iput+0x5c/0x80 fs/inode.c:1763 ext4_ext_migrate+0xc99/0x1ce0 fs/ext4/migrate.c:587 __ext4_ioctl+0x1fb2/0x4b60 fs/ext4/ioctl.c:1392 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: sb_internal --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#8); lock(&sbi->s_writepages_rwsem); lock(sb_internal); *** DEADLOCK *** 3 locks held by syz-executor.3/16990: #0: ffff88802a510460 (sb_writers#4){.+.+}-{0:0}, at: __ext4_ioctl+0x1f80/0x4b60 fs/ext4/ioctl.c:1382 #1: ffff8880834f6850 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff8880834f6850 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: __ext4_ioctl+0x1faa/0x4b60 fs/ext4/ioctl.c:1391 #2: ffff88802a512b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_ext_migrate+0x326/0x1ce0 fs/ext4/migrate.c:437 stack backtrace: CPU: 0 PID: 16990 Comm: syz-executor.3 Not tainted 6.1.0-syzkaller-14127-gec34c2b4ec38 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain kernel/locking/lockdep.c:3831 [inline] __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 lock_acquire kernel/locking/lockdep.c:5668 [inline] lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1811 [inline] sb_start_intwrite include/linux/fs.h:1933 [inline] ext4_evict_inode+0x1327/0x1eb0 fs/ext4/inode.c:240 evict+0x2ed/0x6b0 fs/inode.c:664 iput_final fs/inode.c:1747 [inline] iput.part.0+0x59b/0x880 fs/inode.c:1773 iput+0x5c/0x80 fs/inode.c:1763 ext4_ext_migrate+0xc99/0x1ce0 fs/ext4/migrate.c:587 __ext4_ioctl+0x1fb2/0x4b60 fs/ext4/ioctl.c:1392 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __x64_sys_ioctl+0x197/0x210 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f2e11c8c0d9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f2e12a34168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f2e11dac050 RCX: 00007f2e11c8c0d9 RDX: 0000000000000000 RSI: 0000000000006609 RDI: 0000000000000003 RBP: 00007f2e11ce7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fff249d401f R14: 00007f2e12a34300 R15: 0000000000022000