====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc3-syzkaller-g573067a5a685 #0 Not tainted ------------------------------------------------------ syz.4.337/7971 is trying to acquire lock: ffff0000d7fa6610 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_acquire_dquot+0x5c0/0xa90 fs/ocfs2/quota_global.c:855 but task is already holding lock: ffff0000dda5b120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 ocfs2_acquire_dquot+0x268/0xa90 fs/ocfs2/quota_global.c:823 dqget+0x660/0xcec fs/quota/dquot.c:977 dquot_set_dqblk+0x40/0xeac fs/quota/dquot.c:2820 quota_setquota+0x618/0x6f0 fs/quota/quota.c:310 do_quotactl+0x508/0x698 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __arm64_sys_quotactl+0x2c0/0xc9c fs/quota/quota.c:917 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #5 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:818 [inline] ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 ocfs2_acquire_dquot+0x268/0xa90 fs/ocfs2/quota_global.c:823 dqget+0x660/0xcec fs/quota/dquot.c:977 dquot_set_dqblk+0x40/0xeac fs/quota/dquot.c:2820 quota_setquota+0x618/0x6f0 fs/quota/quota.c:310 do_quotactl+0x508/0x698 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __arm64_sys_quotactl+0x2c0/0xc9c fs/quota/quota.c:917 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #4 (&dquot->dq_lock){+.+.}-{4:4}: __mutex_lock_common+0x218/0x28f4 kernel/locking/mutex.c:585 __mutex_lock kernel/locking/mutex.c:735 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:787 wait_on_dquot fs/quota/dquot.c:354 [inline] dqget+0x5f0/0xcec fs/quota/dquot.c:972 __dquot_initialize+0x344/0xc04 fs/quota/dquot.c:1505 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1567 __ext4_new_inode+0x694/0x37dc fs/ext4/ialloc.c:992 ext4_xattr_inode_create fs/ext4/xattr.c:1486 [inline] ext4_xattr_inode_lookup_create+0x9e4/0x1a28 fs/ext4/xattr.c:1596 ext4_xattr_block_set+0x224/0x2e08 fs/ext4/xattr.c:1916 ext4_xattr_set_handle+0xc68/0x12d0 fs/ext4/xattr.c:2458 ext4_xattr_set+0x224/0x344 fs/ext4/xattr.c:2560 ext4_xattr_trusted_set+0x4c/0x64 fs/ext4/xattr_trusted.c:38 __vfs_setxattr+0x3d8/0x400 fs/xattr.c:200 __vfs_setxattr_noperm+0x110/0x578 fs/xattr.c:234 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:295 vfs_setxattr+0x1a8/0x344 fs/xattr.c:321 do_setxattr fs/xattr.c:636 [inline] filename_setxattr+0x260/0x404 fs/xattr.c:665 path_setxattrat+0x370/0x41c fs/xattr.c:713 __do_sys_lsetxattr fs/xattr.c:754 [inline] __se_sys_lsetxattr fs/xattr.c:750 [inline] __arm64_sys_lsetxattr+0xc0/0xdc fs/xattr.c:750 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #3 (&ei->xattr_sem){++++}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ext4_write_lock_xattr fs/ext4/xattr.h:154 [inline] ext4_xattr_set_handle+0x1dc/0x12d0 fs/ext4/xattr.c:2373 ext4_initxattrs+0xa4/0x11c fs/ext4/xattr_security.c:44 security_inode_init_security+0x73c/0x908 security/security.c:1847 ext4_init_security+0x44/0x58 fs/ext4/xattr_security.c:58 __ext4_new_inode+0x2ba8/0x37dc fs/ext4/ialloc.c:1324 ext4_create+0x234/0x480 fs/ext4/namei.c:2841 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x13e4/0x2b14 fs/namei.c:3984 do_filp_open+0x1e8/0x404 fs/namei.c:4014 do_sys_openat2+0x124/0x1b8 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_openat fs/open.c:1433 [inline] __se_sys_openat fs/open.c:1428 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1428 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0xf34/0x11c4 fs/jbd2/transaction.c:448 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:505 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3d0/0x71c fs/ocfs2/journal.c:352 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x840/0x4254 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_mknod+0xdc8/0x2438 fs/ocfs2/namei.c:347 ocfs2_create+0x194/0x4d4 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x13e4/0x2b14 fs/namei.c:3984 do_filp_open+0x1e8/0x404 fs/namei.c:4014 do_sys_openat2+0x124/0x1b8 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_openat fs/open.c:1433 [inline] __se_sys_openat fs/open.c:1428 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1428 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x58/0x2fc kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3c4/0x71c fs/ocfs2/journal.c:350 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x840/0x4254 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_mknod+0xdc8/0x2438 fs/ocfs2/namei.c:347 ocfs2_create+0x194/0x4d4 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x13e4/0x2b14 fs/namei.c:3984 do_filp_open+0x1e8/0x404 fs/namei.c:4014 do_sys_openat2+0x124/0x1b8 fs/open.c:1402 do_sys_open fs/open.c:1417 [inline] __do_sys_openat fs/open.c:1433 [inline] __se_sys_openat fs/open.c:1428 [inline] __arm64_sys_openat+0x1f0/0x240 fs/open.c:1428 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (sb_internal#4){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1725 [inline] sb_start_intwrite include/linux/fs.h:1908 [inline] ocfs2_start_trans+0x244/0x71c fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x5c0/0xa90 fs/ocfs2/quota_global.c:855 dqget+0x660/0xcec fs/quota/dquot.c:977 dquot_set_dqblk+0x40/0xeac fs/quota/dquot.c:2820 quota_setquota+0x618/0x6f0 fs/quota/quota.c:310 do_quotactl+0x508/0x698 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __arm64_sys_quotactl+0x2c0/0xc9c fs/quota/quota.c:917 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Chain exists of: sb_internal#4 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_quota_ip_alloc_sem_key); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7); lock(&ocfs2_quota_ip_alloc_sem_key); rlock(sb_internal#4); *** DEADLOCK *** 4 locks held by syz.4.337/7971: #0: ffff0000d7fa60e0 (&type->s_umount_key#78){++++}-{4:4}, at: __super_lock fs/super.c:58 [inline] #0: ffff0000d7fa60e0 (&type->s_umount_key#78){++++}-{4:4}, at: super_lock+0x244/0x33c fs/super.c:120 #1: ffff0000db57e0a8 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x25c/0xa90 fs/ocfs2/quota_global.c:818 #2: ffff0000dda5b480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #2: ffff0000dda5b480 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313 #3: ffff0000dda5b120 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314 stack backtrace: CPU: 0 UID: 0 PID: 7971 Comm: syz.4.337 Not tainted 6.13.0-rc3-syzkaller-g573067a5a685 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C) __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2074 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain kernel/locking/lockdep.c:3904 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5226 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5849 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1725 [inline] sb_start_intwrite include/linux/fs.h:1908 [inline] ocfs2_start_trans+0x244/0x71c fs/ocfs2/journal.c:348 ocfs2_acquire_dquot+0x5c0/0xa90 fs/ocfs2/quota_global.c:855 dqget+0x660/0xcec fs/quota/dquot.c:977 dquot_set_dqblk+0x40/0xeac fs/quota/dquot.c:2820 quota_setquota+0x618/0x6f0 fs/quota/quota.c:310 do_quotactl+0x508/0x698 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __arm64_sys_quotactl+0x2c0/0xc9c fs/quota/quota.c:917 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 (syz.4.337,7971,0):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xdf8356d3, computed 0x5b86c303. Applying ECC. (syz.4.337,7971,0):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0xdf8356d3, computed 0x4bf4182b (syz.4.337,7971,0):ocfs2_read_quota_phys_block:160 ERROR: status = -5 (syz.4.337,7971,0):ocfs2_quota_read:201 ERROR: status = -5 Quota error (device loop4): find_block_dqentry: Can't read quota tree block 6 Quota error (device loop4): qtree_read_dquot: Can't read quota structure for id 0 (syz.4.337,7971,0):ocfs2_acquire_dquot:885 ERROR: status = -5 (syz.4.337,7971,0):ocfs2_mknod:314 ERROR: status = -5 (syz.4.337,7971,1):ocfs2_mknod:502 ERROR: status = -5 (syz.4.337,7971,1):ocfs2_create:676 ERROR: status = -5 (syz.4.337,7971,1):ocfs2_block_check_validate:402 ERROR: CRC32 failed: stored: 0xdf8356d3, computed 0x5b86c303. Applying ECC. (syz.4.337,7971,1):ocfs2_block_check_validate:416 ERROR: Fixed CRC32 failed: stored: 0xdf8356d3, computed 0x4bf4182b (syz.4.337,7971,1):ocfs2_read_quota_phys_block:160 ERROR: status = -5 (syz.4.337,7971,1):ocfs2_quota_read:201 ERROR: status = -5 Quota error (device loop4): find_block_dqentry: Can't read quota tree block 6 Quota error (device loop4): qtree_read_dquot: Can't read quota structure for id 0 (syz.4.337,7971,1):ocfs2_acquire_dquot:885 ERROR: status = -5 (syz.4.337,7971,1):ocfs2_mknod:314 ERROR: status = -5 (syz.4.337,7971,1):ocfs2_mknod:502 ERROR: status = -5 (syz.4.337,7971,1):ocfs2_create:676 ERROR: status = -5