====================================================== WARNING: possible circular locking dependency detected 6.7.0-rc2-syzkaller-00014-gc2d5304e6c64 #0 Not tainted ------------------------------------------------------ syz-executor.4/19504 is trying to acquire lock: ffff888041e88860 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ffff888041e88860 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0x787/0x1070 fs/ntfs3/file.c:548 but task is already holding lock: ffff888041e88ca0 (mapping.invalidate_lock#13){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:847 [inline] ffff888041e88ca0 (mapping.invalidate_lock#13){++++}-{3:3}, at: ntfs_fallocate+0x3ac/0x1070 fs/ntfs3/file.c:484 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (mapping.invalidate_lock#13){++++}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 filemap_invalidate_lock_shared include/linux/fs.h:857 [inline] filemap_fault+0x646/0x1670 mm/filemap.c:3225 __do_fault+0x133/0x4e0 mm/memory.c:4265 do_read_fault mm/memory.c:4628 [inline] do_fault mm/memory.c:4762 [inline] do_pte_missing mm/memory.c:3730 [inline] handle_pte_fault mm/memory.c:5038 [inline] __handle_mm_fault mm/memory.c:5179 [inline] handle_mm_fault+0x4c9b/0x6680 mm/memory.c:5344 do_user_addr_fault arch/x86/mm/fault.c:1413 [inline] handle_page_fault arch/x86/mm/fault.c:1505 [inline] exc_page_fault+0x2ad/0x870 arch/x86/mm/fault.c:1561 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 strncpy_from_user+0x111/0x2e0 lib/strncpy_from_user.c:139 getname_flags+0xf9/0x4f0 fs/namei.c:151 do_sys_openat2+0xd2/0x1d0 fs/open.c:1434 do_sys_open fs/open.c:1455 [inline] __do_sys_openat fs/open.c:1471 [inline] __se_sys_openat fs/open.c:1466 [inline] __x64_sys_openat+0x247/0x290 fs/open.c:1466 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #1 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753 __might_fault+0xc1/0x120 mm/memory.c:5955 _copy_to_user+0x2a/0xa0 lib/usercopy.c:36 copy_to_user include/linux/uaccess.h:191 [inline] fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145 ni_fiemap+0x100b/0x1230 fs/ntfs3/frecord.c:1948 ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1164 ioctl_fiemap fs/ioctl.c:220 [inline] do_vfs_ioctl+0x19ea/0x2b40 fs/ioctl.c:811 __do_sys_ioctl fs/ioctl.c:869 [inline] __se_sys_ioctl+0x81/0x170 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e4/0x59f0 kernel/locking/lockdep.c:3868 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ntfs_fallocate+0x787/0x1070 fs/ntfs3/file.c:548 vfs_fallocate+0x551/0x6b0 fs/open.c:324 ksys_fallocate fs/open.c:347 [inline] __do_sys_fallocate fs/open.c:355 [inline] __se_sys_fallocate fs/open.c:353 [inline] __x64_sys_fallocate+0xbd/0x100 fs/open.c:353 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Chain exists of: &ni->ni_lock/4 --> &mm->mmap_lock --> mapping.invalidate_lock#13 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(mapping.invalidate_lock#13); lock(&mm->mmap_lock); lock(mapping.invalidate_lock#13); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz-executor.4/19504: #0: ffff888018716418 (sb_writers#24){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2713 [inline] #0: ffff888018716418 (sb_writers#24){.+.+}-{0:0}, at: vfs_fallocate+0x4c4/0x6b0 fs/open.c:323 #1: ffff888041e88b00 (&sb->s_type->i_mutex_key#43){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #1: ffff888041e88b00 (&sb->s_type->i_mutex_key#43){+.+.}-{3:3}, at: ntfs_fallocate+0x2dd/0x1070 fs/ntfs3/file.c:470 #2: ffff888041e88ca0 (mapping.invalidate_lock#13){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:847 [inline] #2: ffff888041e88ca0 (mapping.invalidate_lock#13){++++}-{3:3}, at: ntfs_fallocate+0x3ac/0x1070 fs/ntfs3/file.c:484 stack backtrace: CPU: 0 PID: 19504 Comm: syz-executor.4 Not tainted 6.7.0-rc2-syzkaller-00014-gc2d5304e6c64 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x366/0x490 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e4/0x59f0 kernel/locking/lockdep.c:3868 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5136 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5753 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ntfs_fallocate+0x787/0x1070 fs/ntfs3/file.c:548 vfs_fallocate+0x551/0x6b0 fs/open.c:324 ksys_fallocate fs/open.c:347 [inline] __do_sys_fallocate fs/open.c:355 [inline] __se_sys_fallocate fs/open.c:353 [inline] __x64_sys_fallocate+0xbd/0x100 fs/open.c:353 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f7ace47cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f7acf1520c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d RAX: ffffffffffffffda RBX: 00007f7ace59bf80 RCX: 00007f7ace47cae9 RDX: 0000000000002000 RSI: 0000000000000008 RDI: 0000000000000004 RBP: 00007f7ace4c847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000001000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f7ace59bf80 R15: 00007ffd26c9de98