overlay: ./file2 is not a directory ====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc3-syzkaller-00044-gaef25be35d23 #0 Not tainted ------------------------------------------------------ syz.2.14/5997 is trying to acquire lock: ffff888048478610 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_setattr+0x9dd/0x1ef0 fs/ocfs2/file.c:1263 but task is already holding lock: ffff88805c086a20 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x9d0/0x1ef0 fs/ocfs2/file.c:1262 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_alloc_sem){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_try_remove_refcount_tree+0xb6/0x330 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0xa4f/0x1930 fs/ocfs2/xattr.c:3669 ocfs2_set_acl+0x4cb/0x580 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x24a/0x3c0 fs/ocfs2/acl.c:286 set_posix_acl fs/posix_acl.c:954 [inline] vfs_remove_acl+0x4cb/0x770 fs/posix_acl.c:1241 ovl_do_remove_acl fs/overlayfs/overlayfs.h:352 [inline] ovl_workdir_create+0x52f/0x980 fs/overlayfs/super.c:334 ovl_make_workdir fs/overlayfs/super.c:650 [inline] ovl_get_workdir+0x311/0x1920 fs/overlayfs/super.c:808 ovl_fill_super+0x12a8/0x3560 fs/overlayfs/super.c:1376 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb7/0x140 fs/super.c:1299 vfs_get_tree+0x90/0x2b0 fs/super.c:1814 do_new_mount+0x2be/0xb40 fs/namespace.c:3507 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&oi->ip_xattr_sem){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_xattr_get+0x110/0x2c0 fs/ocfs2/xattr.c:1338 __vfs_getxattr+0x433/0x470 fs/xattr.c:423 smk_fetch+0xb1/0x140 security/smack/smack_lsm.c:306 smack_d_instantiate+0x749/0xa50 security/smack/smack_lsm.c:3615 security_d_instantiate+0x107/0x1f0 security/security.c:4070 d_instantiate+0x55/0xa0 fs/dcache.c:1902 ocfs2_symlink+0x2471/0x2d80 fs/ocfs2/namei.c:2041 vfs_symlink+0x137/0x2e0 fs/namei.c:4669 do_symlinkat+0x222/0x3a0 fs/namei.c:4695 __do_sys_symlink fs/namei.c:4716 [inline] __se_sys_symlink fs/namei.c:4714 [inline] __x64_sys_symlink+0x7a/0x90 fs/namei.c:4714 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448 jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505 jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3c9/0x700 fs/ocfs2/journal.c:352 ocfs2_symlink+0x1401/0x2d80 fs/ocfs2/namei.c:1928 vfs_symlink+0x137/0x2e0 fs/namei.c:4669 do_symlinkat+0x222/0x3a0 fs/namei.c:4695 __do_sys_symlink fs/namei.c:4716 [inline] __se_sys_symlink fs/namei.c:4714 [inline] __x64_sys_symlink+0x7a/0x90 fs/namei.c:4714 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350 ocfs2_symlink+0x1401/0x2d80 fs/ocfs2/namei.c:1928 vfs_symlink+0x137/0x2e0 fs/namei.c:4669 do_symlinkat+0x222/0x3a0 fs/namei.c:4695 __do_sys_symlink fs/namei.c:4716 [inline] __se_sys_symlink fs/namei.c:4714 [inline] __x64_sys_symlink+0x7a/0x90 fs/namei.c:4714 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (sb_internal#4){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1725 [inline] sb_start_intwrite include/linux/fs.h:1908 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_setattr+0x9dd/0x1ef0 fs/ocfs2/file.c:1263 notify_change+0xbca/0xe90 fs/attr.c:552 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline] ovl_workdir_create+0x782/0x980 fs/overlayfs/super.c:344 ovl_make_workdir fs/overlayfs/super.c:650 [inline] ovl_get_workdir+0x311/0x1920 fs/overlayfs/super.c:808 ovl_fill_super+0x12a8/0x3560 fs/overlayfs/super.c:1376 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb7/0x140 fs/super.c:1299 vfs_get_tree+0x90/0x2b0 fs/super.c:1814 do_new_mount+0x2be/0xb40 fs/namespace.c:3507 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: sb_internal#4 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_alloc_sem); lock(&oi->ip_xattr_sem); lock(&oi->ip_alloc_sem); rlock(sb_internal#4); *** DEADLOCK *** 5 locks held by syz.2.14/5997: #0: ffff888022f780e0 (&type->s_umount_key#52/1){+.+.}-{4:4}, at: alloc_super+0x221/0x9d0 fs/super.c:344 #1: ffff888048478420 (sb_writers#19){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:515 #2: ffff88805c085f40 (&sb->s_type->i_mutex_key#29/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:853 [inline] #2: ffff88805c085f40 (&sb->s_type->i_mutex_key#29/1){+.+.}-{4:4}, at: ovl_workdir_create+0x160/0x980 fs/overlayfs/super.c:284 #3: ffff88805c086d80 (&sb->s_type->i_mutex_key#29){++++}-{4:4}, at: inode_lock include/linux/fs.h:818 [inline] #3: ffff88805c086d80 (&sb->s_type->i_mutex_key#29){++++}-{4:4}, at: ovl_workdir_create+0x6e3/0x980 fs/overlayfs/super.c:343 #4: ffff88805c086a20 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x9d0/0x1ef0 fs/ocfs2/file.c:1262 stack backtrace: CPU: 0 UID: 0 PID: 5997 Comm: syz.2.14 Not tainted 6.13.0-rc3-syzkaller-00044-gaef25be35d23 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/25/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1725 [inline] sb_start_intwrite include/linux/fs.h:1908 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_setattr+0x9dd/0x1ef0 fs/ocfs2/file.c:1263 notify_change+0xbca/0xe90 fs/attr.c:552 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline] ovl_workdir_create+0x782/0x980 fs/overlayfs/super.c:344 ovl_make_workdir fs/overlayfs/super.c:650 [inline] ovl_get_workdir+0x311/0x1920 fs/overlayfs/super.c:808 ovl_fill_super+0x12a8/0x3560 fs/overlayfs/super.c:1376 vfs_get_super fs/super.c:1280 [inline] get_tree_nodev+0xb7/0x140 fs/super.c:1299 vfs_get_tree+0x90/0x2b0 fs/super.c:1814 do_new_mount+0x2be/0xb40 fs/namespace.c:3507 do_mount fs/namespace.c:3847 [inline] __do_sys_mount fs/namespace.c:4057 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4034 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fb10ff85d29 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb10fdf9038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007fb110175fa0 RCX: 00007fb10ff85d29 RDX: 0000000020000340 RSI: 00000000200000c0 RDI: 0000000000000000 RBP: 00007fb110001a20 R08: 0000000020000080 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fb110175fa0 R15: 00007ffec3b673b8 overlayfs: upper fs does not support tmpfile. overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: upper fs missing required features.