====================================================== WARNING: possible circular locking dependency detected 6.1.15-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/26556 is trying to acquire lock: ffff8880281f4170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x2a8/0x370 fs/jbd2/transaction.c:904 but task is already holding lock: ffff8880281f2b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x1a0/0x6e0 fs/ext4/inode.c:6087 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&sbi->s_writepages_rwsem){++++}-{0:0}: lock_acquire+0x231/0x620 kernel/locking/lockdep.c:5668 percpu_down_write+0x50/0x2e0 kernel/locking/percpu-rwsem.c:227 ext4_ind_migrate+0x254/0x760 fs/ext4/migrate.c:624 ext4_ioctl_setflags fs/ext4/ioctl.c:696 [inline] ext4_fileattr_set+0xe9b/0x1770 fs/ext4/ioctl.c:1004 vfs_fileattr_set+0x8ee/0xd30 fs/ioctl.c:696 ioctl_setflags fs/ioctl.c:728 [inline] do_vfs_ioctl+0x1cd1/0x2a90 fs/ioctl.c:839 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (&sb->s_type->i_mutex_key#8){++++}-{3:3}: lock_acquire+0x231/0x620 kernel/locking/lockdep.c:5668 down_read+0x39/0x50 kernel/locking/rwsem.c:1509 inode_lock_shared include/linux/fs.h:766 [inline] ext4_bmap+0x4b/0x410 fs/ext4/inode.c:3171 bmap+0xa1/0xd0 fs/inode.c:1798 jbd2_journal_bmap fs/jbd2/journal.c:977 [inline] __jbd2_journal_erase fs/jbd2/journal.c:1789 [inline] jbd2_journal_flush+0x5b5/0xc40 fs/jbd2/journal.c:2492 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline] __ext4_ioctl fs/ext4/ioctl.c:1590 [inline] ext4_ioctl+0x3a7d/0x61c0 fs/ext4/ioctl.c:1610 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: lock_acquire+0x231/0x620 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603 mutex_lock_io_nested+0x43/0x60 kernel/locking/mutex.c:833 jbd2_journal_flush+0x29b/0xc40 fs/jbd2/journal.c:2464 ext4_ioctl_checkpoint fs/ext4/ioctl.c:1082 [inline] __ext4_ioctl fs/ext4/ioctl.c:1590 [inline] ext4_ioctl+0x3a7d/0x61c0 fs/ext4/ioctl.c:1610 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&journal->j_barrier){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3831 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5055 lock_acquire+0x231/0x620 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 jbd2_journal_lock_updates+0x2a8/0x370 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x1a8/0x6e0 fs/ext4/inode.c:6088 ext4_ioctl_setflags fs/ext4/ioctl.c:687 [inline] ext4_fileattr_set+0xe04/0x1770 fs/ext4/ioctl.c:1004 vfs_fileattr_set+0x8ee/0xd30 fs/ioctl.c:696 ioctl_setflags fs/ioctl.c:728 [inline] do_vfs_ioctl+0x1cd1/0x2a90 fs/ioctl.c:839 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &journal->j_barrier --> &sb->s_type->i_mutex_key#8 --> &sbi->s_writepages_rwsem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->s_writepages_rwsem); lock(&sb->s_type->i_mutex_key#8); lock(&sbi->s_writepages_rwsem); lock(&journal->j_barrier); *** DEADLOCK *** 4 locks held by syz-executor.2/26556: #0: ffff8880281f0460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write_file+0x5a/0x1f0 fs/namespace.c:437 #1: ffff88805068ca38 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff88805068ca38 (&sb->s_type->i_mutex_key#8){++++}-{3:3}, at: vfs_fileattr_set+0x135/0xd30 fs/ioctl.c:681 #2: ffff88805068cbd8 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:801 [inline] #2: ffff88805068cbd8 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_change_inode_journal_flag+0x115/0x6e0 fs/ext4/inode.c:6079 #3: ffff8880281f2b98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_change_inode_journal_flag+0x1a0/0x6e0 fs/ext4/inode.c:6087 stack backtrace: CPU: 1 PID: 26556 Comm: syz-executor.2 Not tainted 6.1.15-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2177 check_prev_add kernel/locking/lockdep.c:3097 [inline] check_prevs_add kernel/locking/lockdep.c:3216 [inline] validate_chain+0x1667/0x58e0 kernel/locking/lockdep.c:3831 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5055 lock_acquire+0x231/0x620 kernel/locking/lockdep.c:5668 __mutex_lock_common+0x1d4/0x2520 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:799 jbd2_journal_lock_updates+0x2a8/0x370 fs/jbd2/transaction.c:904 ext4_change_inode_journal_flag+0x1a8/0x6e0 fs/ext4/inode.c:6088 ext4_ioctl_setflags fs/ext4/ioctl.c:687 [inline] ext4_fileattr_set+0xe04/0x1770 fs/ext4/ioctl.c:1004 vfs_fileattr_set+0x8ee/0xd30 fs/ioctl.c:696 ioctl_setflags fs/ioctl.c:728 [inline] do_vfs_ioctl+0x1cd1/0x2a90 fs/ioctl.c:839 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl+0x81/0x160 fs/ioctl.c:856 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f821a68c0f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f821b356168 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f821a7abf80 RCX: 00007f821a68c0f9 RDX: 0000000020000140 RSI: 0000000040086602 RDI: 0000000000000005 RBP: 00007f821a6e7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffd1ad7e38f R14: 00007f821b356300 R15: 0000000000022000