====================================================== WARNING: possible circular locking dependency detected 6.4.0-rc2-next-20230515-syzkaller #0 Not tainted ------------------------------------------------------ kworker/u4:24/6164 is trying to acquire lock: ffff8880223ae120 (&wnd->rw_lock/1){+.+.}-{3:3}, at: ntfs_mark_rec_free+0x229/0x310 fs/ntfs3/fsntfs.c:742 but task is already holding lock: ffff8880757e5220 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1144 [inline] ffff8880757e5220 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x1aa/0x2920 fs/ntfs3/frecord.c:3256 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&ni->ni_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 ntfs_set_state fs/ntfs3/fsntfs.c:946 [inline] ntfs_set_state+0x1d5/0x700 fs/ntfs3/fsntfs.c:920 attr_set_size+0x1346/0x2ab0 fs/ntfs3/attrib.c:866 ntfs_extend_mft+0x296/0x430 fs/ntfs3/fsntfs.c:527 ntfs_look_free_mft+0x548/0xe60 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0xc0a/0x1400 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x3ca/0xba0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x3ea/0x850 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xd9/0x3a0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xa3b/0x1380 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x12b/0x3d0 fs/ntfs3/xattr.c:946 ntfs3_setattr+0xa2b/0xc30 fs/ntfs3/file.c:708 notify_change+0xb2c/0x1180 fs/attr.c:483 chown_common+0x57f/0x650 fs/open.c:774 do_fchownat+0x12a/0x1e0 fs/open.c:805 __do_sys_lchown fs/open.c:830 [inline] __se_sys_lchown fs/open.c:828 [inline] __x64_sys_lchown+0x7e/0xc0 fs/open.c:828 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #1 (&ni->file.run_lock#2){++++}-{3:3}: down_write+0x92/0x200 kernel/locking/rwsem.c:1573 ntfs_extend_mft+0x127/0x430 fs/ntfs3/fsntfs.c:511 ntfs_look_free_mft+0x548/0xe60 fs/ntfs3/fsntfs.c:590 ni_create_attr_list+0xc0a/0x1400 fs/ntfs3/frecord.c:876 ni_ins_attr_ext+0x3ca/0xba0 fs/ntfs3/frecord.c:974 ni_insert_attr+0x3ea/0x850 fs/ntfs3/frecord.c:1141 ni_insert_resident+0xd9/0x3a0 fs/ntfs3/frecord.c:1525 ntfs_set_ea+0xa3b/0x1380 fs/ntfs3/xattr.c:437 ntfs_save_wsl_perm+0x12b/0x3d0 fs/ntfs3/xattr.c:946 ntfs3_setattr+0xa2b/0xc30 fs/ntfs3/file.c:708 notify_change+0xb2c/0x1180 fs/attr.c:483 chown_common+0x57f/0x650 fs/open.c:774 do_fchownat+0x12a/0x1e0 fs/open.c:805 __do_sys_lchown fs/open.c:830 [inline] __se_sys_lchown fs/open.c:828 [inline] __x64_sys_lchown+0x7e/0xc0 fs/open.c:828 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&wnd->rw_lock/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3113 [inline] check_prevs_add kernel/locking/lockdep.c:3232 [inline] validate_chain kernel/locking/lockdep.c:3847 [inline] __lock_acquire+0x2fcd/0x5f30 kernel/locking/lockdep.c:5088 lock_acquire.part.0+0x11c/0x370 kernel/locking/lockdep.c:5705 down_write_nested+0x96/0x200 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x229/0x310 fs/ntfs3/fsntfs.c:742 ni_write_inode+0xea4/0x2920 fs/ntfs3/frecord.c:3352 write_inode fs/fs-writeback.c:1456 [inline] __writeback_single_inode+0x9f2/0xdb0 fs/fs-writeback.c:1668 writeback_sb_inodes+0x54d/0xe70 fs/fs-writeback.c:1894 wb_writeback+0x155/0xa40 fs/fs-writeback.c:2070 wb_do_writeback fs/fs-writeback.c:2217 [inline] wb_workfn+0x2a5/0xcc0 fs/fs-writeback.c:2257 process_one_work+0x99a/0x15e0 kernel/workqueue.c:2407 worker_thread+0x67d/0x10c0 kernel/workqueue.c:2554 kthread+0x344/0x440 kernel/kthread.c:379 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 other info that might help us debug this: Chain exists of: &wnd->rw_lock/1 --> &ni->file.run_lock#2 --> &ni->ni_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock); lock(&ni->file.run_lock#2); lock(&ni->ni_lock); lock(&wnd->rw_lock/1); *** DEADLOCK *** 3 locks held by kworker/u4:24/6164: #0: ffff888012aa5938 ((wq_completion)writeback){+.+.}-{0:0}, at: arch_atomic64_set arch/x86/include/asm/atomic64_64.h:34 [inline] #0: ffff888012aa5938 ((wq_completion)writeback){+.+.}-{0:0}, at: arch_atomic_long_set include/linux/atomic/atomic-long.h:41 [inline] #0: ffff888012aa5938 ((wq_completion)writeback){+.+.}-{0:0}, at: atomic_long_set include/linux/atomic/atomic-instrumented.h:1324 [inline] #0: ffff888012aa5938 ((wq_completion)writeback){+.+.}-{0:0}, at: set_work_data kernel/workqueue.c:643 [inline] #0: ffff888012aa5938 ((wq_completion)writeback){+.+.}-{0:0}, at: set_work_pool_and_clear_pending kernel/workqueue.c:670 [inline] #0: ffff888012aa5938 ((wq_completion)writeback){+.+.}-{0:0}, at: process_one_work+0x883/0x15e0 kernel/workqueue.c:2378 #1: ffffc90016017db0 ((work_completion)(&(&wb->dwork)->work)){+.+.}-{0:0}, at: process_one_work+0x8b7/0x15e0 kernel/workqueue.c:2382 #2: ffff8880757e5220 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1144 [inline] #2: ffff8880757e5220 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x1aa/0x2920 fs/ntfs3/frecord.c:3256 stack backtrace: CPU: 1 PID: 6164 Comm: kworker/u4:24 Not tainted 6.4.0-rc2-next-20230515-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/16/2023 Workqueue: writeback wb_workfn (flush-7:4) Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2188 check_prev_add kernel/locking/lockdep.c:3113 [inline] check_prevs_add kernel/locking/lockdep.c:3232 [inline] validate_chain kernel/locking/lockdep.c:3847 [inline] __lock_acquire+0x2fcd/0x5f30 kernel/locking/lockdep.c:5088 lock_acquire.part.0+0x11c/0x370 kernel/locking/lockdep.c:5705 down_write_nested+0x96/0x200 kernel/locking/rwsem.c:1689 ntfs_mark_rec_free+0x229/0x310 fs/ntfs3/fsntfs.c:742 ni_write_inode+0xea4/0x2920 fs/ntfs3/frecord.c:3352 write_inode fs/fs-writeback.c:1456 [inline] __writeback_single_inode+0x9f2/0xdb0 fs/fs-writeback.c:1668 writeback_sb_inodes+0x54d/0xe70 fs/fs-writeback.c:1894 wb_writeback+0x155/0xa40 fs/fs-writeback.c:2070 wb_do_writeback fs/fs-writeback.c:2217 [inline] wb_workfn+0x2a5/0xcc0 fs/fs-writeback.c:2257 process_one_work+0x99a/0x15e0 kernel/workqueue.c:2407 worker_thread+0x67d/0x10c0 kernel/workqueue.c:2554 kthread+0x344/0x440 kernel/kthread.c:379 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308