====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.0.0/5321 is trying to acquire lock: ffff888048981800 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline] ffff888048981800 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16f/0x4790 fs/ocfs2/suballoc.c:789 but task is already holding lock: ffff8880489786f8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3613 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&oi->ip_xattr_sem){++++}-{4:4}: down_read+0x47/0x2e0 kernel/locking/rwsem.c:1537 ocfs2_init_acl+0x2fd/0x7e0 fs/ocfs2/acl.c:367 ocfs2_mknod+0x1423/0x2210 fs/ocfs2/namei.c:414 ocfs2_create+0x195/0x440 fs/ocfs2/namei.c:677 lookup_open fs/namei.c:4449 [inline] open_last_lookups fs/namei.c:4549 [inline] path_openat+0x18dd/0x3e20 fs/namei.c:4793 do_filp_open+0x22d/0x490 fs/namei.c:4823 do_sys_openat2+0x12f/0x220 fs/open.c:1430 do_sys_open fs/open.c:1436 [inline] __do_sys_open fs/open.c:1444 [inline] __se_sys_open fs/open.c:1440 [inline] __x64_sys_open+0x11e/0x150 fs/open.c:1440 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x47/0x2e0 kernel/locking/rwsem.c:1537 ocfs2_start_trans+0x3ab/0x700 fs/ocfs2/journal.c:372 ocfs2_modify_bh+0xe3/0x4d0 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x1454/0x1810 fs/ocfs2/quota_local.c:767 dquot_load_quota_sb+0x791/0xbd0 fs/quota/dquot.c:2462 dquot_load_quota_inode+0x2e1/0x5d0 fs/quota/dquot.c:2499 ocfs2_enable_quotas+0x1c8/0x4a0 fs/ocfs2/super.c:930 ocfs2_fill_super+0x5337/0x6910 fs/ocfs2/super.c:1140 get_tree_bdev_flags+0x431/0x4f0 fs/super.c:1691 vfs_get_tree+0x92/0x2a0 fs/super.c:1751 fc_mount fs/namespace.c:1199 [inline] do_new_mount_fc fs/namespace.c:3636 [inline] do_new_mount+0x329/0xa50 fs/namespace.c:3712 do_mount fs/namespace.c:4035 [inline] __do_sys_mount fs/namespace.c:4224 [inline] __se_sys_mount+0x31d/0x420 fs/namespace.c:4201 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (sb_internal#2){.+.+}-{0:0}: __lock_release kernel/locking/lockdep.c:5574 [inline] lock_release+0x199/0x3a0 kernel/locking/lockdep.c:5889 up_write+0x2d/0x410 kernel/locking/rwsem.c:1642 inode_unlock include/linux/fs.h:1037 [inline] ocfs2_free_ac_resource fs/ocfs2/suballoc.c:131 [inline] ocfs2_free_alloc_context+0x97/0x1a0 fs/ocfs2/suballoc.c:145 ocfs2_write_begin_nolock+0x40b8/0x4140 fs/ocfs2/aops.c:1804 ocfs2_dio_wr_get_block+0xbbf/0x1800 fs/ocfs2/aops.c:2214 get_more_blocks fs/direct-io.c:648 [inline] do_direct_IO fs/direct-io.c:936 [inline] __blockdev_direct_IO+0x15d7/0x32f0 fs/direct-io.c:1243 ocfs2_direct_IO+0x251/0x2c0 fs/ocfs2/aops.c:2441 generic_file_direct_write+0x1db/0x3e0 mm/filemap.c:4248 __generic_file_write_iter+0x11d/0x230 mm/filemap.c:4417 ocfs2_file_write_iter+0x1663/0x1e20 fs/ocfs2/file.c:2475 do_iter_readv_writev+0x619/0x8c0 fs/read_write.c:-1 vfs_writev+0x33c/0x990 fs/read_write.c:1057 do_pwritev fs/read_write.c:1153 [inline] __do_sys_pwritev2 fs/read_write.c:1211 [inline] __se_sys_pwritev2+0x184/0x2a0 fs/read_write.c:1202 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237 lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868 down_write+0x96/0x200 kernel/locking/rwsem.c:1590 inode_lock include/linux/fs.h:1027 [inline] ocfs2_reserve_suballoc_bits+0x16f/0x4790 fs/ocfs2/suballoc.c:789 ocfs2_reserve_new_metadata_blocks+0x415/0x9a0 fs/ocfs2/suballoc.c:985 ocfs2_init_xattr_set_ctxt+0x30a/0x710 fs/ocfs2/xattr.c:3307 ocfs2_xattr_set+0xc42/0x13e0 fs/ocfs2/xattr.c:3664 ocfs2_set_acl+0x701/0x7b0 fs/ocfs2/acl.c:255 ocfs2_iop_set_acl+0x1b1/0x2b0 fs/ocfs2/acl.c:287 set_posix_acl fs/posix_acl.c:954 [inline] vfs_set_acl+0x87d/0xb00 fs/posix_acl.c:1133 do_set_acl+0xf5/0x190 fs/posix_acl.c:1278 do_setxattr fs/xattr.c:633 [inline] filename_setxattr+0x2fc/0x630 fs/xattr.c:665 path_setxattrat+0x3f3/0x430 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:743 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_xattr_sem); lock(&journal->j_trans_barrier); lock(&oi->ip_xattr_sem); lock(&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]); *** DEADLOCK *** 3 locks held by syz.0.0/5321: #0: ffff888011e8e420 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90 fs/namespace.c:499 #1: ffff8880489789c0 (&type->i_mutex_dir_key#8){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:1027 [inline] #1: ffff8880489789c0 (&type->i_mutex_dir_key#8){+.+.}-{4:4}, at: vfs_set_acl+0x3cd/0xb00 fs/posix_acl.c:1114 #2: ffff8880489786f8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0 fs/ocfs2/xattr.c:3613 stack backtrace: CPU: 0 UID: 0 PID: 5321 Comm: syz.0.0 Not tainted syzkaller #0 PREEMPT(full) Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2 04/01/2014 Call Trace: dump_stack_lvl+0xe8/0x150 lib/dump_stack.c:120 print_circular_bug+0x2e1/0x300 kernel/locking/lockdep.c:2043 check_noncircular+0x12e/0x150 kernel/locking/lockdep.c:2175 check_prev_add kernel/locking/lockdep.c:3165 [inline] check_prevs_add kernel/locking/lockdep.c:3284 [inline] validate_chain kernel/locking/lockdep.c:3908 [inline] __lock_acquire+0x15a5/0x2cf0 kernel/locking/lockdep.c:5237 lock_acquire+0x106/0x330 kernel/locking/lockdep.c:5868 down_write+0x96/0x200 kernel/locking/rwsem.c:1590 inode_lock include/linux/fs.h:1027 [inline] ocfs2_reserve_suballoc_bits+0x16f/0x4790 fs/ocfs2/suballoc.c:789 ocfs2_reserve_new_metadata_blocks+0x415/0x9a0 fs/ocfs2/suballoc.c:985 ocfs2_init_xattr_set_ctxt+0x30a/0x710 fs/ocfs2/xattr.c:3307 ocfs2_xattr_set+0xc42/0x13e0 fs/ocfs2/xattr.c:3664 ocfs2_set_acl+0x701/0x7b0 fs/ocfs2/acl.c:255 ocfs2_iop_set_acl+0x1b1/0x2b0 fs/ocfs2/acl.c:287 set_posix_acl fs/posix_acl.c:954 [inline] vfs_set_acl+0x87d/0xb00 fs/posix_acl.c:1133 do_set_acl+0xf5/0x190 fs/posix_acl.c:1278 do_setxattr fs/xattr.c:633 [inline] filename_setxattr+0x2fc/0x630 fs/xattr.c:665 path_setxattrat+0x3f3/0x430 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:743 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xe2/0xf80 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fcc7779aeb9 Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fcc78690028 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc RAX: ffffffffffffffda RBX: 00007fcc77a16090 RCX: 00007fcc7779aeb9 RDX: 00002000000003c0 RSI: 0000200000002a40 RDI: 0000200000002a00 RBP: 00007fcc77808c1f R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000024 R11: 0000000000000246 R12: 0000000000000000 R13: 00007fcc77a16128 R14: 00007fcc77a16090 R15: 00007ffe799162d8