ntfs3: loop5: Inode r=19 is not in use! ntfs3: loop5: Mark volume as dirty due to NTFS errors ====================================================== WARNING: possible circular locking dependency detected 5.15.170-syzkaller #0 Not tainted ------------------------------------------------------ syz.5.383/5981 is trying to acquire lock: ffff0000e67a3c00 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] ffff0000e67a3c00 (&ni->ni_lock/4){+.+.}-{3:3}, at: mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 but task is already holding lock: ffff0000e64a3c00 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1115 [inline] ffff0000e64a3c00 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x12c/0xe38 fs/ntfs3/frecord.c:3198 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock){+.+.}-{3:3}: __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:925 ni_remove_name+0x230/0x7a4 fs/ntfs3/frecord.c:2880 ni_rename+0x14c/0x1d8 fs/ntfs3/frecord.c:3025 ntfs_rename+0x5c4/0xb10 fs/ntfs3/namei.c:318 vfs_rename+0xac8/0xe04 fs/namei.c:4832 do_renameat2+0xa00/0x10c0 fs/namei.c:4985 __do_sys_renameat2 fs/namei.c:5018 [inline] __se_sys_renameat2 fs/namei.c:5015 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5015 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x358/0x2be0 fs/ntfs3/inode.c:525 ni_update_parent+0x6f0/0xac8 fs/ntfs3/frecord.c:3154 ni_write_inode+0x8a0/0xe38 fs/ntfs3/frecord.c:3252 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1037 write_inode fs/fs-writeback.c:1495 [inline] __writeback_single_inode+0x584/0x13a4 fs/fs-writeback.c:1705 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1760 write_inode_now+0x240/0x2d0 fs/fs-writeback.c:2800 ntfs_extend+0x310/0x408 fs/ntfs3/file.c:455 ntfs_file_write_iter+0x2a0/0x49c fs/ntfs3/file.c:1138 call_write_iter include/linux/fs.h:2174 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x884/0xb44 fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); *** DEADLOCK *** 4 locks held by syz.5.383/5981: #0: ffff0000c5522af0 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x128/0x170 fs/file.c:1057 #1: ffff0000d5016460 (sb_writers#19){.+.+}-{0:0}, at: vfs_write+0x228/0xb44 fs/read_write.c:590 #2: ffff0000e64a3ea0 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:809 [inline] #2: ffff0000e64a3ea0 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: ntfs_file_write_iter+0x194/0x49c fs/ntfs3/file.c:1122 #3: ffff0000e64a3c00 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1115 [inline] #3: ffff0000e64a3c00 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x12c/0xe38 fs/ntfs3/frecord.c:3198 stack backtrace: CPU: 0 PID: 5981 Comm: syz.5.383 Not tainted 5.15.170-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call trace: dump_backtrace+0x0/0x530 arch/arm64/kernel/stacktrace.c:152 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2011 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x32d4/0x7638 kernel/locking/lockdep.c:5012 lock_acquire+0x240/0x77c kernel/locking/lockdep.c:5623 __mutex_lock_common+0x194/0x2154 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0xa4/0xf8 kernel/locking/mutex.c:743 ni_lock fs/ntfs3/ntfs_fs.h:1100 [inline] mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x358/0x2be0 fs/ntfs3/inode.c:525 ni_update_parent+0x6f0/0xac8 fs/ntfs3/frecord.c:3154 ni_write_inode+0x8a0/0xe38 fs/ntfs3/frecord.c:3252 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1037 write_inode fs/fs-writeback.c:1495 [inline] __writeback_single_inode+0x584/0x13a4 fs/fs-writeback.c:1705 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1760 write_inode_now+0x240/0x2d0 fs/fs-writeback.c:2800 ntfs_extend+0x310/0x408 fs/ntfs3/file.c:455 ntfs_file_write_iter+0x2a0/0x49c fs/ntfs3/file.c:1138 call_write_iter include/linux/fs.h:2174 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0x884/0xb44 fs/read_write.c:594 ksys_write+0x15c/0x26c fs/read_write.c:647 __do_sys_write fs/read_write.c:659 [inline] __se_sys_write fs/read_write.c:656 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:656 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181 el0_svc+0x7c/0x1f0 arch/arm64/kernel/entry-common.c:608 el0t_64_sync_handler+0x84/0xe4 arch/arm64/kernel/entry-common.c:626 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584 ntfs3: loop5: ino=1d, "file1" failed to open parent directory r=400 to update ntfs3: loop5: ino=1d, "file1" failed to open parent directory r=400 to update