====================================================== WARNING: possible circular locking dependency detected 6.16.0-rc2-syzkaller-00378-gb67ec639010f #0 Not tainted ------------------------------------------------------ syz.3.59/6217 is trying to acquire lock: ffff888034ba6618 (sb_internal#3){.+.+}-{0:0}, at: ocfs2_setattr+0x11c3/0x2560 fs/ocfs2/file.c:1263 but task is already holding lock: ffff888054654da0 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x11b2/0x2560 fs/ocfs2/file.c:1262 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_alloc_sem){+.+.}-{4:4}: down_write+0x92/0x200 kernel/locking/rwsem.c:1577 ocfs2_try_remove_refcount_tree+0xa7/0x320 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0x1043/0x2a80 fs/ocfs2/xattr.c:3669 ocfs2_set_acl+0x46d/0x550 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x224/0x2d0 fs/ocfs2/acl.c:286 set_posix_acl+0x25f/0x320 fs/posix_acl.c:954 vfs_remove_acl+0x33f/0x650 fs/posix_acl.c:1241 ovl_do_remove_acl fs/overlayfs/overlayfs.h:355 [inline] ovl_workdir_create+0x4f5/0x8e0 fs/overlayfs/super.c:353 ovl_make_workdir fs/overlayfs/super.c:669 [inline] ovl_get_workdir fs/overlayfs/super.c:827 [inline] ovl_fill_super+0xe8f/0x67a0 fs/overlayfs/super.c:1406 vfs_get_super fs/super.c:1325 [inline] get_tree_nodev+0xdd/0x190 fs/super.c:1344 vfs_get_tree+0x8e/0x340 fs/super.c:1804 do_new_mount fs/namespace.c:3885 [inline] path_mount+0x1414/0x2020 fs/namespace.c:4209 do_mount fs/namespace.c:4222 [inline] __do_sys_mount fs/namespace.c:4433 [inline] __se_sys_mount fs/namespace.c:4410 [inline] __x64_sys_mount+0x28d/0x310 fs/namespace.c:4410 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&oi->ip_xattr_sem){++++}-{4:4}: down_read+0x9b/0x480 kernel/locking/rwsem.c:1524 ocfs2_init_acl+0x2fc/0x7d0 fs/ocfs2/acl.c:366 ocfs2_mknod+0xd5c/0x2540 fs/ocfs2/namei.c:410 ocfs2_mkdir+0x17c/0x490 fs/ocfs2/namei.c:656 vfs_mkdir+0x593/0x8c0 fs/namei.c:4375 do_mkdirat+0x304/0x3e0 fs/namei.c:4408 __do_sys_mkdirat fs/namei.c:4425 [inline] __se_sys_mkdirat fs/namei.c:4423 [inline] __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4423 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (jbd2_handle){++++}-{0:0}: start_this_handle+0x5ea/0x1410 fs/jbd2/transaction.c:444 jbd2__journal_start+0x394/0x6a0 fs/jbd2/transaction.c:501 jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:540 ocfs2_start_trans+0x3b9/0x970 fs/ocfs2/journal.c:374 ocfs2_mknod+0xc19/0x2540 fs/ocfs2/namei.c:361 ocfs2_mkdir+0x17c/0x490 fs/ocfs2/namei.c:656 vfs_mkdir+0x593/0x8c0 fs/namei.c:4375 do_mkdirat+0x304/0x3e0 fs/namei.c:4408 __do_sys_mkdirat fs/namei.c:4425 [inline] __se_sys_mkdirat fs/namei.c:4423 [inline] __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4423 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x9b/0x480 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3ae/0x970 fs/ocfs2/journal.c:372 ocfs2_mknod+0xc19/0x2540 fs/ocfs2/namei.c:361 ocfs2_mkdir+0x17c/0x490 fs/ocfs2/namei.c:656 vfs_mkdir+0x593/0x8c0 fs/namei.c:4375 do_mkdirat+0x304/0x3e0 fs/namei.c:4408 __do_sys_mkdirat fs/namei.c:4425 [inline] __se_sys_mkdirat fs/namei.c:4423 [inline] __x64_sys_mkdirat+0x83/0xb0 fs/namei.c:4423 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (sb_internal#3){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5240 lock_acquire kernel/locking/lockdep.c:5871 [inline] lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5828 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1795 [inline] sb_start_intwrite include/linux/fs.h:1978 [inline] ocfs2_start_trans+0x29d/0x970 fs/ocfs2/journal.c:370 ocfs2_setattr+0x11c3/0x2560 fs/ocfs2/file.c:1263 notify_change+0x6a9/0x1230 fs/attr.c:552 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline] ovl_workdir_create+0x68a/0x8e0 fs/overlayfs/super.c:363 ovl_make_workdir fs/overlayfs/super.c:669 [inline] ovl_get_workdir fs/overlayfs/super.c:827 [inline] ovl_fill_super+0xe8f/0x67a0 fs/overlayfs/super.c:1406 vfs_get_super fs/super.c:1325 [inline] get_tree_nodev+0xdd/0x190 fs/super.c:1344 vfs_get_tree+0x8e/0x340 fs/super.c:1804 do_new_mount fs/namespace.c:3885 [inline] path_mount+0x1414/0x2020 fs/namespace.c:4209 do_mount fs/namespace.c:4222 [inline] __do_sys_mount fs/namespace.c:4433 [inline] __se_sys_mount fs/namespace.c:4410 [inline] __x64_sys_mount+0x28d/0x310 fs/namespace.c:4410 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: sb_internal#3 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_alloc_sem); lock(&oi->ip_xattr_sem); lock(&oi->ip_alloc_sem); rlock(sb_internal#3); *** DEADLOCK *** 5 locks held by syz.3.59/6217: #0: ffff8880349a00e0 (&type->s_umount_key#61/1){+.+.}-{4:4}, at: alloc_super+0x235/0xbd0 fs/super.c:345 #1: ffff888034ba6428 (sb_writers#13){.+.+}-{0:0}, at: ovl_make_workdir fs/overlayfs/super.c:665 [inline] #1: ffff888034ba6428 (sb_writers#13){.+.+}-{0:0}, at: ovl_get_workdir fs/overlayfs/super.c:827 [inline] #1: ffff888034ba6428 (sb_writers#13){.+.+}-{0:0}, at: ovl_fill_super+0xe60/0x67a0 fs/overlayfs/super.c:1406 #2: ffff888054652640 (&sb->s_type->i_mutex_key#21/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:914 [inline] #2: ffff888054652640 (&sb->s_type->i_mutex_key#21/1){+.+.}-{4:4}, at: ovl_workdir_create+0x128/0x8e0 fs/overlayfs/super.c:302 #3: ffff888054655100 (&sb->s_type->i_mutex_key#23){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:869 [inline] #3: ffff888054655100 (&sb->s_type->i_mutex_key#23){+.+.}-{4:4}, at: ovl_workdir_create+0x618/0x8e0 fs/overlayfs/super.c:362 #4: ffff888054654da0 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0x11b2/0x2560 fs/ocfs2/file.c:1262 stack backtrace: CPU: 0 UID: 0 PID: 6217 Comm: syz.3.59 Not tainted 6.16.0-rc2-syzkaller-00378-gb67ec639010f #0 PREEMPT(full) Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_circular_bug+0x275/0x350 kernel/locking/lockdep.c:2046 check_noncircular+0x14c/0x170 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3168 [inline] check_prevs_add kernel/locking/lockdep.c:3287 [inline] validate_chain kernel/locking/lockdep.c:3911 [inline] __lock_acquire+0x126f/0x1c90 kernel/locking/lockdep.c:5240 lock_acquire kernel/locking/lockdep.c:5871 [inline] lock_acquire+0x179/0x350 kernel/locking/lockdep.c:5828 percpu_down_read_internal include/linux/percpu-rwsem.h:53 [inline] percpu_down_read_freezable include/linux/percpu-rwsem.h:83 [inline] __sb_start_write include/linux/fs.h:1795 [inline] sb_start_intwrite include/linux/fs.h:1978 [inline] ocfs2_start_trans+0x29d/0x970 fs/ocfs2/journal.c:370 ocfs2_setattr+0x11c3/0x2560 fs/ocfs2/file.c:1263 notify_change+0x6a9/0x1230 fs/attr.c:552 ovl_do_notify_change fs/overlayfs/overlayfs.h:203 [inline] ovl_workdir_create+0x68a/0x8e0 fs/overlayfs/super.c:363 ovl_make_workdir fs/overlayfs/super.c:669 [inline] ovl_get_workdir fs/overlayfs/super.c:827 [inline] ovl_fill_super+0xe8f/0x67a0 fs/overlayfs/super.c:1406 vfs_get_super fs/super.c:1325 [inline] get_tree_nodev+0xdd/0x190 fs/super.c:1344 vfs_get_tree+0x8e/0x340 fs/super.c:1804 do_new_mount fs/namespace.c:3885 [inline] path_mount+0x1414/0x2020 fs/namespace.c:4209 do_mount fs/namespace.c:4222 [inline] __do_sys_mount fs/namespace.c:4433 [inline] __se_sys_mount fs/namespace.c:4410 [inline] __x64_sys_mount+0x28d/0x310 fs/namespace.c:4410 do_syscall_x64 arch/x86/entry/syscall_64.c:63 [inline] do_syscall_64+0xcd/0x4c0 arch/x86/entry/syscall_64.c:94 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7efda098e929 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007efda1710038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007efda0bb6080 RCX: 00007efda098e929 RDX: 00002000000001c0 RSI: 0000200000000180 RDI: 0000000000000000 RBP: 00007efda0a10b39 R08: 0000200000000300 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007efda0bb6080 R15: 00007ffed61f30a8 overlayfs: upper fs does not support tmpfile. (syz.3.59,6217,0):ocfs2_check_dir_entry:321 ERROR: bad entry in directory #72: rec_len % 4 != 0 - offset=16, inode=66, rec_len=491, name_len=2 (syz.3.59,6217,0):ocfs2_prepare_dir_for_insert:4294 ERROR: status = -2 (syz.3.59,6217,0):__ocfs2_prepare_orphan_dir:2180 ERROR: status = -2 (syz.3.59,6217,0):ocfs2_prepare_orphan_dir:2224 ERROR: status = -2 (syz.3.59,6217,0):ocfs2_prepare_orphan_dir:2240 ERROR: status = -2 (syz.3.59,6217,0):ocfs2_unlink:964 ERROR: status = -2 overlayfs: cleanup of 'work/#3' failed (-2) overlayfs: upper fs does not support RENAME_WHITEOUT. overlayfs: upper fs missing required features. ocfs2: Unmounting device (7,3) on (node local)