====================================================== WARNING: possible circular locking dependency detected syzkaller #0 Not tainted ------------------------------------------------------ syz.2.122/4792 is trying to acquire lock: ffff8880621bb488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] ffff8880621bb488 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}, at: ocfs2_reserve_suballoc_bits+0x161/0x4350 fs/ocfs2/suballoc.c:782 but task is already holding lock: ffff888075946a20 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x18a/0x300 fs/ocfs2/aops.c:1903 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&oi->ip_alloc_sem){++++}-{3:3}: down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_read_virt_blocks+0x23f/0x8a0 fs/ocfs2/extent_map.c:984 ocfs2_read_dir_block+0xd3/0x4d0 fs/ocfs2/dir.c:508 ocfs2_dir_foreach_blk_el fs/ocfs2/dir.c:1842 [inline] ocfs2_dir_foreach_blk+0x26e/0x1900 fs/ocfs2/dir.c:1928 ocfs2_dir_foreach fs/ocfs2/dir.c:1938 [inline] ocfs2_empty_dir+0x1a1/0x6c0 fs/ocfs2/dir.c:2156 ocfs2_rename+0x204e/0x3690 fs/ocfs2/namei.c:1499 vfs_rename+0xbbf/0x10d0 fs/namei.c:4840 do_renameat2+0xa83/0xf70 fs/namei.c:4993 __do_sys_rename fs/namei.c:5039 [inline] __se_sys_rename fs/namei.c:5037 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5037 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #3 (jbd2_handle){++++}-{0:0}: start_this_handle+0x1338/0x15a0 fs/jbd2/transaction.c:464 jbd2__journal_start+0x2b7/0x5a0 fs/jbd2/transaction.c:521 jbd2_journal_start+0x26/0x30 fs/jbd2/transaction.c:560 ocfs2_start_trans+0x374/0x6c0 fs/ocfs2/journal.c:376 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline] ocfs2_reserve_local_alloc_bits+0xaeb/0x24c0 fs/ocfs2/localalloc.c:668 ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162 ocfs2_mknod+0xddd/0x22b0 fs/ocfs2/namei.c:354 ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4073 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4098 __do_sys_mkdirat fs/namei.c:4113 [inline] __se_sys_mkdirat fs/namei.c:4111 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 (&journal->j_trans_barrier){.+.+}-{3:3}: down_read+0x44/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_start_trans+0x368/0x6c0 fs/ocfs2/journal.c:374 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline] ocfs2_reserve_local_alloc_bits+0xaeb/0x24c0 fs/ocfs2/localalloc.c:668 ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162 ocfs2_mknod+0xddd/0x22b0 fs/ocfs2/namei.c:354 ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4073 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4098 __do_sys_mkdirat fs/namei.c:4113 [inline] __se_sys_mkdirat fs/namei.c:4111 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (sb_internal#4){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1811 [inline] sb_start_intwrite include/linux/fs.h:1928 [inline] ocfs2_start_trans+0x269/0x6c0 fs/ocfs2/journal.c:372 ocfs2_local_alloc_slide_window fs/ocfs2/localalloc.c:1258 [inline] ocfs2_reserve_local_alloc_bits+0xaeb/0x24c0 fs/ocfs2/localalloc.c:668 ocfs2_reserve_clusters_with_limit+0x1bb/0xba0 fs/ocfs2/suballoc.c:1162 ocfs2_mknod+0xddd/0x22b0 fs/ocfs2/namei.c:354 ocfs2_mkdir+0x192/0x410 fs/ocfs2/namei.c:657 vfs_mkdir+0x387/0x570 fs/namei.c:4073 do_mkdirat+0x1d7/0x5a0 fs/namei.c:4098 __do_sys_mkdirat fs/namei.c:4113 [inline] __se_sys_mkdirat fs/namei.c:4111 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4111 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:787 [inline] ocfs2_reserve_suballoc_bits+0x161/0x4350 fs/ocfs2/suballoc.c:782 ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1128 [inline] ocfs2_reserve_clusters_with_limit+0x2f8/0xba0 fs/ocfs2/suballoc.c:1173 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669 ocfs2_write_begin_nolock+0x2216/0x4180 fs/ocfs2/aops.c:1741 ocfs2_write_begin+0x1ab/0x300 fs/ocfs2/aops.c:1905 generic_perform_write+0x2aa/0x530 mm/filemap.c:3785 __generic_file_write_iter+0x383/0x4e0 mm/filemap.c:3880 ocfs2_file_write_iter+0x1578/0x1cf0 fs/ocfs2/file.c:2472 do_iter_readv_writev+0x497/0x600 fs/read_write.c:-1 do_iter_write+0x205/0x7b0 fs/read_write.c:855 vfs_writev fs/read_write.c:928 [inline] do_pwritev+0x204/0x340 fs/read_write.c:1025 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5 --> jbd2_handle --> &oi->ip_alloc_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&oi->ip_alloc_sem); lock(jbd2_handle); lock(&oi->ip_alloc_sem); lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5); *** DEADLOCK *** 3 locks held by syz.2.122/4792: #0: ffff88807b32a460 (sb_writers#16){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:927 [inline] #0: ffff88807b32a460 (sb_writers#16){.+.+}-{0:0}, at: do_pwritev+0x1f2/0x340 fs/read_write.c:1025 #1: ffff888075946d88 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #1: ffff888075946d88 (&sb->s_type->i_mutex_key#23){+.+.}-{3:3}, at: ocfs2_file_write_iter+0x401/0x1cf0 fs/ocfs2/file.c:2402 #2: ffff888075946a20 (&oi->ip_alloc_sem){++++}-{3:3}, at: ocfs2_write_begin+0x18a/0x300 fs/ocfs2/aops.c:1903 stack backtrace: CPU: 1 PID: 4792 Comm: syz.2.122 Not tainted syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/02/2025 Call Trace: dump_stack_lvl+0x168/0x230 lib/dump_stack.c:106 check_noncircular+0x274/0x310 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain kernel/locking/lockdep.c:3788 [inline] __lock_acquire+0x2c33/0x7c60 kernel/locking/lockdep.c:5012 lock_acquire+0x197/0x3f0 kernel/locking/lockdep.c:5623 down_write+0x38/0x60 kernel/locking/rwsem.c:1551 inode_lock include/linux/fs.h:787 [inline] ocfs2_reserve_suballoc_bits+0x161/0x4350 fs/ocfs2/suballoc.c:782 ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1128 [inline] ocfs2_reserve_clusters_with_limit+0x2f8/0xba0 fs/ocfs2/suballoc.c:1173 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline] ocfs2_lock_allocators+0x2f7/0x5b0 fs/ocfs2/suballoc.c:2669 ocfs2_write_begin_nolock+0x2216/0x4180 fs/ocfs2/aops.c:1741 ocfs2_write_begin+0x1ab/0x300 fs/ocfs2/aops.c:1905 generic_perform_write+0x2aa/0x530 mm/filemap.c:3785 __generic_file_write_iter+0x383/0x4e0 mm/filemap.c:3880 ocfs2_file_write_iter+0x1578/0x1cf0 fs/ocfs2/file.c:2472 do_iter_readv_writev+0x497/0x600 fs/read_write.c:-1 do_iter_write+0x205/0x7b0 fs/read_write.c:855 vfs_writev fs/read_write.c:928 [inline] do_pwritev+0x204/0x340 fs/read_write.c:1025 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x4c/0xa0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f73ebc0ffc9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f73e9e77038 EFLAGS: 00000246 ORIG_RAX: 0000000000000148 RAX: ffffffffffffffda RBX: 00007f73ebe66fa0 RCX: 00007f73ebc0ffc9 RDX: 0000000000000001 RSI: 0000200000000680 RDI: 0000000000000004 RBP: 00007f73ebc92f91 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000006000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007f73ebe67038 R14: 00007f73ebe66fa0 R15: 00007ffce3673548 syz.2.122 (4792) used greatest stack depth: 21040 bytes left