======================================================
WARNING: possible circular locking dependency detected
6.13.0-rc7-syzkaller-00149-g9bffa1ad25b8 #0 Not tainted
------------------------------------------------------
kworker/3:4/6088 is trying to acquire lock:
ffff888023e13b90 (&q->q_usage_counter(queue)#51){++++}-{0:0}, at: blk_mq_alloc_request+0x59b/0x950 block/blk-mq.c:652

but task is already holding lock:
ffff888023e141a8 (&q->limits_lock){+.+.}-{4:4}, at: queue_limits_start_update include/linux/blkdev.h:947 [inline]
ffff888023e141a8 (&q->limits_lock){+.+.}-{4:4}, at: sd_revalidate_disk.isra.0+0x52c/0xa8d0 drivers/scsi/sd.c:3727

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&q->limits_lock){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735
       queue_limits_start_update include/linux/blkdev.h:947 [inline]
       loop_reconfigure_limits+0x407/0x8c0 drivers/block/loop.c:998
       loop_set_block_size drivers/block/loop.c:1473 [inline]
       lo_simple_ioctl drivers/block/loop.c:1496 [inline]
       lo_ioctl+0x8f4/0x18a0 drivers/block/loop.c:1559
       lo_compat_ioctl+0xb9/0x170 drivers/block/loop.c:1692
       compat_blkdev_ioctl+0x2f7/0x750 block/ioctl.c:749
       __do_compat_sys_ioctl+0x1cb/0x2c0 fs/ioctl.c:1004
       do_syscall_32_irqs_on arch/x86/entry/common.c:165 [inline]
       __do_fast_syscall_32+0x73/0x120 arch/x86/entry/common.c:386
       do_fast_syscall_32+0x32/0x80 arch/x86/entry/common.c:411
       entry_SYSENTER_compat_after_hwframe+0x84/0x8e

-> #4 (&q->q_usage_counter(io)#23){++++}-{0:0}:
       bio_queue_enter block/blk.h:75 [inline]
       blk_mq_submit_bio+0x1fb6/0x24c0 block/blk-mq.c:3090
       __submit_bio+0x384/0x540 block/blk-core.c:629
       __submit_bio_noacct_mq block/blk-core.c:710 [inline]
       submit_bio_noacct_nocheck+0x698/0xd70 block/blk-core.c:739
       submit_bio_noacct+0x93a/0x1e20 block/blk-core.c:868
       mpage_bio_submit_read fs/mpage.c:75 [inline]
       mpage_readahead+0x41d/0x590 fs/mpage.c:377
       read_pages+0x1a8/0xdc0 mm/readahead.c:160
       page_cache_ra_unbounded+0x3dc/0x750 mm/readahead.c:295
       do_page_cache_ra mm/readahead.c:325 [inline]
       force_page_cache_ra+0x24b/0x340 mm/readahead.c:354
       page_cache_sync_ra+0x110/0x9c0 mm/readahead.c:566
       page_cache_sync_readahead include/linux/pagemap.h:1397 [inline]
       filemap_get_pages+0xd7b/0x1be0 mm/filemap.c:2537
       filemap_read+0x3ca/0xd70 mm/filemap.c:2637
       blkdev_read_iter+0x187/0x480 block/fops.c:770
       new_sync_read fs/read_write.c:484 [inline]
       vfs_read+0x87f/0xbe0 fs/read_write.c:565
       ksys_read+0x12b/0x250 fs/read_write.c:708
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (mapping.invalidate_lock#2){++++}-{4:4}:
       down_read+0x9a/0x330 kernel/locking/rwsem.c:1524
       filemap_invalidate_lock_shared include/linux/fs.h:873 [inline]
       page_cache_ra_unbounded+0x173/0x750 mm/readahead.c:226
       do_page_cache_ra mm/readahead.c:325 [inline]
       page_cache_ra_order+0x8f2/0xc80 mm/readahead.c:524
       do_sync_mmap_readahead mm/filemap.c:3194 [inline]
       filemap_fault+0x14a5/0x2820 mm/filemap.c:3335
       __do_fault+0x10a/0x490 mm/memory.c:4907
       do_read_fault mm/memory.c:5322 [inline]
       do_fault mm/memory.c:5456 [inline]
       do_pte_missing+0xebd/0x3e00 mm/memory.c:3979
       handle_pte_fault mm/memory.c:5801 [inline]
       __handle_mm_fault+0x103c/0x2a40 mm/memory.c:5944
       handle_mm_fault+0x3fa/0xaa0 mm/memory.c:6112
       faultin_page mm/gup.c:1196 [inline]
       __get_user_pages+0x8d9/0x3b50 mm/gup.c:1494
       __get_user_pages_locked mm/gup.c:1760 [inline]
       get_user_pages_unlocked+0x1c2/0x780 mm/gup.c:2737
       hva_to_pfn_slow virt/kvm/kvm_main.c:2820 [inline]
       hva_to_pfn+0x8be/0xc20 virt/kvm/kvm_main.c:2916
       kvm_follow_pfn virt/kvm/kvm_main.c:2963 [inline]
       kvm_follow_pfn+0x29f/0x3f0 virt/kvm/kvm_main.c:2947
       __kvm_faultin_pfn+0x11c/0x1a0 virt/kvm/kvm_main.c:2984
       __kvm_mmu_faultin_pfn arch/x86/kvm/mmu/mmu.c:4342 [inline]
       kvm_mmu_faultin_pfn+0x469/0x1f30 arch/x86/kvm/mmu/mmu.c:4462
       kvm_tdp_mmu_page_fault arch/x86/kvm/mmu/mmu.c:4630 [inline]
       kvm_tdp_page_fault+0x182/0x3d0 arch/x86/kvm/mmu/mmu.c:4666
       kvm_mmu_do_page_fault+0x58d/0x690 arch/x86/kvm/mmu/mmu_internal.h:325
       kvm_mmu_page_fault+0x20f/0x1bb0 arch/x86/kvm/mmu/mmu.c:6078
       handle_ept_violation+0x25a/0x640 arch/x86/kvm/vmx/vmx.c:5832
       __vmx_handle_exit arch/x86/kvm/vmx/vmx.c:6620 [inline]
       vmx_handle_exit+0x733/0x1f70 arch/x86/kvm/vmx/vmx.c:6637
       vcpu_enter_guest arch/x86/kvm/x86.c:11081 [inline]
       vcpu_run+0x2aaf/0x4c00 arch/x86/kvm/x86.c:11242
       kvm_arch_vcpu_ioctl_run+0x44a/0x1740 arch/x86/kvm/x86.c:11560
       kvm_vcpu_ioctl+0x6ce/0x1520 virt/kvm/kvm_main.c:4340
       kvm_vcpu_compat_ioctl+0x210/0x3f0 virt/kvm/kvm_main.c:4555
       __do_compat_sys_ioctl+0x1cb/0x2c0 fs/ioctl.c:1004
       do_syscall_32_irqs_on arch/x86/entry/common.c:165 [inline]
       __do_fast_syscall_32+0x73/0x120 arch/x86/entry/common.c:386
       do_fast_syscall_32+0x32/0x80 arch/x86/entry/common.c:411
       entry_SYSENTER_compat_after_hwframe+0x84/0x8e

-> #2 (&mm->mmap_lock){++++}-{4:4}:
       __might_fault mm/memory.c:6751 [inline]
       __might_fault+0x11b/0x190 mm/memory.c:6744
       _inline_copy_from_user include/linux/uaccess.h:162 [inline]
       _copy_from_user+0x29/0xd0 lib/usercopy.c:18
       copy_from_user include/linux/uaccess.h:212 [inline]
       compat_blk_trace_setup+0xc9/0x200 kernel/trace/blktrace.c:664
       blk_trace_ioctl+0x24a/0x290 kernel/trace/blktrace.c:745
       compat_blkdev_ioctl+0x13c/0x750 block/ioctl.c:742
       __do_compat_sys_ioctl+0x1cb/0x2c0 fs/ioctl.c:1004
       do_syscall_32_irqs_on arch/x86/entry/common.c:165 [inline]
       __do_fast_syscall_32+0x73/0x120 arch/x86/entry/common.c:386
       do_fast_syscall_32+0x32/0x80 arch/x86/entry/common.c:411
       entry_SYSENTER_compat_after_hwframe+0x84/0x8e

-> #1 (&q->debugfs_mutex){+.+.}-{4:4}:
       __mutex_lock_common kernel/locking/mutex.c:585 [inline]
       __mutex_lock+0x19b/0xa60 kernel/locking/mutex.c:735
       blk_mq_init_sched+0x42b/0x640 block/blk-mq-sched.c:473
       elevator_init_mq+0x2cd/0x420 block/elevator.c:610
       add_disk_fwnode+0x113/0x1300 block/genhd.c:413
       sd_probe+0xa66/0xfa0 drivers/scsi/sd.c:4024
       call_driver_probe drivers/base/dd.c:579 [inline]
       really_probe+0x23e/0xa90 drivers/base/dd.c:658
       __driver_probe_device+0x1de/0x440 drivers/base/dd.c:800
       driver_probe_device+0x4c/0x1b0 drivers/base/dd.c:830
       __device_attach_driver+0x1df/0x310 drivers/base/dd.c:958
       bus_for_each_drv+0x157/0x1e0 drivers/base/bus.c:459
       __device_attach_async_helper+0x1d3/0x290 drivers/base/dd.c:987
       async_run_entry_fn+0x9c/0x530 kernel/async.c:129
       process_one_work+0x958/0x1b30 kernel/workqueue.c:3236
       process_scheduled_works kernel/workqueue.c:3317 [inline]
       worker_thread+0x6c8/0xf00 kernel/workqueue.c:3398
       kthread+0x2c1/0x3a0 kernel/kthread.c:389
       ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

-> #0 (&q->q_usage_counter(queue)#51){++++}-{0:0}:
       check_prev_add kernel/locking/lockdep.c:3161 [inline]
       check_prevs_add kernel/locking/lockdep.c:3280 [inline]
       validate_chain kernel/locking/lockdep.c:3904 [inline]
       __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
       lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
       blk_queue_enter+0x50f/0x640 block/blk-core.c:328
       blk_mq_alloc_request+0x59b/0x950 block/blk-mq.c:652
       scsi_alloc_request drivers/scsi/scsi_lib.c:1225 [inline]
       scsi_execute_cmd+0x20a/0xf30 drivers/scsi/scsi_lib.c:307
       read_capacity_16+0x21a/0xe20 drivers/scsi/sd.c:2655
       sd_read_capacity drivers/scsi/sd.c:2824 [inline]
       sd_revalidate_disk.isra.0+0x1a06/0xa8d0 drivers/scsi/sd.c:3734
       scsi_rescan_device+0x243/0x340 drivers/scsi/scsi_scan.c:1715
       ata_scsi_dev_rescan+0x1cb/0x470 drivers/ata/libata-scsi.c:4902
       process_one_work+0x958/0x1b30 kernel/workqueue.c:3236
       process_scheduled_works kernel/workqueue.c:3317 [inline]
       worker_thread+0x6c8/0xf00 kernel/workqueue.c:3398
       kthread+0x2c1/0x3a0 kernel/kthread.c:389
       ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147
       ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

other info that might help us debug this:

Chain exists of:
  &q->q_usage_counter(queue)#51 --> &q->q_usage_counter(io)#23 --> &q->limits_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&q->limits_lock);
                               lock(&q->q_usage_counter(io)#23);
                               lock(&q->limits_lock);
  rlock(&q->q_usage_counter(queue)#51);

 *** DEADLOCK ***

5 locks held by kworker/3:4/6088:
 #0: ffff88801ac88948 ((wq_completion)events){+.+.}-{0:0}, at: process_one_work+0x12cd/0x1b30 kernel/workqueue.c:3211
 #1: ffffc90003f0fd80 ((work_completion)(&(&ap->scsi_rescan_task)->work)){+.+.}-{0:0}, at: process_one_work+0x8bb/0x1b30 kernel/workqueue.c:3212
 #2: ffff888024ce4358 (&ap->scsi_scan_mutex){+.+.}-{4:4}, at: ata_scsi_dev_rescan+0x3e/0x470 drivers/ata/libata-scsi.c:4874
 #3: ffff88802152a378 (&dev->mutex){....}-{4:4}, at: device_lock include/linux/device.h:1014 [inline]
 #3: ffff88802152a378 (&dev->mutex){....}-{4:4}, at: scsi_rescan_device+0x27/0x340 drivers/scsi/scsi_scan.c:1691
 #4: ffff888023e141a8 (&q->limits_lock){+.+.}-{4:4}, at: queue_limits_start_update include/linux/blkdev.h:947 [inline]
 #4: ffff888023e141a8 (&q->limits_lock){+.+.}-{4:4}, at: sd_revalidate_disk.isra.0+0x52c/0xa8d0 drivers/scsi/sd.c:3727

stack backtrace:
CPU: 3 UID: 0 PID: 6088 Comm: kworker/3:4 Not tainted 6.13.0-rc7-syzkaller-00149-g9bffa1ad25b8 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014
Workqueue: events ata_scsi_dev_rescan
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120
 print_circular_bug+0x41c/0x610 kernel/locking/lockdep.c:2074
 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2206
 check_prev_add kernel/locking/lockdep.c:3161 [inline]
 check_prevs_add kernel/locking/lockdep.c:3280 [inline]
 validate_chain kernel/locking/lockdep.c:3904 [inline]
 __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5226
 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5849
 blk_queue_enter+0x50f/0x640 block/blk-core.c:328
 blk_mq_alloc_request+0x59b/0x950 block/blk-mq.c:652
 scsi_alloc_request drivers/scsi/scsi_lib.c:1225 [inline]
 scsi_execute_cmd+0x20a/0xf30 drivers/scsi/scsi_lib.c:307
 read_capacity_16+0x21a/0xe20 drivers/scsi/sd.c:2655
 sd_read_capacity drivers/scsi/sd.c:2824 [inline]
 sd_revalidate_disk.isra.0+0x1a06/0xa8d0 drivers/scsi/sd.c:3734
 scsi_rescan_device+0x243/0x340 drivers/scsi/scsi_scan.c:1715
 ata_scsi_dev_rescan+0x1cb/0x470 drivers/ata/libata-scsi.c:4902
 process_one_work+0x958/0x1b30 kernel/workqueue.c:3236
 process_scheduled_works kernel/workqueue.c:3317 [inline]
 worker_thread+0x6c8/0xf00 kernel/workqueue.c:3398
 kthread+0x2c1/0x3a0 kernel/kthread.c:389
 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147
 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244
 </TASK>