====================================================== WARNING: possible circular locking dependency detected 5.15.169-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.889/7846 is trying to acquire lock: ffff888028e68170 (&journal->j_barrier){+.+.}-{3:3}, at: jbd2_journal_lock_updates+0x2aa/0x370 fs/jbd2/transaction.c:905 but task is already holding lock: ffff888029a74650 (sb_internal){++++}-{0:0}, at: sb_wait_write fs/super.c:1626 [inline] ffff888029a74650 (sb_internal){++++}-{0:0}, at: freeze_super+0x23c/0x420 fs/super.c:1736 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #5 (sb_internal){++++}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_write+0x52/0x2d0 kernel/locking/percpu-rwsem.c:217 sb_wait_write fs/super.c:1626 [inline] freeze_super+0x23c/0x420 fs/super.c:1736 freeze_bdev+0x163/0x230 block/bdev.c:251 ext4_shutdown fs/ext4/ioctl.c:581 [inline] __ext4_ioctl fs/ext4/ioctl.c:1248 [inline] ext4_ioctl+0x2d04/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #4 (sb_pagefaults){++++}-{0:0}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 percpu_down_read+0x46/0x1b0 include/linux/percpu-rwsem.h:51 __sb_start_write include/linux/fs.h:1813 [inline] sb_start_pagefault include/linux/fs.h:1912 [inline] ext4_page_mkwrite+0x1b5/0x1290 fs/ext4/inode.c:6127 do_page_mkwrite+0x1a9/0x440 mm/memory.c:2909 wp_page_shared+0x179/0x690 mm/memory.c:3246 handle_pte_fault mm/memory.c:4655 [inline] __handle_mm_fault mm/memory.c:4772 [inline] handle_mm_fault+0x2a3d/0x5960 mm/memory.c:4870 do_user_addr_fault arch/x86/mm/fault.c:1357 [inline] handle_page_fault arch/x86/mm/fault.c:1445 [inline] exc_page_fault+0x271/0x700 arch/x86/mm/fault.c:1501 asm_exc_page_fault+0x22/0x30 arch/x86/include/asm/idtentry.h:606 -> #3 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 internal_get_user_pages_fast+0x212/0x2810 mm/gup.c:2895 iov_iter_get_pages+0x25a/0x570 lib/iov_iter.c:1544 __bio_iov_iter_get_pages block/bio.c:1136 [inline] bio_iov_iter_get_pages+0x477/0x18e0 block/bio.c:1195 iomap_dio_bio_iter+0xab9/0x1540 fs/iomap/direct-io.c:321 __iomap_dio_rw+0xf9f/0x1f40 fs/iomap/direct-io.c:586 iomap_dio_rw+0x38/0x80 fs/iomap/direct-io.c:672 ext4_dio_write_iter fs/ext4/file.c:540 [inline] ext4_file_write_iter+0x154e/0x1940 fs/ext4/file.c:660 call_write_iter include/linux/fs.h:2174 [inline] new_sync_write fs/read_write.c:507 [inline] vfs_write+0xacd/0xe50 fs/read_write.c:594 ksys_write+0x1a2/0x2c0 fs/read_write.c:647 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #2 ( &sb->s_type->i_mutex_key#9){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 inode_lock_shared include/linux/fs.h:799 [inline] ext4_bmap+0x4b/0x410 fs/ext4/inode.c:3163 bmap+0xa1/0xd0 fs/inode.c:1795 jbd2_journal_bmap fs/jbd2/journal.c:981 [inline] __jbd2_journal_erase fs/jbd2/journal.c:1796 [inline] jbd2_journal_flush+0x7a2/0xc90 fs/jbd2/journal.c:2502 ext4_ioctl_checkpoint fs/ext4/ioctl.c:849 [inline] __ext4_ioctl fs/ext4/ioctl.c:1267 [inline] ext4_ioctl+0x3249/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #1 (&journal->j_checkpoint_mutex){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 mutex_lock_io_nested+0x45/0x60 kernel/locking/mutex.c:777 jbd2_journal_flush+0x290/0xc90 fs/jbd2/journal.c:2474 ext4_ioctl_checkpoint fs/ext4/ioctl.c:849 [inline] __ext4_ioctl fs/ext4/ioctl.c:1267 [inline] ext4_ioctl+0x3249/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&journal->j_barrier){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 jbd2_journal_lock_updates+0x2aa/0x370 fs/jbd2/transaction.c:905 ext4_freeze+0xa4/0x200 fs/ext4/super.c:5695 freeze_super+0x282/0x420 fs/super.c:1739 freeze_bdev+0x163/0x230 block/bdev.c:251 ext4_shutdown fs/ext4/ioctl.c:581 [inline] __ext4_ioctl fs/ext4/ioctl.c:1248 [inline] ext4_ioctl+0x2d04/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Chain exists of: &journal->j_barrier --> sb_pagefaults --> sb_internal Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(sb_internal); lock(sb_pagefaults); lock(sb_internal); lock( &journal->j_barrier); *** DEADLOCK *** 5 locks held by syz.4.889/7846: #0: ffff8881408ee448 (&bdev->bd_fsfreeze_mutex){+.+.}-{3:3}, at: freeze_bdev+0x2d/0x230 block/bdev.c:241 #1: ffff888029a74460 (sb_writers#5){++++}-{0:0}, at: sb_wait_write fs/super.c:1626 [inline] #1: ffff888029a74460 (sb_writers#5){++++}-{0:0}, at: freeze_super+0x134/0x420 fs/super.c:1717 #2: ffff888029a740e0 (&type->s_umount_key #32){++++}-{3:3}, at: freeze_super+0x13c/0x420 fs/super.c:1718 #3: ffff888029a74558 (sb_pagefaults ){++++}-{0:0} , at: sb_wait_write fs/super.c:1626 [inline] , at: freeze_super+0x163/0x420 fs/super.c:1722 #4: ffff888029a74650 (sb_internal){++++}-{0:0}, at: sb_wait_write fs/super.c:1626 [inline] (sb_internal){++++}-{0:0}, at: freeze_super+0x23c/0x420 fs/super.c:1736 stack backtrace: CPU: 1 PID: 7846 Comm: syz.4.889 Not tainted 5.15.169-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 jbd2_journal_lock_updates+0x2aa/0x370 fs/jbd2/transaction.c:905 ext4_freeze+0xa4/0x200 fs/ext4/super.c:5695 freeze_super+0x282/0x420 fs/super.c:1739 freeze_bdev+0x163/0x230 block/bdev.c:251 ext4_shutdown fs/ext4/ioctl.c:581 [inline] __ext4_ioctl fs/ext4/ioctl.c:1248 [inline] ext4_ioctl+0x2d04/0x5b80 fs/ext4/ioctl.c:1276 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:874 [inline] __se_sys_ioctl+0xf1/0x160 fs/ioctl.c:860 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7f824dc9cff9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f824c115038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f824de54f80 RCX: 00007f824dc9cff9 RDX: 0000000020001ec0 RSI: 000000008004587d RDI: 0000000000000007 RBP: 00007f824dd0f296 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f824de54f80 R15: 00007fff123604c8