====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/23912 is trying to acquire lock: 00000000b37d201a (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 but task is already holding lock: 0000000050a1cad2 (&sbi->alloc_mutex){+.+.}, at: hfsplus_block_allocate+0xe0/0xa60 fs/hfsplus/bitmap.c:35 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&sbi->alloc_mutex){+.+.}: hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x228/0x520 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0xd96/0x1040 fs/hfsplus/extents.c:591 hfsplus_setattr+0x1e7/0x310 fs/hfsplus/inode.c:263 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 handle_truncate fs/namei.c:3009 [inline] do_last fs/namei.c:3427 [inline] path_openat+0x2308/0x2df0 fs/namei.c:3537 do_filp_open+0x18c/0x3f0 fs/namei.c:3567 do_sys_open+0x3b3/0x520 fs/open.c:1085 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&HFSPLUS_I(inode)->extents_lock){+.+.}: __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 block_read_full_page+0x288/0xd10 fs/buffer.c:2259 do_read_cache_page+0x533/0x1170 mm/filemap.c:2828 read_mapping_page include/linux/pagemap.h:402 [inline] hfsplus_block_allocate+0x197/0xa60 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x436/0xf40 fs/hfsplus/extents.c:468 hfsplus_get_block+0x196/0x960 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:717 [inline] do_direct_IO fs/direct-io.c:1003 [inline] do_blockdev_direct_IO fs/direct-io.c:1333 [inline] __blockdev_direct_IO+0x424b/0xef40 fs/direct-io.c:1419 blockdev_direct_IO include/linux/fs.h:3059 [inline] hfsplus_direct_IO+0x10a/0x2c0 fs/hfsplus/inode.c:134 generic_file_direct_write+0x208/0x4a0 mm/filemap.c:3073 __generic_file_write_iter+0x2d0/0x610 mm/filemap.c:3252 generic_file_write_iter+0x3f8/0x730 mm/filemap.c:3323 call_write_iter include/linux/fs.h:1821 [inline] new_sync_write fs/read_write.c:474 [inline] __vfs_write+0x51b/0x770 fs/read_write.c:487 vfs_write+0x1f3/0x540 fs/read_write.c:549 ksys_write+0x12b/0x2a0 fs/read_write.c:599 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); *** DEADLOCK *** 5 locks held by syz-executor.2/23912: #0: 000000002a828c62 (&f->f_pos_lock){+.+.}, at: __fdget_pos+0x26f/0x310 fs/file.c:767 #1: 0000000072ca50af (sb_writers#24){.+.+}, at: file_start_write include/linux/fs.h:2779 [inline] #1: 0000000072ca50af (sb_writers#24){.+.+}, at: vfs_write+0x463/0x540 fs/read_write.c:548 #2: 0000000092b7768f (&sb->s_type->i_mutex_key#30){+.+.}, at: inode_lock include/linux/fs.h:748 [inline] #2: 0000000092b7768f (&sb->s_type->i_mutex_key#30){+.+.}, at: generic_file_write_iter+0x99/0x730 mm/filemap.c:3320 #3: 00000000e56aa98a (&hip->extents_lock){+.+.}, at: hfsplus_file_extend+0x1bb/0xf40 fs/hfsplus/extents.c:457 #4: 0000000050a1cad2 (&sbi->alloc_mutex){+.+.}, at: hfsplus_block_allocate+0xe0/0xa60 fs/hfsplus/bitmap.c:35 stack backtrace: CPU: 1 PID: 23912 Comm: syz-executor.2 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/21/2023 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 block_read_full_page+0x288/0xd10 fs/buffer.c:2259 do_read_cache_page+0x533/0x1170 mm/filemap.c:2828 XFS (loop0): Mounting V4 Filesystem read_mapping_page include/linux/pagemap.h:402 [inline] hfsplus_block_allocate+0x197/0xa60 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x436/0xf40 fs/hfsplus/extents.c:468 XFS (loop0): Ending clean mount hfsplus_get_block+0x196/0x960 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:717 [inline] do_direct_IO fs/direct-io.c:1003 [inline] do_blockdev_direct_IO fs/direct-io.c:1333 [inline] __blockdev_direct_IO+0x424b/0xef40 fs/direct-io.c:1419 blockdev_direct_IO include/linux/fs.h:3059 [inline] hfsplus_direct_IO+0x10a/0x2c0 fs/hfsplus/inode.c:134 generic_file_direct_write+0x208/0x4a0 mm/filemap.c:3073 __generic_file_write_iter+0x2d0/0x610 mm/filemap.c:3252 generic_file_write_iter+0x3f8/0x730 mm/filemap.c:3323 call_write_iter include/linux/fs.h:1821 [inline] new_sync_write fs/read_write.c:474 [inline] __vfs_write+0x51b/0x770 fs/read_write.c:487 vfs_write+0x1f3/0x540 fs/read_write.c:549 ksys_write+0x12b/0x2a0 fs/read_write.c:599 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 overlayfs: missing 'lowerdir' entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7ff16a9ac0f9 overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ff168f1e168 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007ff16aacbf80 RCX: 00007ff16a9ac0f9 RDX: 000000000000f000 RSI: 0000000020000200 RDI: 0000000000000005 RBP: 00007ff16aa07ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffd11a115df R14: 00007ff168f1e300 R15: 0000000000022000 XFS (loop0): Unmounting Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop3): Unmounting Filesystem XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount overlayfs: missing 'lowerdir' overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop0): Unmounting Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop3): Unmounting Filesystem XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount overlayfs: missing 'lowerdir' overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop0): Unmounting Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop3): Unmounting Filesystem EXT4-fs (loop2): VFS: Can't find ext4 filesystem XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount overlayfs: missing 'lowerdir' overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop0): Unmounting Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop3): Unmounting Filesystem IPVS: ftp: loaded support on port[0] = 21 audit: type=1800 audit(1676393564.081:19188): pid=24210 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=15393 res=0 IPVS: ftp: loaded support on port[0] = 21 XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount overlayfs: unrecognized mount option "lowerdir" or missing value overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop0): Unmounting Filesystem XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop3): Unmounting Filesystem IPVS: ftp: loaded support on port[0] = 21 XFS (loop0): Mounting V4 Filesystem audit: type=1800 audit(1676393565.071:19189): pid=24321 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=15402 res=0 XFS (loop0): Ending clean mount overlayfs: unrecognized mount option "lowerdir" or missing value IPVS: ftp: loaded support on port[0] = 21 overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. audit: type=1800 audit(1676393565.341:19190): pid=24348 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.5" name="file0" dev="sda1" ino=15399 res=0 XFS (loop0): Unmounting Filesystem IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 audit: type=1800 audit(1676393566.911:19191): pid=24449 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.5" name="file0" dev="sda1" ino=15401 res=0 IPVS: ftp: loaded support on port[0] = 21 XFS (loop3): Mounting V4 Filesystem XFS (loop3): Ending clean mount overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop3): Unmounting Filesystem IPVS: ftp: loaded support on port[0] = 21 audit: type=1800 audit(1676393568.301:19192): pid=24521 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.5" name="file0" dev="sda1" ino=15348 res=0 IPVS: ftp: loaded support on port[0] = 21 XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount overlayfs: unrecognized mount option "lowerdir" or missing value overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop0): Unmounting Filesystem XFS (loop3): Mounting V4 Filesystem EXT4-fs (loop5): couldn't mount RDWR because of unsupported optional features (8000) IPVS: ftp: loaded support on port[0] = 21 XFS (loop3): Ending clean mount audit: type=1800 audit(1676393569.611:19193): pid=24613 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=15429 res=0 overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop3): Unmounting Filesystem IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 audit: type=1800 audit(1676393570.342:19194): pid=24697 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=15436 res=0 IPVS: ftp: loaded support on port[0] = 21 XFS (loop0): Mounting V4 Filesystem XFS (loop0): Ending clean mount overlayfs: failed to resolve 'f': -2 overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off. XFS (loop0): Unmounting Filesystem ---------------- Code disassembly (best guess): 0: 28 00 sub %al,(%rax) 2: 00 00 add %al,(%rax) 4: 75 05 jne 0xb 6: 48 83 c4 28 add $0x28,%rsp a: c3 retq b: e8 f1 19 00 00 callq 0x1a01 10: 90 nop 11: 48 89 f8 mov %rdi,%rax 14: 48 89 f7 mov %rsi,%rdi 17: 48 89 d6 mov %rdx,%rsi 1a: 48 89 ca mov %rcx,%rdx 1d: 4d 89 c2 mov %r8,%r10 20: 4d 89 c8 mov %r9,%r8 23: 4c 8b 4c 24 08 mov 0x8(%rsp),%r9 28: 0f 05 syscall * 2a: 48 3d 01 f0 ff ff cmp $0xfffffffffffff001,%rax <-- trapping instruction 30: 73 01 jae 0x33 32: c3 retq 33: 48 c7 c1 b8 ff ff ff mov $0xffffffffffffffb8,%rcx 3a: f7 d8 neg %eax 3c: 64 89 01 mov %eax,%fs:(%rcx) 3f: 48 rex.W