ntfs3: loop4: Mark volume as dirty due to NTFS errors ====================================================== WARNING: possible circular locking dependency detected 6.1.112-syzkaller #0 Not tainted ------------------------------------------------------ syz.4.448/5788 is trying to acquire lock: ffff0000e17860e0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline] ffff0000e17860e0 (&ni->ni_lock/4){+.+.}-{3:3}, at: mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 but task is already holding lock: ffff0000e1782d40 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1116 [inline] ffff0000e1782d40 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x12c/0xe3c fs/ntfs3/frecord.c:3323 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ntfs_set_state+0x1a4/0x584 fs/ntfs3/fsntfs.c:920 ni_remove_name+0x230/0x7a4 fs/ntfs3/frecord.c:2998 ntfs_unlink_inode+0x318/0x65c fs/ntfs3/inode.c:1737 ntfs_unlink+0x3c/0x60 fs/ntfs3/namei.c:184 vfs_unlink+0x2f0/0x508 fs/namei.c:4324 do_unlinkat+0x4cc/0x70c fs/namei.c:4392 __do_sys_unlinkat fs/namei.c:4435 [inline] __se_sys_unlinkat fs/namei.c:4428 [inline] __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4428 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline] mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x360/0x2be8 fs/ntfs3/inode.c:525 ni_update_parent+0x6f0/0xac8 fs/ntfs3/frecord.c:3279 ni_write_inode+0x8a0/0xe3c fs/ntfs3/frecord.c:3377 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1031 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x614/0x1770 fs/fs-writeback.c:1677 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1733 write_inode_now+0x198/0x230 fs/fs-writeback.c:2769 ntfs_extend+0x310/0x408 fs/ntfs3/file.c:453 ntfs_file_write_iter+0x2a0/0x580 fs/ntfs3/file.c:1158 call_write_iter include/linux/fs.h:2265 [inline] aio_write+0x588/0x824 fs/aio.c:1615 io_submit_one+0x824/0x15b8 fs/aio.c:2034 __do_sys_io_submit fs/aio.c:2093 [inline] __se_sys_io_submit fs/aio.c:2063 [inline] __arm64_sys_io_submit+0x248/0x3c8 fs/aio.c:2063 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); *** DEADLOCK *** 2 locks held by syz.4.448/5788: #0: ffff0000e1782fe0 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:778 [inline] #0: ffff0000e1782fe0 (&sb->s_type->i_mutex_key#28){+.+.}-{3:3}, at: ntfs_file_write_iter+0x190/0x580 fs/ntfs3/file.c:1142 #1: ffff0000e1782d40 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1116 [inline] #1: ffff0000e1782d40 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x12c/0xe3c fs/ntfs3/frecord.c:3323 stack backtrace: CPU: 0 PID: 5788 Comm: syz.4.448 Not tainted 6.1.112-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline] mi_read+0x26c/0x4d8 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x360/0x2be8 fs/ntfs3/inode.c:525 ni_update_parent+0x6f0/0xac8 fs/ntfs3/frecord.c:3279 ni_write_inode+0x8a0/0xe3c fs/ntfs3/frecord.c:3377 ntfs3_write_inode+0x70/0x98 fs/ntfs3/inode.c:1031 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x614/0x1770 fs/fs-writeback.c:1677 writeback_single_inode+0x1c0/0x79c fs/fs-writeback.c:1733 write_inode_now+0x198/0x230 fs/fs-writeback.c:2769 ntfs_extend+0x310/0x408 fs/ntfs3/file.c:453 ntfs_file_write_iter+0x2a0/0x580 fs/ntfs3/file.c:1158 call_write_iter include/linux/fs.h:2265 [inline] aio_write+0x588/0x824 fs/aio.c:1615 io_submit_one+0x824/0x15b8 fs/aio.c:2034 __do_sys_io_submit fs/aio.c:2093 [inline] __se_sys_io_submit fs/aio.c:2063 [inline] __arm64_sys_io_submit+0x248/0x3c8 fs/aio.c:2063 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 ntfs3: loop4: ino=1d, "file1" failed to open parent directory r=400 to update ntfs3: loop4: ino=1d, "file1" failed to open parent directory r=400 to update