====================================================== WARNING: possible circular locking dependency detected 5.15.105-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.0/26701 is trying to acquire lock: ffff88807ade60f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff8880779407c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_get_block+0x37f/0x14e0 fs/hfsplus/extents.c:260 block_read_full_page+0x2f9/0xde0 fs/buffer.c:2290 do_read_cache_page+0x752/0x1040 read_mapping_page include/linux/pagemap.h:515 [inline] hfsplus_block_allocate+0xfa/0x8d0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x60b/0x1650 fs/buffer.c:2012 __block_write_begin fs/buffer.c:2062 [inline] block_write_begin fs/buffer.c:2122 [inline] cont_write_begin+0x5d6/0x840 fs/buffer.c:2471 hfsplus_write_begin+0x92/0xd0 fs/hfsplus/inode.c:53 __page_symlink+0x15b/0x2a0 fs/namei.c:5079 hfsplus_symlink+0xc6/0x260 fs/hfsplus/dir.c:449 vfs_symlink+0x2ad/0x490 fs/namei.c:4358 do_symlinkat+0x1fd/0x600 fs/namei.c:4387 __do_sys_symlinkat fs/namei.c:4404 [inline] __se_sys_symlinkat fs/namei.c:4401 [inline] __x64_sys_symlinkat+0x95/0xa0 fs/namei.c:4401 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:673 [inline] do_direct_IO fs/direct-io.c:959 [inline] do_blockdev_direct_IO fs/direct-io.c:1276 [inline] __blockdev_direct_IO+0x1b13/0x4f40 fs/direct-io.c:1368 blockdev_direct_IO include/linux/fs.h:3230 [inline] hfsplus_direct_IO+0xf6/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x204/0x460 mm/filemap.c:3678 __generic_file_write_iter+0x2a2/0x4f0 mm/filemap.c:3860 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3935 do_iter_readv_writev+0x594/0x7a0 do_iter_write+0x1ea/0x760 fs/read_write.c:855 vfs_writev fs/read_write.c:928 [inline] do_pwritev+0x219/0x360 fs/read_write.c:1025 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 3 locks held by syz-executor.0/26701: #0: ffff88807847e460 (sb_writers#25){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:927 [inline] #0: ffff88807847e460 (sb_writers#25){.+.+}-{0:0}, at: do_pwritev+0x1fd/0x360 fs/read_write.c:1025 #1: ffff8880779409c0 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline] #1: ffff8880779409c0 (&sb->s_type->i_mutex_key#31){+.+.}-{3:3}, at: generic_file_write_iter+0x7c/0x1b0 mm/filemap.c:3932 #2: ffff8880779407c8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1d2/0x1b10 fs/hfsplus/extents.c:457 stack backtrace: CPU: 1 PID: 26701 Comm: syz-executor.0 Not tainted 5.15.105-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1646/0x58b0 kernel/locking/lockdep.c:3787 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5011 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5622 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 hfsplus_block_allocate+0x8a/0x8d0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xa4c/0x1b10 fs/hfsplus/extents.c:468 hfsplus_get_block+0x402/0x14e0 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:673 [inline] do_direct_IO fs/direct-io.c:959 [inline] do_blockdev_direct_IO fs/direct-io.c:1276 [inline] __blockdev_direct_IO+0x1b13/0x4f40 fs/direct-io.c:1368 blockdev_direct_IO include/linux/fs.h:3230 [inline] hfsplus_direct_IO+0xf6/0x1e0 fs/hfsplus/inode.c:135 generic_file_direct_write+0x204/0x460 mm/filemap.c:3678 __generic_file_write_iter+0x2a2/0x4f0 mm/filemap.c:3860 generic_file_write_iter+0xa7/0x1b0 mm/filemap.c:3935 do_iter_readv_writev+0x594/0x7a0 do_iter_write+0x1ea/0x760 fs/read_write.c:855 vfs_writev fs/read_write.c:928 [inline] do_pwritev+0x219/0x360 fs/read_write.c:1025 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x61/0xcb RIP: 0033:0x7fc5ae652169 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fc5a4802168 EFLAGS: 00000246 ORIG_RAX: 0000000000000148 RAX: ffffffffffffffda RBX: 00007fc5ae772120 RCX: 00007fc5ae652169 RDX: 0000000000000001 RSI: 0000000020000680 RDI: 0000000000000004 RBP: 00007fc5ae6adca1 R08: 000000000000002f R09: 0000000000000000 R10: 0000000000000600 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffcc2151f3f R14: 00007fc5a4802300 R15: 0000000000022000