======================================================
WARNING: possible circular locking dependency detected
6.0.0-rc7-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.4/29162 is trying to acquire lock:
ffff8880793d45b8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline]
ffff8880793d45b8 (&jsk->sk_session_queue_lock){+.-.}-{2:2}, at: j1939_sk_queue_drop_all+0x3f/0x250 net/can/j1939/socket.c:139

but task is already holding lock:
ffff8880414790d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline]
ffff8880414790d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_netdev_event_netdown+0x2d/0x160 net/can/j1939/socket.c:1269

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&priv->j1939_socks_lock){+.-.}-{2:2}:
       lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5666
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:354 [inline]
       j1939_sk_errqueue+0x92/0x160 net/can/j1939/socket.c:1081
       j1939_session_cancel+0x180/0x210 net/can/j1939/transport.c:1141
       j1939_xtp_rx_cts net/can/j1939/transport.c:1479 [inline]
       j1939_tp_cmd_recv net/can/j1939/transport.c:2064 [inline]
       j1939_tp_recv+0x7aa/0x14f0 net/can/j1939/transport.c:2139
       j1939_can_recv+0x67c/0xa90 net/can/j1939/main.c:108
       deliver net/can/af_can.c:574 [inline]
       can_rcv_filter+0x35e/0x800 net/can/af_can.c:608
       can_receive+0x2e8/0x410 net/can/af_can.c:665
       can_rcv+0xda/0x200 net/can/af_can.c:696
       __netif_receive_skb_one_core net/core/dev.c:5485 [inline]
       __netif_receive_skb+0x1c5/0x500 net/core/dev.c:5599
       process_backlog+0x4f8/0x8b0 net/core/dev.c:5927
       __napi_poll+0xbe/0x4b0 net/core/dev.c:6511
       napi_poll net/core/dev.c:6578 [inline]
       net_rx_action+0x76c/0x10b0 net/core/dev.c:6689
       __do_softirq+0x382/0x793 kernel/softirq.c:571
       run_ksoftirqd+0xc1/0x120 kernel/softirq.c:934
       smpboot_thread_fn+0x533/0x9d0 kernel/smpboot.c:164
       kthread+0x266/0x300 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

-> #1 (&priv->active_session_list_lock){+.-.}-{2:2}:
       lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5666
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:354 [inline]
       j1939_session_list_lock net/can/j1939/transport.c:238 [inline]
       j1939_session_activate+0x4d/0x450 net/can/j1939/transport.c:1559
       j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline]
       j1939_sk_queue_activate_next+0x279/0x3f0 net/can/j1939/socket.c:208
       j1939_session_deactivate_activate_next net/can/j1939/transport.c:1107 [inline]
       j1939_xtp_rx_abort_one+0x5db/0x720 net/can/j1939/transport.c:1346
       j1939_xtp_rx_abort net/can/j1939/transport.c:1357 [inline]
       j1939_tp_cmd_recv net/can/j1939/transport.c:2106 [inline]
       j1939_tp_recv+0x91e/0x14f0 net/can/j1939/transport.c:2139
       j1939_can_recv+0x67c/0xa90 net/can/j1939/main.c:108
       deliver net/can/af_can.c:574 [inline]
       can_rcv_filter+0x35e/0x800 net/can/af_can.c:608
       can_receive+0x2e8/0x410 net/can/af_can.c:665
       can_rcv+0xda/0x200 net/can/af_can.c:696
       __netif_receive_skb_one_core net/core/dev.c:5485 [inline]
       __netif_receive_skb+0x1c5/0x500 net/core/dev.c:5599
       process_backlog+0x4f8/0x8b0 net/core/dev.c:5927
       __napi_poll+0xbe/0x4b0 net/core/dev.c:6511
       napi_poll net/core/dev.c:6578 [inline]
       net_rx_action+0x76c/0x10b0 net/core/dev.c:6689
       __do_softirq+0x382/0x793 kernel/softirq.c:571
       run_ksoftirqd+0xc1/0x120 kernel/softirq.c:934
       smpboot_thread_fn+0x533/0x9d0 kernel/smpboot.c:164
       kthread+0x266/0x300 kernel/kthread.c:376
       ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:306

-> #0 (&jsk->sk_session_queue_lock){+.-.}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3095 [inline]
       check_prevs_add kernel/locking/lockdep.c:3214 [inline]
       validate_chain+0x1872/0x6600 kernel/locking/lockdep.c:3829
       __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5053
       lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5666
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:354 [inline]
       j1939_sk_queue_drop_all+0x3f/0x250 net/can/j1939/socket.c:139
       j1939_sk_netdev_event_netdown+0xf5/0x160 net/can/j1939/socket.c:1275
       j1939_netdev_notify+0x204/0x330 net/can/j1939/main.c:372
       notifier_call_chain kernel/notifier.c:87 [inline]
       raw_notifier_call_chain+0xe7/0x170 kernel/notifier.c:455
       __dev_notify_flags+0x2ef/0x5f0
       dev_change_flags+0xe3/0x190 net/core/dev.c:8632
       do_setlink+0xdb2/0x3f00 net/core/rtnetlink.c:2780
       __rtnl_newlink net/core/rtnetlink.c:3546 [inline]
       rtnl_newlink+0x183e/0x2060 net/core/rtnetlink.c:3593
       rtnetlink_rcv_msg+0x7c9/0xeb0 net/core/rtnetlink.c:6090
       netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2501
       netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
       netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
       netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
       sock_sendmsg_nosec net/socket.c:714 [inline]
       sock_sendmsg net/socket.c:734 [inline]
       ____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
       ___sys_sendmsg net/socket.c:2536 [inline]
       __sys_sendmsg+0x28e/0x390 net/socket.c:2565
       do_syscall_x64 arch/x86/entry/common.c:50 [inline]
       do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
       entry_SYSCALL_64_after_hwframe+0x63/0xcd

other info that might help us debug this:

Chain exists of:
  &jsk->sk_session_queue_lock --> &priv->active_session_list_lock --> &priv->j1939_socks_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&priv->j1939_socks_lock);
                               lock(&priv->active_session_list_lock);
                               lock(&priv->j1939_socks_lock);
  lock(&jsk->sk_session_queue_lock);

 *** DEADLOCK ***

2 locks held by syz-executor.4/29162:
 #0: ffffffff8ddd6ea8 (rtnl_mutex){+.+.}-{3:3}, at: rtnl_lock net/core/rtnetlink.c:74 [inline]
 #0: ffffffff8ddd6ea8 (rtnl_mutex){+.+.}-{3:3}, at: rtnetlink_rcv_msg+0x772/0xeb0 net/core/rtnetlink.c:6087
 #1: ffff8880414790d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:354 [inline]
 #1: ffff8880414790d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_netdev_event_netdown+0x2d/0x160 net/can/j1939/socket.c:1269

stack backtrace:
CPU: 1 PID: 29162 Comm: syz-executor.4 Not tainted 6.0.0-rc7-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/26/2022
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106
 check_noncircular+0x2f9/0x3b0 kernel/locking/lockdep.c:2175
 check_prev_add kernel/locking/lockdep.c:3095 [inline]
 check_prevs_add kernel/locking/lockdep.c:3214 [inline]
 validate_chain+0x1872/0x6600 kernel/locking/lockdep.c:3829
 __lock_acquire+0x1292/0x1f60 kernel/locking/lockdep.c:5053
 lock_acquire+0x1a7/0x400 kernel/locking/lockdep.c:5666
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
 _raw_spin_lock_bh+0x31/0x40 kernel/locking/spinlock.c:178
 spin_lock_bh include/linux/spinlock.h:354 [inline]
 j1939_sk_queue_drop_all+0x3f/0x250 net/can/j1939/socket.c:139
 j1939_sk_netdev_event_netdown+0xf5/0x160 net/can/j1939/socket.c:1275
 j1939_netdev_notify+0x204/0x330 net/can/j1939/main.c:372
 notifier_call_chain kernel/notifier.c:87 [inline]
 raw_notifier_call_chain+0xe7/0x170 kernel/notifier.c:455
 __dev_notify_flags+0x2ef/0x5f0
 dev_change_flags+0xe3/0x190 net/core/dev.c:8632
 do_setlink+0xdb2/0x3f00 net/core/rtnetlink.c:2780
 __rtnl_newlink net/core/rtnetlink.c:3546 [inline]
 rtnl_newlink+0x183e/0x2060 net/core/rtnetlink.c:3593
 rtnetlink_rcv_msg+0x7c9/0xeb0 net/core/rtnetlink.c:6090
 netlink_rcv_skb+0x1f0/0x460 net/netlink/af_netlink.c:2501
 netlink_unicast_kernel net/netlink/af_netlink.c:1319 [inline]
 netlink_unicast+0x7e7/0x9c0 net/netlink/af_netlink.c:1345
 netlink_sendmsg+0x9b3/0xcd0 net/netlink/af_netlink.c:1921
 sock_sendmsg_nosec net/socket.c:714 [inline]
 sock_sendmsg net/socket.c:734 [inline]
 ____sys_sendmsg+0x597/0x8e0 net/socket.c:2482
 ___sys_sendmsg net/socket.c:2536 [inline]
 __sys_sendmsg+0x28e/0x390 net/socket.c:2565
 do_syscall_x64 arch/x86/entry/common.c:50 [inline]
 do_syscall_64+0x2b/0x70 arch/x86/entry/common.c:80
 entry_SYSCALL_64_after_hwframe+0x63/0xcd
RIP: 0033:0x7ff95328a669
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff95446b168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007ff9533ac050 RCX: 00007ff95328a669
RDX: 0000000000000000 RSI: 0000000020000140 RDI: 0000000000000003
RBP: 00007ff9532e5560 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffc16f18fef R14: 00007ff95446b300 R15: 0000000000022000
 </TASK>
A link change request failed with some changes committed already. Interface vxcan0 may have been left with an inconsistent configuration, please check.