overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
======================================================
WARNING: possible circular locking dependency detected
4.14.296-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/10266 is trying to acquire lock:
 (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff81891da9>] inode_lock_shared include/linux/fs.h:729 [inline]
 (&ovl_i_mutex_dir_key[depth]#2){++++}, at: [<ffffffff81891da9>] lookup_slow+0x129/0x400 fs/namei.c:1674

but task is already holding lock:
 (&oi->lock){+.+.}, at: [<ffffffff82316fff>] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #2 (&oi->lock){+.+.}:
       __mutex_lock_common kernel/locking/mutex.c:756 [inline]
       __mutex_lock+0xc4/0x1310 kernel/locking/mutex.c:893
       ovl_copy_up_start+0x40/0xe0 fs/overlayfs/util.c:318
       ovl_copy_up_one+0x21f/0x910 fs/overlayfs/copy_up.c:631
       ovl_copy_up_flags+0xd5/0x120 fs/overlayfs/copy_up.c:686
       ovl_rename+0x164/0xe50 fs/overlayfs/dir.c:939
       vfs_rename+0x560/0x1820 fs/namei.c:4498
       SYSC_renameat2 fs/namei.c:4646 [inline]
       SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #1 (sb_writers#3){.+.+}:
       percpu_down_read_preempt_disable include/linux/percpu-rwsem.h:36 [inline]
       percpu_down_read include/linux/percpu-rwsem.h:59 [inline]
       __sb_start_write+0x64/0x260 fs/super.c:1342
       sb_start_write include/linux/fs.h:1551 [inline]
       mnt_want_write+0x3a/0xb0 fs/namespace.c:386
       ovl_xattr_set+0x4d/0x290 fs/overlayfs/inode.c:214
       __vfs_setxattr+0xdc/0x130 fs/xattr.c:150
       __vfs_setxattr_noperm+0xfd/0x3d0 fs/xattr.c:181
       __vfs_setxattr_locked+0x14d/0x250 fs/xattr.c:239
       vfs_setxattr+0xcf/0x230 fs/xattr.c:256
       setxattr+0x1a9/0x300 fs/xattr.c:523
       path_setxattr+0x118/0x130 fs/xattr.c:542
       SYSC_lsetxattr fs/xattr.c:564 [inline]
       SyS_lsetxattr+0x33/0x40 fs/xattr.c:560
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

-> #0 (&ovl_i_mutex_dir_key[depth]#2){++++}:
       lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
       down_read+0x36/0x80 kernel/locking/rwsem.c:24
       inode_lock_shared include/linux/fs.h:729 [inline]
       lookup_slow+0x129/0x400 fs/namei.c:1674
       lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595
       ovl_lower_positive+0x184/0x350 fs/overlayfs/namei.c:783
       ovl_rename+0x47c/0xe50 fs/overlayfs/dir.c:968
       vfs_rename+0x560/0x1820 fs/namei.c:4498
       SYSC_renameat2 fs/namei.c:4646 [inline]
       SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
       do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
       entry_SYSCALL_64_after_hwframe+0x46/0xbb

other info that might help us debug this:

Chain exists of:
  &ovl_i_mutex_dir_key[depth]#2 --> sb_writers#3 --> &oi->lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->lock);
                               lock(sb_writers#3);
                               lock(&oi->lock);
  lock(&ovl_i_mutex_dir_key[depth]#2);

 *** DEADLOCK ***

8 locks held by syz-executor.1/10266:
 #0:  (sb_writers#13){.+.+}, at: [<ffffffff818e0bca>] sb_start_write include/linux/fs.h:1551 [inline]
 #0:  (sb_writers#13){.+.+}, at: [<ffffffff818e0bca>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 #1:  (&type->s_vfs_rename_key#2){+.+.}, at: [<ffffffff818920d4>] lock_rename+0x54/0x280 fs/namei.c:2889
 #2:  (&ovl_i_mutex_dir_key[depth]#3/1){+.+.}, at: [<ffffffff81892120>] inode_lock_nested include/linux/fs.h:754 [inline]
 #2:  (&ovl_i_mutex_dir_key[depth]#3/1){+.+.}, at: [<ffffffff81892120>] lock_rename+0xa0/0x280 fs/namei.c:2893
 #3:  (&ovl_i_mutex_dir_key[depth]#3/2){+.+.}, at: [<ffffffff81892154>] inode_lock_nested include/linux/fs.h:754 [inline]
 #3:  (&ovl_i_mutex_dir_key[depth]#3/2){+.+.}, at: [<ffffffff81892154>] lock_rename+0xd4/0x280 fs/namei.c:2894
 #4:  (&ovl_i_mutex_key[depth]){+.+.}, at: [<ffffffff818cb8da>] inode_lock include/linux/fs.h:719 [inline]
 #4:  (&ovl_i_mutex_key[depth]){+.+.}, at: [<ffffffff818cb8da>] lock_two_nondirectories+0xca/0xf0 fs/inode.c:989
 #5:  (&ovl_i_mutex_key[depth]/4){+.+.}, at: [<ffffffff818cb8c2>] inode_lock_nested include/linux/fs.h:754 [inline]
 #5:  (&ovl_i_mutex_key[depth]/4){+.+.}, at: [<ffffffff818cb8c2>] lock_two_nondirectories+0xb2/0xf0 fs/inode.c:991
 #6:  (sb_writers#3){.+.+}, at: [<ffffffff818e0bca>] sb_start_write include/linux/fs.h:1551 [inline]
 #6:  (sb_writers#3){.+.+}, at: [<ffffffff818e0bca>] mnt_want_write+0x3a/0xb0 fs/namespace.c:386
 #7:  (&oi->lock){+.+.}, at: [<ffffffff82316fff>] ovl_nlink_start+0x22f/0x460 fs/overlayfs/util.c:523

stack backtrace:
CPU: 0 PID: 10266 Comm: syz-executor.1 Not tainted 4.14.296-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/11/2022
Call Trace:
 __dump_stack lib/dump_stack.c:17 [inline]
 dump_stack+0x1b2/0x281 lib/dump_stack.c:58
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1258
 check_prev_add kernel/locking/lockdep.c:1905 [inline]
 check_prevs_add kernel/locking/lockdep.c:2022 [inline]
 validate_chain kernel/locking/lockdep.c:2464 [inline]
 __lock_acquire+0x2e0e/0x3f20 kernel/locking/lockdep.c:3491
 lock_acquire+0x170/0x3f0 kernel/locking/lockdep.c:3998
 down_read+0x36/0x80 kernel/locking/rwsem.c:24
 inode_lock_shared include/linux/fs.h:729 [inline]
 lookup_slow+0x129/0x400 fs/namei.c:1674
 lookup_one_len_unlocked+0x3a0/0x410 fs/namei.c:2595
 ovl_lower_positive+0x184/0x350 fs/overlayfs/namei.c:783
 ovl_rename+0x47c/0xe50 fs/overlayfs/dir.c:968
 vfs_rename+0x560/0x1820 fs/namei.c:4498
 SYSC_renameat2 fs/namei.c:4646 [inline]
 SyS_renameat2+0x95b/0xad0 fs/namei.c:4535
 do_syscall_64+0x1d5/0x640 arch/x86/entry/common.c:292
 entry_SYSCALL_64_after_hwframe+0x46/0xbb
RIP: 0033:0x7f555ecb05a9
RSP: 002b:00007f555d223168 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007f555edd0f80 RCX: 00007f555ecb05a9
RDX: 0000000000000000 RSI: 0000000020000440 RDI: 0000000020000380
RBP: 00007f555ed0b7b0 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ffdd5e5fa7f R14: 00007f555d223300 R15: 0000000000022000
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
overlayfs: fs on 'file0' does not support file handles, falling back to index=off.
netlink: 194488 bytes leftover after parsing attributes in process `syz-executor.3'.
overlayfs: fs on './file0' does not support file handles, falling back to index=off.
netlink: 194488 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 194488 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.0'.
Zero length message leads to an empty skb
netlink: 194488 bytes leftover after parsing attributes in process `syz-executor.3'.
IPVS: ftp: loaded support on port[0] = 21
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.0'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.3'.
netlink: 24 bytes leftover after parsing attributes in process `syz-executor.0'.
REISERFS (device loop0): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop0): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop0): Using rupasov hash to sort names
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
NILFS (loop3): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
REISERFS (device loop0): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop0): using ordered data mode
reiserfs: using flush barriers
NILFS (loop2): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
NILFS (loop3): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop0): Using rupasov hash to sort names
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
NILFS (loop2): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
NILFS (loop3): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop4): Using rupasov hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
NILFS (loop2): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
NILFS (loop3): segctord starting. Construction interval = 5 seconds, CP frequency < 30 seconds
REISERFS (device loop0): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
REISERFS (device loop0): using ordered data mode
REISERFS (device loop4): using ordered data mode
reiserfs: using flush barriers
reiserfs: using flush barriers
REISERFS (device loop0): journal params: device loop0, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
REISERFS (device loop0): checking transaction log (loop0)
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop0): Using rupasov hash to sort names
kauditd_printk_skb: 14 callbacks suppressed
audit: type=1804 audit(1666971711.451:32): pid=10735 uid=0 auid=4294967295 ses=4294967295 op="invalid_pcr" cause="open_writers" comm="syz-executor.3" name="/root/syzkaller-testdir2754273052/syzkaller.RNWSNC/43/bus" dev="sda1" ino=14082 res=1
REISERFS (device loop0): Created .reiserfs_priv - reserved for xattr storage.
audit: type=1800 audit(1666971711.461:33): pid=10735 uid=0 auid=4294967295 ses=4294967295 op="collect_data" cause="failed(directio)" comm="syz-executor.3" name="bus" dev="sda1" ino=14082 res=0
REISERFS (device loop4): Using rupasov hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
ubi0: attaching mtd0
ubi0: scanning is finished
ubi0: empty MTD device detected
REISERFS (device loop4): found reiserfs format "3.6" with non-standard journal
ubi0: attached mtd0 (name "mtdram test device", size 0 MiB)
ubi0: PEB size: 4096 bytes (4 KiB), LEB size: 3968 bytes
ubi0: min./max. I/O unit sizes: 1/64, sub-page size 1
ubi0: VID header offset: 64 (aligned 64), data offset: 128
REISERFS (device loop4): using ordered data mode
ubi0: good PEBs: 32, bad PEBs: 0, corrupted PEBs: 0
reiserfs: using flush barriers
ubi0: user volume: 0, internal volumes: 1, max. volumes count: 23
ubi0: max/mean erase counter: 0/0, WL threshold: 4096, image sequence number: 3961891663
REISERFS (device loop4): journal params: device loop4, size 512, journal first block 18, max trans len 256, max batch 225, max commit age 30, max trans age 30
ubi0: available PEBs: 28, total reserved PEBs: 4, PEBs reserved for bad PEB handling: 0
ubi0: background thread "ubi_bgt0d" started, PID 10784
ubi0: detaching mtd0
ubi0: mtd0 is detached
REISERFS (device loop4): checking transaction log (loop4)
REISERFS (device loop4): Using rupasov hash to sort names
REISERFS (device loop4): Created .reiserfs_priv - reserved for xattr storage.
ubi0: attaching mtd0
ubi0: scanning is finished
ubi0: attached mtd0 (name "mtdram test device", size 0 MiB)
ubi0: PEB size: 4096 bytes (4 KiB), LEB size: 3968 bytes
ubi0: min./max. I/O unit sizes: 1/64, sub-page size 1
ubi0: VID header offset: 64 (aligned 64), data offset: 128
ubi0: good PEBs: 32, bad PEBs: 0, corrupted PEBs: 0
ubi0: user volume: 0, internal volumes: 1, max. volumes count: 23
ubi0: max/mean erase counter: 1/1, WL threshold: 4096, image sequence number: 3961891663
ubi0: available PEBs: 28, total reserved PEBs: 4, PEBs reserved for bad PEB handling: 0
ubi0: detaching mtd0
ubi0: mtd0 is detached
ubi0: attaching mtd0
ubi0: scanning is finished
ubi0: attached mtd0 (name "mtdram test device", size 0 MiB)
ubi0: PEB size: 4096 bytes (4 KiB), LEB size: 3968 bytes
ubi0: min./max. I/O unit sizes: 1/64, sub-page size 1
ubi0: VID header offset: 64 (aligned 64), data offset: 128
ubi0: good PEBs: 32, bad PEBs: 0, corrupted PEBs: 0
ubi0: user volume: 0, internal volumes: 1, max. volumes count: 23
ubi0: max/mean erase counter: 1/1, WL threshold: 4096, image sequence number: 3961891663
ubi0: available PEBs: 28, total reserved PEBs: 4, PEBs reserved for bad PEB handling: 0
ubi0: background thread "ubi_bgt0d" started, PID 10886
ubi0: detaching mtd0
ubi0: mtd0 is detached
ubi0: attaching mtd0
ubi0: scanning is finished
ubi0: attached mtd0 (name "mtdram test device", size 0 MiB)
ubi0: PEB size: 4096 bytes (4 KiB), LEB size: 3968 bytes
ubi0: min./max. I/O unit sizes: 1/64, sub-page size 1
ubi0: VID header offset: 64 (aligned 64), data offset: 128
ubi0: good PEBs: 32, bad PEBs: 0, corrupted PEBs: 0
ubi0: user volume: 0, internal volumes: 1, max. volumes count: 23
ubi0: max/mean erase counter: 2/1, WL threshold: 4096, image sequence number: 3961891663
ubi0: available PEBs: 28, total reserved PEBs: 4, PEBs reserved for bad PEB handling: 0
ubi0: background thread "ubi_bgt0d" started, PID 10908
ubi0: detaching mtd0
ubi0: mtd0 is detached
ubi0: attaching mtd0
ubi0: scanning is finished
ubi0: attached mtd0 (name "mtdram test device", size 0 MiB)
ubi0: PEB size: 4096 bytes (4 KiB), LEB size: 3968 bytes
ubi0: min./max. I/O unit sizes: 1/64, sub-page size 1
ubi0: VID header offset: 64 (aligned 64), data offset: 128
ubi0: good PEBs: 32, bad PEBs: 0, corrupted PEBs: 0
ubi0: user volume: 0, internal volumes: 1, max. volumes count: 23
ubi0: max/mean erase counter: 2/1, WL threshold: 4096, image sequence number: 3961891663
ubi0: available PEBs: 28, total reserved PEBs: 4, PEBs reserved for bad PEB handling: 0
ubi0: background thread "ubi_bgt0d" started, PID 10924
ubi0: detaching mtd0
ubi0: mtd0 is detached
ubi0: attaching mtd0
ubi0: scanning is finished
ubi0: attached mtd0 (name "mtdram test device", size 0 MiB)
ubi0: PEB size: 4096 bytes (4 KiB), LEB size: 3968 bytes
ubi0: min./max. I/O unit sizes: 1/64, sub-page size 1
ubi0: VID header offset: 64 (aligned 64), data offset: 128
ubi0: good PEBs: 32, bad PEBs: 0, corrupted PEBs: 0
ubi0: user volume: 0, internal volumes: 1, max. volumes count: 23
ubi0: max/mean erase counter: 2/1, WL threshold: 4096, image sequence number: 3961891663
ubi0: available PEBs: 28, total reserved PEBs: 4, PEBs reserved for bad PEB handling: 0
ubi0: background thread "ubi_bgt0d" started, PID 10947
ubi0: detaching mtd0
ubi0: mtd0 is detached
ubi0: attaching mtd0
ubi0: scanning is finished
ubi0: attached mtd0 (name "mtdram test device", size 0 MiB)
ubi0: PEB size: 4096 bytes (4 KiB), LEB size: 3968 bytes
ubi0: min./max. I/O unit sizes: 1/64, sub-page size 1
ubi0: VID header offset: 64 (aligned 64), data offset: 128
ubi0: good PEBs: 32, bad PEBs: 0, corrupted PEBs: 0
ubi0: user volume: 0, internal volumes: 1, max. volumes count: 23
ubi0: max/mean erase counter: 2/1, WL threshold: 4096, image sequence number: 3961891663
ubi0: available PEBs: 28, total reserved PEBs: 4, PEBs reserved for bad PEB handling: 0
ubi0: detaching mtd0
ubi0: background thread "ubi_bgt0d" started, PID 10959
ubi0: mtd0 is detached