ocfs2: Mounting device (7,3) on (node local, slot 0) with ordered data mode. ====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc6-next-20250107-syzkaller #0 Not tainted ------------------------------------------------------ syz.3.436/7580 is trying to acquire lock: ffff88805dec0610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_write_begin_inline fs/ocfs2/aops.c:1465 [inline] ffff88805dec0610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1569 [inline] ffff88805dec0610 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_write_begin_nolock+0x2274/0x4e40 fs/ocfs2/aops.c:1655 but task is already holding lock: ffff88805b1c94a0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_write_begin+0x1d1/0x3a0 fs/ocfs2/aops.c:1887 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 ocfs2_try_remove_refcount_tree+0xb6/0x330 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0xa4f/0x1930 fs/ocfs2/xattr.c:3669 ocfs2_set_acl+0x4cb/0x580 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x24a/0x3c0 fs/ocfs2/acl.c:286 set_posix_acl fs/posix_acl.c:954 [inline] vfs_set_acl+0x7fd/0xa60 fs/posix_acl.c:1133 do_setxattr fs/xattr.c:633 [inline] filename_setxattr+0x325/0x430 fs/xattr.c:665 path_setxattrat+0x440/0x510 fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __x64_sys_setxattr+0xbc/0xe0 fs/xattr.c:743 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #3 (&oi->ip_xattr_sem){++++}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_init_acl+0x397/0x930 fs/ocfs2/acl.c:366 ocfs2_mknod+0x1c05/0x2b30 fs/ocfs2/namei.c:410 ocfs2_create+0x1ab/0x470 fs/ocfs2/namei.c:674 lookup_open fs/namei.c:3649 [inline] open_last_lookups fs/namei.c:3748 [inline] path_openat+0x192f/0x3580 fs/namei.c:3984 do_filp_open+0x27f/0x4e0 fs/namei.c:4014 do_sys_openat2+0x13e/0x1d0 fs/open.c:1427 do_sys_open fs/open.c:1442 [inline] __do_sys_open fs/open.c:1450 [inline] __se_sys_open fs/open.c:1446 [inline] __x64_sys_open+0x225/0x270 fs/open.c:1446 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (jbd2_handle){++++}-{0:0}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 start_this_handle+0x1eb4/0x2110 fs/jbd2/transaction.c:448 jbd2__journal_start+0x2da/0x5d0 fs/jbd2/transaction.c:505 jbd2_journal_start+0x29/0x40 fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3c9/0x700 fs/ocfs2/journal.c:352 ocfs2_modify_bh+0xed/0x4d0 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x158f/0x19f0 fs/ocfs2/quota_local.c:771 dquot_load_quota_sb+0x762/0xbb0 fs/quota/dquot.c:2459 dquot_load_quota_inode+0x320/0x600 fs/quota/dquot.c:2496 ocfs2_enable_quotas+0x169/0x450 fs/ocfs2/super.c:930 ocfs2_fill_super+0x5adb/0x71f0 fs/ocfs2/super.c:1140 get_tree_bdev_flags+0x48c/0x5c0 fs/super.c:1636 vfs_get_tree+0x90/0x2b0 fs/super.c:1814 do_new_mount+0x2be/0xb40 fs/namespace.c:3560 do_mount fs/namespace.c:3900 [inline] __do_sys_mount fs/namespace.c:4111 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4088 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&journal->j_trans_barrier){.+.+}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3be/0x700 fs/ocfs2/journal.c:350 ocfs2_modify_bh+0xed/0x4d0 fs/ocfs2/quota_local.c:101 ocfs2_local_read_info+0x158f/0x19f0 fs/ocfs2/quota_local.c:771 dquot_load_quota_sb+0x762/0xbb0 fs/quota/dquot.c:2459 dquot_load_quota_inode+0x320/0x600 fs/quota/dquot.c:2496 ocfs2_enable_quotas+0x169/0x450 fs/ocfs2/super.c:930 ocfs2_fill_super+0x5adb/0x71f0 fs/ocfs2/super.c:1140 get_tree_bdev_flags+0x48c/0x5c0 fs/super.c:1636 vfs_get_tree+0x90/0x2b0 fs/super.c:1814 do_new_mount+0x2be/0xb40 fs/namespace.c:3560 do_mount fs/namespace.c:3900 [inline] __do_sys_mount fs/namespace.c:4111 [inline] __se_sys_mount+0x2d6/0x3c0 fs/namespace.c:4088 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (sb_internal#2){.+.+}-{0:0}: check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1773 [inline] sb_start_intwrite include/linux/fs.h:1956 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_write_begin_inline fs/ocfs2/aops.c:1465 [inline] ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1569 [inline] ocfs2_write_begin_nolock+0x2274/0x4e40 fs/ocfs2/aops.c:1655 ocfs2_write_begin+0x205/0x3a0 fs/ocfs2/aops.c:1889 generic_perform_write+0x346/0x990 mm/filemap.c:4113 ocfs2_file_write_iter+0x19af/0x2180 fs/ocfs2/file.c:2469 new_sync_write fs/read_write.c:586 [inline] vfs_write+0xacf/0xd10 fs/read_write.c:679 ksys_write+0x18f/0x2b0 fs/read_write.c:731 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: sb_internal#2 --> &oi->ip_xattr_sem --> &ocfs2_file_ip_alloc_sem_key Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_file_ip_alloc_sem_key); lock(&oi->ip_xattr_sem); lock(&ocfs2_file_ip_alloc_sem_key); rlock(sb_internal#2); *** DEADLOCK *** 4 locks held by syz.3.436/7580: #0: ffff88802421ed38 (&f->f_pos_lock){+.+.}-{4:4}, at: fdget_pos+0x254/0x320 fs/file.c:1192 #1: ffff88805dec0420 (sb_writers#14){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3016 [inline] #1: ffff88805dec0420 (sb_writers#14){.+.+}-{0:0}, at: vfs_write+0x225/0xd10 fs/read_write.c:675 #2: ffff88805b1c9800 (&sb->s_type->i_mutex_key#31){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:865 [inline] #2: ffff88805b1c9800 (&sb->s_type->i_mutex_key#31){+.+.}-{4:4}, at: ocfs2_file_write_iter+0x445/0x2180 fs/ocfs2/file.c:2399 #3: ffff88805b1c94a0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_write_begin+0x1d1/0x3a0 fs/ocfs2/aops.c:1887 stack backtrace: CPU: 1 UID: 0 PID: 7580 Comm: syz.3.436 Not tainted 6.13.0-rc6-next-20250107-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2076 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2208 check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3906 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1773 [inline] sb_start_intwrite include/linux/fs.h:1956 [inline] ocfs2_start_trans+0x2b9/0x700 fs/ocfs2/journal.c:348 ocfs2_write_begin_inline fs/ocfs2/aops.c:1465 [inline] ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1569 [inline] ocfs2_write_begin_nolock+0x2274/0x4e40 fs/ocfs2/aops.c:1655 ocfs2_write_begin+0x205/0x3a0 fs/ocfs2/aops.c:1889 generic_perform_write+0x346/0x990 mm/filemap.c:4113 ocfs2_file_write_iter+0x19af/0x2180 fs/ocfs2/file.c:2469 new_sync_write fs/read_write.c:586 [inline] vfs_write+0xacf/0xd10 fs/read_write.c:679 ksys_write+0x18f/0x2b0 fs/read_write.c:731 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fbd97385d29 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fbd98152038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007fbd97575fa0 RCX: 00007fbd97385d29 RDX: 00000000000000a0 RSI: 00000000200002c0 RDI: 0000000000000004 RBP: 00007fbd97401b08 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fbd97575fa0 R15: 00007ffdd527f678