====================================================== WARNING: possible circular locking dependency detected 6.11.0-rc1-next-20240729-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.1922/13072 is trying to acquire lock: ffff8880628d3468 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline] ffff8880628d3468 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0x81d/0x1280 fs/ntfs3/file.c:619 but task is already holding lock: ffff8880628d38a0 (mapping.invalidate_lock#13){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:844 [inline] ffff8880628d38a0 (mapping.invalidate_lock#13){++++}-{3:3}, at: ntfs_fallocate+0x3c7/0x1280 fs/ntfs3/file.c:549 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (mapping.invalidate_lock#13){++++}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 filemap_invalidate_lock_shared include/linux/fs.h:854 [inline] filemap_fault+0x658/0x1760 mm/filemap.c:3302 __do_fault+0x135/0x460 mm/memory.c:4655 do_read_fault mm/memory.c:5061 [inline] do_fault mm/memory.c:5191 [inline] do_pte_missing mm/memory.c:3947 [inline] handle_pte_fault+0x3b18/0x6eb0 mm/memory.c:5522 __handle_mm_fault mm/memory.c:5665 [inline] handle_mm_fault+0x1029/0x1980 mm/memory.c:5833 do_user_addr_fault arch/x86/mm/fault.c:1389 [inline] handle_page_fault arch/x86/mm/fault.c:1481 [inline] exc_page_fault+0x2b9/0x8c0 arch/x86/mm/fault.c:1539 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623 fault_in_readable+0x165/0x2b0 fault_in_iov_iter_readable+0x229/0x280 lib/iov_iter.c:94 generic_perform_write+0x29f/0x840 mm/filemap.c:4009 ntfs_file_write_iter+0x663/0x740 fs/ntfs3/file.c:1193 aio_write+0x575/0x7d0 fs/aio.c:1633 io_submit_one+0x8a7/0x18b0 fs/aio.c:2052 __do_sys_io_submit fs/aio.c:2111 [inline] __se_sys_io_submit+0x179/0x2f0 fs/aio.c:2081 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 __might_fault+0xc6/0x120 mm/memory.c:6388 _inline_copy_to_user include/linux/uaccess.h:176 [inline] _copy_to_user+0x2a/0xb0 lib/usercopy.c:26 copy_to_user include/linux/uaccess.h:209 [inline] ni_fiemap+0x5b4/0x1910 fs/ntfs3/frecord.c:2140 ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1279 ioctl_fiemap fs/ioctl.c:220 [inline] do_vfs_ioctl+0x1c07/0x2e50 fs/ioctl.c:841 __do_sys_ioctl fs/ioctl.c:905 [inline] __se_sys_ioctl+0x81/0x170 fs/ioctl.c:893 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3158 [inline] check_prevs_add kernel/locking/lockdep.c:3277 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3901 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5199 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline] ntfs_fallocate+0x81d/0x1280 fs/ntfs3/file.c:619 vfs_fallocate+0x553/0x6c0 fs/open.c:334 ksys_fallocate fs/open.c:357 [inline] __do_sys_fallocate fs/open.c:365 [inline] __se_sys_fallocate fs/open.c:363 [inline] __x64_sys_fallocate+0xbd/0x110 fs/open.c:363 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &ni->ni_lock/4 --> &mm->mmap_lock --> mapping.invalidate_lock#13 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(mapping.invalidate_lock#13); lock(&mm->mmap_lock); lock(mapping.invalidate_lock#13); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz.1.1922/13072: #0: ffff8880550b8420 (sb_writers#14){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2876 [inline] #0: ffff8880550b8420 (sb_writers#14){.+.+}-{0:0}, at: vfs_fallocate+0x4ea/0x6c0 fs/open.c:333 #1: ffff8880628d3700 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:799 [inline] #1: ffff8880628d3700 (&sb->s_type->i_mutex_key#33){+.+.}-{3:3}, at: ntfs_fallocate+0x2e0/0x1280 fs/ntfs3/file.c:535 #2: ffff8880628d38a0 (mapping.invalidate_lock#13){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:844 [inline] #2: ffff8880628d38a0 (mapping.invalidate_lock#13){++++}-{3:3}, at: ntfs_fallocate+0x3c7/0x1280 fs/ntfs3/file.c:549 stack backtrace: CPU: 1 UID: 0 PID: 13072 Comm: syz.1.1922 Not tainted 6.11.0-rc1-next-20240729-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2203 check_prev_add kernel/locking/lockdep.c:3158 [inline] check_prevs_add kernel/locking/lockdep.c:3277 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3901 __lock_acquire+0x1384/0x2050 kernel/locking/lockdep.c:5199 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5822 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline] ntfs_fallocate+0x81d/0x1280 fs/ntfs3/file.c:619 vfs_fallocate+0x553/0x6c0 fs/open.c:334 ksys_fallocate fs/open.c:357 [inline] __do_sys_fallocate fs/open.c:365 [inline] __se_sys_fallocate fs/open.c:363 [inline] __x64_sys_fallocate+0xbd/0x110 fs/open.c:363 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fa0657779f9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fa066461048 EFLAGS: 00000246 ORIG_RAX: 000000000000011d RAX: ffffffffffffffda RBX: 00007fa065905f80 RCX: 00007fa0657779f9 RDX: 0000000000000000 RSI: 0000000000000008 RDI: 0000000000000004 RBP: 00007fa0657e58ee R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000007000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fa065905f80 R15: 00007ffeace924a8