====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc3-syzkaller-00044-g2ccbdf43d5e7 #0 Not tainted ------------------------------------------------------ syz-executor.0/6452 is trying to acquire lock: ffff888024334ae8 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xaa/0x670 fs/gfs2/quota.c:720 but task is already holding lock: ffff8880538ca0c8 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1529 [inline] ffff8880538ca0c8 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x271c/0x39c0 fs/gfs2/bmap.c:1853 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 __gfs2_iomap_get+0x17e/0x1480 fs/gfs2/bmap.c:859 gfs2_iomap_get+0xdf/0x160 fs/gfs2/bmap.c:1413 bh_get+0x26a/0x7e0 fs/gfs2/quota.c:417 qdsb_get+0x218/0x340 fs/gfs2/quota.c:566 gfs2_quota_hold+0x1a1/0x5d0 fs/gfs2/quota.c:646 punch_hole+0xe9d/0x39c0 fs/gfs2/bmap.c:1814 gfs2_iomap_end+0x515/0x6e0 fs/gfs2/bmap.c:1174 iomap_iter+0x220/0xf60 fs/iomap/iter.c:79 iomap_file_buffered_write+0x940/0xbd0 fs/iomap/buffered-io.c:1023 gfs2_file_buffered_write+0x4b7/0x840 fs/gfs2/file.c:1060 gfs2_file_write_iter+0x91c/0x1000 fs/gfs2/file.c:1164 new_sync_write fs/read_write.c:497 [inline] vfs_write+0xa72/0xc90 fs/read_write.c:590 ksys_write+0x1a0/0x2c0 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 do_qc+0xaa/0x670 fs/gfs2/quota.c:720 gfs2_quota_change+0x2e2/0x8d0 fs/gfs2/quota.c:1315 punch_hole+0x3355/0x39c0 fs/gfs2/bmap.c:1954 gfs2_iomap_end+0x515/0x6e0 fs/gfs2/bmap.c:1174 iomap_iter+0x220/0xf60 fs/iomap/iter.c:79 iomap_file_buffered_write+0x940/0xbd0 fs/iomap/buffered-io.c:1023 gfs2_file_buffered_write+0x4b7/0x840 fs/gfs2/file.c:1060 gfs2_file_write_iter+0x91c/0x1000 fs/gfs2/file.c:1164 new_sync_write fs/read_write.c:497 [inline] vfs_write+0xa72/0xc90 fs/read_write.c:590 ksys_write+0x1a0/0x2c0 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 5 locks held by syz-executor.0/6452: #0: ffff888061b6a420 (sb_writers#29){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2854 [inline] #0: ffff888061b6a420 (sb_writers#29){.+.+}-{0:0}, at: vfs_write+0x227/0xc90 fs/read_write.c:586 #1: ffff8880538c9c30 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:791 [inline] #1: ffff8880538c9c30 (&sb->s_type->i_mutex_key#36){+.+.}-{3:3}, at: gfs2_file_write_iter+0x32d/0x1000 fs/gfs2/file.c:1115 #2: ffff888061b6a610 (sb_internal#4){.+.+}-{0:0}, at: gfs2_trans_begin+0x71/0xe0 fs/gfs2/trans.c:118 #3: ffff888024335060 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x55d/0x950 fs/gfs2/trans.c:87 #4: ffff8880538ca0c8 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1529 [inline] #4: ffff8880538ca0c8 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x271c/0x39c0 fs/gfs2/bmap.c:1853 stack backtrace: CPU: 1 PID: 6452 Comm: syz-executor.0 Not tainted 6.10.0-rc3-syzkaller-00044-g2ccbdf43d5e7 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/07/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3869 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752 do_qc+0xaa/0x670 fs/gfs2/quota.c:720 gfs2_quota_change+0x2e2/0x8d0 fs/gfs2/quota.c:1315 punch_hole+0x3355/0x39c0 fs/gfs2/bmap.c:1954 gfs2_iomap_end+0x515/0x6e0 fs/gfs2/bmap.c:1174 iomap_iter+0x220/0xf60 fs/iomap/iter.c:79 iomap_file_buffered_write+0x940/0xbd0 fs/iomap/buffered-io.c:1023 gfs2_file_buffered_write+0x4b7/0x840 fs/gfs2/file.c:1060 gfs2_file_write_iter+0x91c/0x1000 fs/gfs2/file.c:1164 new_sync_write fs/read_write.c:497 [inline] vfs_write+0xa72/0xc90 fs/read_write.c:590 ksys_write+0x1a0/0x2c0 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fe321e7cea9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe322bec0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007fe321fb3f80 RCX: 00007fe321e7cea9 RDX: 000000000208e24b RSI: 0000000020000240 RDI: 0000000000000007 RBP: 00007fe321eebff4 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fe321fb3f80 R15: 00007fff5e1a1738