====================================================== WARNING: possible circular locking dependency detected 6.1.77-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/26949 is trying to acquire lock: ffff00011bb49698 (&ei->i_data_sem/1){+.+.}-{3:3}, at: ext4_double_down_write_data_sem+0x3c/0x4c but task is already holding lock: ffff0000e2ed5cd0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x30/0x4c which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&ei->i_data_sem/2){++++}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x2ac/0x1850 fs/ext4/inode.c:574 ext4_getblk+0x198/0x6ec fs/ext4/inode.c:866 ext4_bread+0x3c/0x1b0 fs/ext4/inode.c:922 ext4_quota_write+0x230/0x54c fs/ext4/super.c:7135 write_blk fs/quota/quota_tree.c:64 [inline] get_free_dqblk+0x28c/0x598 fs/quota/quota_tree.c:130 do_insert_tree+0x1fc/0x1474 fs/quota/quota_tree.c:340 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375 do_insert_tree+0x510/0x1474 fs/quota/quota_tree.c:375 dq_insert_tree fs/quota/quota_tree.c:401 [inline] qtree_write_dquot+0x318/0x488 fs/quota/quota_tree.c:420 v2_write_dquot+0xf4/0x188 fs/quota/quota_v2.c:358 dquot_acquire+0x2c4/0x5c4 fs/quota/dquot.c:470 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6769 dqget+0x660/0xcb4 fs/quota/dquot.c:984 __dquot_initialize+0x344/0xb54 fs/quota/dquot.c:1562 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1620 ext4_process_orphan+0x5c/0x2b8 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x974/0x1134 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5533 [inline] ext4_fill_super+0x6f04/0x7570 fs/ext4/super.c:5664 get_tree_bdev+0x360/0x54c fs/super.c:1355 ext4_get_tree+0x28/0x38 fs/ext4/super.c:5694 vfs_get_tree+0x90/0x274 fs/super.c:1562 do_new_mount+0x278/0x8fc fs/namespace.c:3051 path_mount+0x590/0xe5c fs/namespace.c:3381 do_mount fs/namespace.c:3394 [inline] __do_sys_mount fs/namespace.c:3602 [inline] __se_sys_mount fs/namespace.c:3579 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3579 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 v2_read_dquot+0x50/0x11c fs/quota/quota_v2.c:332 dquot_acquire+0x130/0x5c4 fs/quota/dquot.c:461 ext4_acquire_dquot+0x270/0x398 fs/ext4/super.c:6769 dqget+0x660/0xcb4 fs/quota/dquot.c:984 __dquot_initialize+0x344/0xb54 fs/quota/dquot.c:1562 dquot_initialize+0x24/0x34 fs/quota/dquot.c:1620 ext4_process_orphan+0x5c/0x2b8 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0x974/0x1134 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5533 [inline] ext4_fill_super+0x6f04/0x7570 fs/ext4/super.c:5664 get_tree_bdev+0x360/0x54c fs/super.c:1355 ext4_get_tree+0x28/0x38 fs/ext4/super.c:5694 vfs_get_tree+0x90/0x274 fs/super.c:1562 do_new_mount+0x278/0x8fc fs/namespace.c:3051 path_mount+0x590/0xe5c fs/namespace.c:3381 do_mount fs/namespace.c:3394 [inline] __do_sys_mount fs/namespace.c:3602 [inline] __se_sys_mount fs/namespace.c:3579 [inline] __arm64_sys_mount+0x45c/0x594 fs/namespace.c:3579 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 dquot_commit+0x54/0x240 fs/quota/dquot.c:505 ext4_write_dquot+0x1b0/0x284 fs/ext4/super.c:6753 ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6801 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty fs/quota/dquot.c:410 [inline] __dquot_alloc_space+0x47c/0xd00 fs/quota/dquot.c:1792 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] swap_inode_boot_loader fs/ext4/ioctl.c:494 [inline] __ext4_ioctl fs/ext4/ioctl.c:1424 [inline] ext4_ioctl+0x5c68/0x6afc fs/ext4/ioctl.c:1614 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&ei->i_data_sem/1){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write_nested+0x64/0x94 kernel/locking/rwsem.c:1689 ext4_double_down_write_data_sem+0x3c/0x4c swap_inode_boot_loader fs/ext4/ioctl.c:426 [inline] __ext4_ioctl fs/ext4/ioctl.c:1424 [inline] ext4_ioctl+0x4e78/0x6afc fs/ext4/ioctl.c:1614 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Chain exists of: &ei->i_data_sem/1 --> &s->s_dquot.dqio_sem --> &ei->i_data_sem/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ei->i_data_sem/2); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); lock(&ei->i_data_sem/1); *** DEADLOCK *** 5 locks held by syz-executor.1/26949: #0: ffff0000d8d8c460 (sb_writers#3){.+.+}-{0:0}, at: mnt_want_write_file+0x64/0x1e8 fs/namespace.c:437 #1: ffff0000e2ed5e48 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #1: ffff0000e2ed5e48 (&sb->s_type->i_mutex_key#9){++++}-{3:3}, at: lock_two_nondirectories+0xd4/0x120 fs/inode.c:1165 #2: ffff00011bb49810 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:791 [inline] #2: ffff00011bb49810 (&sb->s_type->i_mutex_key#9/4){+.+.}-{3:3}, at: lock_two_nondirectories+0xc4/0x120 fs/inode.c:1167 #3: ffff0000e2ed5fe8 (mapping.invalidate_lock){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:801 [inline] #3: ffff0000e2ed5fe8 (mapping.invalidate_lock){++++}-{3:3}, at: swap_inode_boot_loader fs/ext4/ioctl.c:402 [inline] #3: ffff0000e2ed5fe8 (mapping.invalidate_lock){++++}-{3:3}, at: __ext4_ioctl fs/ext4/ioctl.c:1424 [inline] #3: ffff0000e2ed5fe8 (mapping.invalidate_lock){++++}-{3:3}, at: ext4_ioctl+0x4950/0x6afc fs/ext4/ioctl.c:1614 #4: ffff0000e2ed5cd0 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_double_down_write_data_sem+0x30/0x4c stack backtrace: CPU: 0 PID: 26949 Comm: syz-executor.1 Not tainted 6.1.77-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 down_write_nested+0x64/0x94 kernel/locking/rwsem.c:1689 ext4_double_down_write_data_sem+0x3c/0x4c swap_inode_boot_loader fs/ext4/ioctl.c:426 [inline] __ext4_ioctl fs/ext4/ioctl.c:1424 [inline] ext4_ioctl+0x4e78/0x6afc fs/ext4/ioctl.c:1614 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:870 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0x14c/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585