====================================================== WARNING: possible circular locking dependency detected 6.6.0-rc3-syzkaller-00165-g3b517966c561 #0 Not tainted ------------------------------------------------------ syz-executor.4/7957 is trying to acquire lock: ffff888079efc0e0 (&type->s_umount_key#31){++++}-{3:3}, at: __super_lock fs/super.c:58 [inline] ffff888079efc0e0 (&type->s_umount_key#31){++++}-{3:3}, at: super_lock+0x23c/0x380 fs/super.c:117 but task is already holding lock: ffff88801b124608 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_flushbuf block/ioctl.c:370 [inline] ffff88801b124608 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_common_ioctl+0x14e9/0x1ce0 block/ioctl.c:502 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #4 (&bdev->bd_holder_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 bd_finish_claiming block/bdev.c:566 [inline] blkdev_get_by_dev.part.0+0x374/0xb20 block/bdev.c:799 blkdev_get_by_dev+0x75/0x80 block/bdev.c:829 setup_bdev_super+0x78/0x6f0 fs/super.c:1484 mount_bdev+0x1c0/0x2e0 fs/super.c:1626 legacy_get_tree+0x109/0x220 fs/fs_context.c:638 vfs_get_tree+0x8c/0x370 fs/super.c:1750 do_new_mount fs/namespace.c:3335 [inline] path_mount+0x1492/0x1ed0 fs/namespace.c:3662 init_mount+0xbf/0x110 fs/init.c:25 do_mount_root+0xdd/0x2c0 init/do_mounts.c:166 mount_root_generic+0x19a/0x460 init/do_mounts.c:205 mount_block_root init/do_mounts.c:378 [inline] mount_root+0x241/0x480 init/do_mounts.c:405 prepare_namespace+0xe3/0x3f0 init/do_mounts.c:489 kernel_init_freeable+0x703/0x900 init/main.c:1560 kernel_init+0x1c/0x2a0 init/main.c:1437 ret_from_fork+0x45/0x80 arch/x86/kernel/process.c:147 ret_from_fork_asm+0x11/0x20 arch/x86/entry/entry_64.S:304 -> #3 (bdev_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x181/0x1340 kernel/locking/mutex.c:747 bd_prepare_to_claim+0x1a4/0x280 block/bdev.c:508 truncate_bdev_range+0x48/0x270 block/bdev.c:105 blkdev_fallocate+0x201/0x3e0 block/fops.c:776 vfs_fallocate+0x46c/0xe80 fs/open.c:324 ksys_fallocate fs/open.c:347 [inline] __do_sys_fallocate fs/open.c:355 [inline] __se_sys_fallocate fs/open.c:353 [inline] __x64_sys_fallocate+0xd5/0x140 fs/open.c:353 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #2 (mapping.invalidate_lock#2){++++}-{3:3}: down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 filemap_invalidate_lock_shared include/linux/fs.h:857 [inline] filemap_fault+0x28c/0x3550 mm/filemap.c:3283 __do_fault+0x107/0x600 mm/memory.c:4204 do_shared_fault mm/memory.c:4635 [inline] do_fault mm/memory.c:4709 [inline] do_pte_missing mm/memory.c:3669 [inline] handle_pte_fault mm/memory.c:4978 [inline] __handle_mm_fault+0x2594/0x3e10 mm/memory.c:5119 handle_mm_fault+0x478/0xa00 mm/memory.c:5284 do_user_addr_fault+0x3d1/0x1000 arch/x86/mm/fault.c:1413 handle_page_fault arch/x86/mm/fault.c:1505 [inline] exc_page_fault+0x5c/0xd0 arch/x86/mm/fault.c:1561 asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:570 -> #1 (&mm->mmap_lock){++++}-{3:3}: __might_fault mm/memory.c:5896 [inline] __might_fault+0x11f/0x1a0 mm/memory.c:5889 _copy_from_user+0x2b/0xf0 lib/usercopy.c:14 copy_from_user include/linux/uaccess.h:183 [inline] quota_setquota+0x265/0x5e0 fs/quota/quota.c:301 do_quotactl+0xb01/0x13d0 fs/quota/quota.c:802 __do_sys_quotactl fs/quota/quota.c:961 [inline] __se_sys_quotactl fs/quota/quota.c:917 [inline] __x64_sys_quotactl+0x1b4/0x440 fs/quota/quota.c:917 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&type->s_umount_key#31){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 __super_lock fs/super.c:58 [inline] super_lock+0x23c/0x380 fs/super.c:117 super_lock_shared fs/super.c:146 [inline] super_lock_shared_active fs/super.c:1431 [inline] fs_bdev_sync+0x94/0x1b0 fs/super.c:1466 blkdev_flushbuf block/ioctl.c:372 [inline] blkdev_common_ioctl+0x1550/0x1ce0 block/ioctl.c:502 blkdev_ioctl+0x249/0x770 block/ioctl.c:624 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Chain exists of: &type->s_umount_key#31 --> bdev_lock --> &bdev->bd_holder_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&bdev->bd_holder_lock); lock(bdev_lock); lock(&bdev->bd_holder_lock); rlock(&type->s_umount_key#31); *** DEADLOCK *** 1 lock held by syz-executor.4/7957: #0: ffff88801b124608 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_flushbuf block/ioctl.c:370 [inline] #0: ffff88801b124608 (&bdev->bd_holder_lock){+.+.}-{3:3}, at: blkdev_common_ioctl+0x14e9/0x1ce0 block/ioctl.c:502 stack backtrace: CPU: 0 PID: 7957 Comm: syz-executor.4 Not tainted 6.6.0-rc3-syzkaller-00165-g3b517966c561 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/06/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x311/0x3f0 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3868 [inline] __lock_acquire+0x2e3d/0x5de0 kernel/locking/lockdep.c:5136 lock_acquire kernel/locking/lockdep.c:5753 [inline] lock_acquire+0x1ae/0x510 kernel/locking/lockdep.c:5718 down_read+0x9c/0x470 kernel/locking/rwsem.c:1520 __super_lock fs/super.c:58 [inline] super_lock+0x23c/0x380 fs/super.c:117 super_lock_shared fs/super.c:146 [inline] super_lock_shared_active fs/super.c:1431 [inline] fs_bdev_sync+0x94/0x1b0 fs/super.c:1466 blkdev_flushbuf block/ioctl.c:372 [inline] blkdev_common_ioctl+0x1550/0x1ce0 block/ioctl.c:502 blkdev_ioctl+0x249/0x770 block/ioctl.c:624 vfs_ioctl fs/ioctl.c:51 [inline] __do_sys_ioctl fs/ioctl.c:871 [inline] __se_sys_ioctl fs/ioctl.c:857 [inline] __x64_sys_ioctl+0x18f/0x210 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f4354e7cae9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f43539fe0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 RAX: ffffffffffffffda RBX: 00007f4354f9bf80 RCX: 00007f4354e7cae9 RDX: 0000000000000000 RSI: 0000000000001261 RDI: 0000000000000003 RBP: 00007f4354ec847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f4354f9bf80 R15: 00007ffe07fc28e8