ntfs3: loop1: Mark volume as dirty due to NTFS errors ====================================================== WARNING: possible circular locking dependency detected 6.1.92-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.1/5442 is trying to acquire lock: ffff888070dbefa0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline] ffff888070dbefa0 (&ni->ni_lock/4){+.+.}-{3:3}, at: mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 but task is already holding lock: ffff888058794360 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1114 [inline] ffff888058794360 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x16b/0x1070 fs/ntfs3/frecord.c:3252 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:920 ntfs_iget5+0x581/0x3920 fs/ntfs3/inode.c:531 dir_search_u+0x2f6/0x390 fs/ntfs3/dir.c:264 ntfs_lookup+0x102/0x1f0 fs/ntfs3/namei.c:83 __lookup_slow+0x27e/0x3d0 fs/namei.c:1690 lookup_slow+0x53/0x70 fs/namei.c:1707 walk_component+0x2d0/0x400 fs/namei.c:1998 lookup_last fs/namei.c:2455 [inline] path_lookupat+0x16f/0x450 fs/namei.c:2479 filename_lookup+0x251/0x600 fs/namei.c:2508 user_path_at_empty+0x3e/0x60 fs/namei.c:2907 user_path_at include/linux/namei.h:57 [inline] __do_sys_chdir fs/open.c:514 [inline] __se_sys_chdir+0xbb/0x220 fs/open.c:508 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline] mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x48a/0x3920 fs/ntfs3/inode.c:524 ni_update_parent+0x93f/0xdc0 fs/ntfs3/frecord.c:3208 ni_write_inode+0xe34/0x1070 fs/ntfs3/frecord.c:3306 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x67d/0x11e0 fs/fs-writeback.c:1677 writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1733 sync_inode_metadata+0xc8/0x130 fs/fs-writeback.c:2789 __generic_file_fsync+0x13b/0x190 fs/libfs.c:1143 generic_file_fsync+0x6f/0xe0 fs/libfs.c:1173 generic_write_sync include/linux/fs.h:2957 [inline] ntfs_file_write_iter+0x5c2/0x6d0 fs/ntfs3/file.c:1172 do_iter_write+0x6e6/0xc50 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x216/0x360 fs/read_write.c:1031 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz-executor.1/5442: #0: ffff888054eae460 (sb_writers#22){.+.+}-{0:0}, at: vfs_writev fs/read_write.c:933 [inline] #0: ffff888054eae460 (sb_writers#22){.+.+}-{0:0}, at: do_pwritev+0x1fa/0x360 fs/read_write.c:1031 #1: ffff888058794600 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff888058794600 (&sb->s_type->i_mutex_key#29){+.+.}-{3:3}, at: __generic_file_fsync+0x96/0x190 fs/libfs.c:1136 #2: ffff888058794360 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1114 [inline] #2: ffff888058794360 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x16b/0x1070 fs/ntfs3/frecord.c:3252 stack backtrace: CPU: 1 PID: 5442 Comm: syz-executor.1 Not tainted 6.1.92-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 04/02/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1099 [inline] mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x48a/0x3920 fs/ntfs3/inode.c:524 ni_update_parent+0x93f/0xdc0 fs/ntfs3/frecord.c:3208 ni_write_inode+0xe34/0x1070 fs/ntfs3/frecord.c:3306 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x67d/0x11e0 fs/fs-writeback.c:1677 writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1733 sync_inode_metadata+0xc8/0x130 fs/fs-writeback.c:2789 __generic_file_fsync+0x13b/0x190 fs/libfs.c:1143 generic_file_fsync+0x6f/0xe0 fs/libfs.c:1173 generic_write_sync include/linux/fs.h:2957 [inline] ntfs_file_write_iter+0x5c2/0x6d0 fs/ntfs3/file.c:1172 do_iter_write+0x6e6/0xc50 fs/read_write.c:861 vfs_writev fs/read_write.c:934 [inline] do_pwritev+0x216/0x360 fs/read_write.c:1031 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7fc0d6c7cee9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fc0d7a720c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000148 RAX: ffffffffffffffda RBX: 00007fc0d6db3f80 RCX: 00007fc0d6c7cee9 RDX: 0000000000000001 RSI: 0000000020000000 RDI: 0000000000000004 RBP: 00007fc0d6cda6fe R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007fc0d6db3f80 R15: 00007fff56388438 ntfs3: loop1: ino=1e, "file1" failed to open parent directory r=30005 to update