hfsplus: inconsistency in B*Tree (128,1,255,1,0) hfsplus: xattr search failed ====================================================== WARNING: possible circular locking dependency detected 6.10.0-rc7-syzkaller-gc912bf709078 #0 Not tainted ------------------------------------------------------ syz.4.246/8298 is trying to acquire lock: ffff0000c83860b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 but task is already holding lock: ffff0000e1e5b708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x250/0x9b8 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 hfsplus_file_extend+0x1d0/0x1544 fs/hfsplus/extents.c:457 hfsplus_bmap_reserve+0xec/0x474 fs/hfsplus/btree.c:358 hfsplus_rename_cat+0x1ac/0xf08 fs/hfsplus/catalog.c:456 hfsplus_rename+0x120/0x1b0 fs/hfsplus/dir.c:552 vfs_rename+0x9bc/0xc84 fs/namei.c:4940 do_renameat2+0x9c8/0xe40 fs/namei.c:5097 __do_sys_renameat2 fs/namei.c:5131 [inline] __se_sys_renameat2 fs/namei.c:5128 [inline] __arm64_sys_renameat2+0xe0/0xfc fs/namei.c:5128 __invoke_syscall arch/arm64/kernel/syscall.c:34 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:48 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:131 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:150 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:712 el0t_64_sync_handler+0x84/0xfc arch/arm64/kernel/entry-common.c:730 el0t_64_sync+0x190/0x194 arch/arm64/kernel/entry.S:598 -> #0 (&tree->tree_lock#2){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5754 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 hfsplus_file_release+0x2a0/0x3a0 fs/hfsplus/inode.c:238 __fput+0x1bc/0x774 fs/file_table.c:422 ____fput+0x20/0x30 fs/file_table.c:450 task_work_run+0x230/0x2e0 kernel/task_work.c:180 exit_task_work include/linux/task_work.h:38 [inline] do_exit+0x4e4/0x1ac8 kernel/exit.c:876 do_group_exit+0x194/0x22c kernel/exit.c:1025 get_signal+0x1414/0x1530 kernel/signal.c:2909 do_signal+0x238/0x2924 arch/arm64/kernel/signal.c:1308 do_notify_resume+0x74/0x1f4 arch/arm64/kernel/entry-common.c:148 exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline] asm_exit_to_user_mode+0x78/0x8c arch/arm64/kernel/entry-common.c:185 ret_from_fork+0x1c/0x20 arch/arm64/kernel/entry.S:863 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2); lock(&HFSPLUS_I(inode)->extents_lock); lock(&tree->tree_lock#2); *** DEADLOCK *** 2 locks held by syz.4.246/8298: #0: ffff0000e1e5b900 (&sb->s_type->i_mutex_key#30){++++}-{3:3}, at: inode_lock include/linux/fs.h:791 [inline] #0: ffff0000e1e5b900 (&sb->s_type->i_mutex_key#30){++++}-{3:3}, at: hfsplus_file_release+0xe0/0x3a0 fs/hfsplus/inode.c:233 #1: ffff0000e1e5b708 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_truncate+0x250/0x9b8 fs/hfsplus/extents.c:576 stack backtrace: CPU: 0 PID: 8298 Comm: syz.4.246 Not tainted 6.10.0-rc7-syzkaller-gc912bf709078 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024 Call trace: dump_backtrace+0x1b8/0x1e4 arch/arm64/kernel/stacktrace.c:317 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:324 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:114 dump_stack+0x1c/0x28 lib/dump_stack.c:123 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2060 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x3384/0x763c kernel/locking/lockdep.c:5137 lock_acquire+0x240/0x728 kernel/locking/lockdep.c:5754 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:608 __mutex_lock kernel/locking/mutex.c:752 [inline] mutex_lock_nested+0x2c/0x38 kernel/locking/mutex.c:804 hfsplus_file_truncate+0x6d0/0x9b8 fs/hfsplus/extents.c:595 hfsplus_file_release+0x2a0/0x3a0 fs/hfsplus/inode.c:238 __fput+0x1bc/0x774 fs/file_table.c:422 ____fput+0x20/0x30 fs/file_table.c:450 task_work_run+0x230/0x2e0 kernel/task_work.c:180 exit_task_work include/linux/task_work.h:38 [inline] do_exit+0x4e4/0x1ac8 kernel/exit.c:876 do_group_exit+0x194/0x22c kernel/exit.c:1025 get_signal+0x1414/0x1530 kernel/signal.c:2909 do_signal+0x238/0x2924 arch/arm64/kernel/signal.c:1308 do_notify_resume+0x74/0x1f4 arch/arm64/kernel/entry-common.c:148 exit_to_user_mode_prepare arch/arm64/kernel/entry-common.c:169 [inline] exit_to_user_mode arch/arm64/kernel/entry-common.c:178 [inline] asm_exit_to_user_mode+0x78/0x8c arch/arm64/kernel/entry-common.c:185 ret_from_fork+0x1c/0x20 arch/arm64/kernel/entry.S:863