======================================================
WARNING: possible circular locking dependency detected
6.1.115-syzkaller #0 Not tainted
------------------------------------------------------
syz.3.2596/10315 is trying to acquire lock:
ffff0000f12b2648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
ffff0000f12b2648 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}, at: ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635

but task is already holding lock:
ffff0000f127bf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314
       ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811
       dqget+0x660/0xcec fs/quota/dquot.c:986
       dquot_set_dqblk+0x40/0xea8 fs/quota/dquot.c:2831
       quota_setquota+0x5bc/0x6f0 fs/quota/quota.c:310
       do_quotactl+0x508/0x698 fs/quota/quota.c:802
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl fs/quota/quota.c:916 [inline]
       __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
       ocfs2_acquire_dquot+0x27c/0xb1c fs/ocfs2/quota_global.c:811
       dqget+0x660/0xcec fs/quota/dquot.c:986
       dquot_set_dqblk+0x40/0xea8 fs/quota/dquot.c:2831
       quota_setquota+0x5bc/0x6f0 fs/quota/quota.c:310
       do_quotactl+0x508/0x698 fs/quota/quota.c:802
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl fs/quota/quota.c:916 [inline]
       __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #5 (&dquot->dq_lock){+.+.}-{3:3}:
       __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603
       __mutex_lock kernel/locking/mutex.c:747 [inline]
       mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799
       dquot_commit+0x54/0x240 fs/quota/dquot.c:507
       ext4_write_dquot+0x1b4/0x314 fs/ext4/super.c:6777
       ext4_mark_dquot_dirty+0xe8/0x140 fs/ext4/super.c:6837
       mark_dquot_dirty fs/quota/dquot.c:372 [inline]
       mark_all_dquot_dirty+0x108/0x424 fs/quota/dquot.c:412
       __dquot_free_space+0x840/0xce4 fs/quota/dquot.c:1940
       dquot_free_space_nodirty include/linux/quotaops.h:379 [inline]
       dquot_free_space include/linux/quotaops.h:384 [inline]
       dquot_free_block include/linux/quotaops.h:395 [inline]
       ext4_mb_clear_bb fs/ext4/mballoc.c:6143 [inline]
       ext4_free_blocks+0x1b14/0x2b64 fs/ext4/mballoc.c:6273
       ext4_remove_blocks fs/ext4/extents.c:2525 [inline]
       ext4_ext_rm_leaf fs/ext4/extents.c:2691 [inline]
       ext4_ext_remove_space+0x1bd0/0x4544 fs/ext4/extents.c:2939
       ext4_ext_truncate+0x168/0x210 fs/ext4/extents.c:4469
       ext4_truncate+0xa08/0x1178 fs/ext4/inode.c:4288
       ext4_evict_inode+0xc3c/0x12cc fs/ext4/inode.c:286
       evict+0x418/0x894 fs/inode.c:701
       iput_final fs/inode.c:1830 [inline]
       iput+0x7c0/0x8a4 fs/inode.c:1856
       do_unlinkat+0x530/0x70c fs/namei.c:4397
       __do_sys_unlinkat fs/namei.c:4433 [inline]
       __se_sys_unlinkat fs/namei.c:4426 [inline]
       __arm64_sys_unlinkat+0xcc/0xfc fs/namei.c:4426
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #4 (&ei->i_data_sem){++++}-{3:3}:
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       ext4_truncate+0x7e0/0x1178 fs/ext4/inode.c:4283
       ext4_setattr+0xda0/0x14e8 fs/ext4/inode.c:5601
       notify_change+0xb58/0xe1c fs/attr.c:499
       do_truncate+0x1c0/0x28c fs/open.c:65
       do_sys_ftruncate+0x288/0x31c fs/open.c:193
       __do_sys_ftruncate fs/open.c:204 [inline]
       __se_sys_ftruncate fs/open.c:202 [inline]
       __arm64_sys_ftruncate+0x60/0x74 fs/open.c:202
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #3 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0x1140/0x13ac fs/jbd2/transaction.c:463
       jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:520
       jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:559
       ocfs2_start_trans+0x3e8/0x73c fs/ocfs2/journal.c:354
       ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359
       ocfs2_create+0x1a8/0x560 fs/ocfs2/namei.c:672
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0xeac/0x2548 fs/namei.c:3780
       do_filp_open+0x1bc/0x3cc fs/namei.c:3810
       do_sys_openat2+0x128/0x3e0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #2 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0x64/0x308 kernel/locking/rwsem.c:1520
       ocfs2_start_trans+0x3dc/0x73c fs/ocfs2/journal.c:352
       ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359
       ocfs2_create+0x1a8/0x560 fs/ocfs2/namei.c:672
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0xeac/0x2548 fs/namei.c:3780
       do_filp_open+0x1bc/0x3cc fs/namei.c:3810
       do_sys_openat2+0x128/0x3e0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #1 (sb_internal#5){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1891 [inline]
       sb_start_intwrite include/linux/fs.h:2013 [inline]
       ocfs2_start_trans+0x260/0x73c fs/ocfs2/journal.c:350
       ocfs2_mknod+0xe64/0x2560 fs/ocfs2/namei.c:359
       ocfs2_create+0x1a8/0x560 fs/ocfs2/namei.c:672
       lookup_open fs/namei.c:3482 [inline]
       open_last_lookups fs/namei.c:3550 [inline]
       path_openat+0xeac/0x2548 fs/namei.c:3780
       do_filp_open+0x1bc/0x3cc fs/namei.c:3810
       do_sys_openat2+0x128/0x3e0 fs/open.c:1318
       do_sys_open fs/open.c:1334 [inline]
       __do_sys_openat fs/open.c:1350 [inline]
       __se_sys_openat fs/open.c:1345 [inline]
       __arm64_sys_openat+0x1f0/0x240 fs/open.c:1345
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3090 [inline]
       check_prevs_add kernel/locking/lockdep.c:3209 [inline]
       validate_chain kernel/locking/lockdep.c:3825 [inline]
       __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
       lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
       down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
       inode_lock include/linux/fs.h:758 [inline]
       ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635
       ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
       ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
       ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
       ocfs2_extend_allocation+0x474/0x1a04 fs/ocfs2/file.c:585
       ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027
       ocfs2_acquire_dquot+0x620/0xb1c fs/ocfs2/quota_global.c:836
       dqget+0x660/0xcec fs/quota/dquot.c:986
       dquot_set_dqblk+0x40/0xea8 fs/quota/dquot.c:2831
       quota_setquota+0x5bc/0x6f0 fs/quota/quota.c:310
       do_quotactl+0x508/0x698 fs/quota/quota.c:802
       __do_sys_quotactl fs/quota/quota.c:960 [inline]
       __se_sys_quotactl fs/quota/quota.c:916 [inline]
       __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
       do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
       el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
       el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
       el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);

 *** DEADLOCK ***

4 locks held by syz.3.2596/10315:
 #0: ffff0000dcb000e0 (&type->s_umount_key#96){++++}-{3:3}, at: user_get_super+0x11c/0x240 fs/super.c:889
 #1: ffff0000f12f60a8 (&dquot->dq_lock){+.+.}-{3:3}, at: ocfs2_acquire_dquot+0x270/0xb1c fs/ocfs2/quota_global.c:806
 #2: ffff0000f127c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline]
 #2: ffff0000f127c2c8 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{3:3}, at: ocfs2_lock_global_qf+0x1b8/0x260 fs/ocfs2/quota_global.c:313
 #3: ffff0000f127bf60 (&ocfs2_quota_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_lock_global_qf+0x1d4/0x260 fs/ocfs2/quota_global.c:314

stack backtrace:
CPU: 0 PID: 10315 Comm: syz.3.2596 Not tainted 6.1.115-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024
Call trace:
 dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106
 dump_stack+0x1c/0x58 lib/dump_stack.c:113
 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048
 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170
 check_prev_add kernel/locking/lockdep.c:3090 [inline]
 check_prevs_add kernel/locking/lockdep.c:3209 [inline]
 validate_chain kernel/locking/lockdep.c:3825 [inline]
 __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049
 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662
 down_write+0x5c/0x88 kernel/locking/rwsem.c:1573
 inode_lock include/linux/fs.h:758 [inline]
 ocfs2_reserve_local_alloc_bits+0xfc/0x25dc fs/ocfs2/localalloc.c:635
 ocfs2_reserve_clusters_with_limit+0x194/0xabc fs/ocfs2/suballoc.c:1162
 ocfs2_reserve_clusters fs/ocfs2/suballoc.c:1223 [inline]
 ocfs2_lock_allocators+0x294/0x584 fs/ocfs2/suballoc.c:2669
 ocfs2_extend_allocation+0x474/0x1a04 fs/ocfs2/file.c:585
 ocfs2_extend_no_holes+0x1b0/0x45c fs/ocfs2/file.c:1027
 ocfs2_acquire_dquot+0x620/0xb1c fs/ocfs2/quota_global.c:836
 dqget+0x660/0xcec fs/quota/dquot.c:986
 dquot_set_dqblk+0x40/0xea8 fs/quota/dquot.c:2831
 quota_setquota+0x5bc/0x6f0 fs/quota/quota.c:310
 do_quotactl+0x508/0x698 fs/quota/quota.c:802
 __do_sys_quotactl fs/quota/quota.c:960 [inline]
 __se_sys_quotactl fs/quota/quota.c:916 [inline]
 __arm64_sys_quotactl+0x2d8/0x7a0 fs/quota/quota.c:916
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:140
 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:204
 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637
 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655
 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585