====================================================== WARNING: possible circular locking dependency detected 6.2.0-syzkaller-13534-gb01fe98d34f3 #0 Not tainted ------------------------------------------------------ ksoftirqd/2/25 is trying to acquire lock: ffff888022cf90d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff888022cf90d0 (&priv->j1939_socks_lock){+.-.}-{2:2}, at: j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 but task is already holding lock: ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_cancel net/can/j1939/transport.c:1134 [inline] ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_xtp_rx_cts_one net/can/j1939/transport.c:1464 [inline] ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_xtp_rx_cts+0x28e/0x11b0 net/can/j1939/transport.c:1477 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&priv->active_session_list_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_session_list_lock net/can/j1939/transport.c:238 [inline] j1939_session_activate+0x47/0x4b0 net/can/j1939/transport.c:1557 j1939_sk_queue_activate_next_locked net/can/j1939/socket.c:181 [inline] j1939_sk_queue_activate_next+0x2bf/0x4d0 net/can/j1939/socket.c:208 j1939_simple_txnext net/can/j1939/transport.c:1060 [inline] j1939_tp_txtimer+0x1653/0x2be0 net/can/j1939/transport.c:1153 __run_hrtimer kernel/time/hrtimer.c:1685 [inline] __hrtimer_run_queues+0x690/0x1010 kernel/time/hrtimer.c:1749 hrtimer_run_softirq+0x17f/0x360 kernel/time/hrtimer.c:1766 __do_softirq+0x2e3/0xae3 kernel/softirq.c:571 run_ksoftirqd kernel/softirq.c:934 [inline] run_ksoftirqd+0x31/0x60 kernel/softirq.c:926 smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 -> #1 (&jsk->sk_session_queue_lock){+.-.}-{2:2}: __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_queue_drop_all+0x3b/0x2f0 net/can/j1939/socket.c:139 j1939_sk_netdev_event_netdown+0x7f/0x160 net/can/j1939/socket.c:1275 j1939_netdev_notify+0x19d/0x1d0 net/can/j1939/main.c:379 notifier_call_chain+0xb5/0x200 kernel/notifier.c:87 call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1937 call_netdevice_notifiers_extack net/core/dev.c:1975 [inline] call_netdevice_notifiers net/core/dev.c:1989 [inline] __dev_notify_flags+0x1ea/0x2d0 net/core/dev.c:8568 dev_change_flags+0x11b/0x170 net/core/dev.c:8604 do_setlink+0x9f4/0x3d30 net/core/rtnetlink.c:2833 __rtnl_newlink+0xd69/0x1840 net/core/rtnetlink.c:3623 rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3670 rtnetlink_rcv_msg+0x43d/0xd50 net/core/rtnetlink.c:6174 netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2574 netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline] netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365 netlink_sendmsg+0x925/0xe30 net/netlink/af_netlink.c:1942 sock_sendmsg_nosec net/socket.c:722 [inline] sock_sendmsg+0xde/0x190 net/socket.c:745 ____sys_sendmsg+0x71c/0x900 net/socket.c:2504 ___sys_sendmsg+0x110/0x1b0 net/socket.c:2558 __sys_sendmsg+0xf7/0x1c0 net/socket.c:2587 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (&priv->j1939_socks_lock){+.-.}-{2:2}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1128 j1939_session_cancel net/can/j1939/transport.c:1139 [inline] j1939_xtp_rx_cts_one net/can/j1939/transport.c:1464 [inline] j1939_xtp_rx_cts+0xabc/0x11b0 net/can/j1939/transport.c:1477 j1939_tp_cmd_recv net/can/j1939/transport.c:2062 [inline] j1939_tp_recv+0xd58/0xf50 net/can/j1939/transport.c:2137 j1939_can_recv net/can/j1939/main.c:112 [inline] j1939_can_recv+0x78e/0xa80 net/can/j1939/main.c:38 deliver net/can/af_can.c:572 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:606 can_receive+0x31d/0x5c0 net/can/af_can.c:663 can_rcv+0x1e1/0x280 net/can/af_can.c:687 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5479 __netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5593 process_backlog+0x279/0x850 net/core/dev.c:5921 __napi_poll+0xb8/0x870 net/core/dev.c:6482 napi_poll net/core/dev.c:6549 [inline] net_rx_action+0x9fd/0xdc0 net/core/dev.c:6659 __do_softirq+0x2e3/0xae3 kernel/softirq.c:571 run_ksoftirqd kernel/softirq.c:934 [inline] run_ksoftirqd+0x31/0x60 kernel/softirq.c:926 smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 other info that might help us debug this: Chain exists of: &priv->j1939_socks_lock --> &jsk->sk_session_queue_lock --> &priv->active_session_list_lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&priv->active_session_list_lock); lock(&jsk->sk_session_queue_lock); lock(&priv->active_session_list_lock); lock(&priv->j1939_socks_lock); *** DEADLOCK *** 3 locks held by ksoftirqd/2/25: #0: ffffffff8c792a40 (rcu_read_lock){....}-{1:2}, at: __skb_unlink include/linux/skbuff.h:2341 [inline] #0: ffffffff8c792a40 (rcu_read_lock){....}-{1:2}, at: __skb_dequeue include/linux/skbuff.h:2356 [inline] #0: ffffffff8c792a40 (rcu_read_lock){....}-{1:2}, at: process_backlog+0x3b7/0x850 net/core/dev.c:5919 #1: ffffffff8c792a40 (rcu_read_lock){....}-{1:2}, at: can_receive+0x1ef/0x5c0 net/can/af_can.c:653 #2: ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:355 [inline] #2: ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_list_lock net/can/j1939/transport.c:238 [inline] #2: ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_session_cancel net/can/j1939/transport.c:1134 [inline] #2: ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_xtp_rx_cts_one net/can/j1939/transport.c:1464 [inline] #2: ffff888022cf9088 (&priv->active_session_list_lock){+.-.}-{2:2}, at: j1939_xtp_rx_cts+0x28e/0x11b0 net/can/j1939/transport.c:1477 stack backtrace: CPU: 2 PID: 25 Comm: ksoftirqd/2 Not tainted 6.2.0-syzkaller-13534-gb01fe98d34f3 #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x2ec7/0x5d40 kernel/locking/lockdep.c:5056 lock_acquire kernel/locking/lockdep.c:5669 [inline] lock_acquire+0x1e3/0x670 kernel/locking/lockdep.c:5634 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline] _raw_spin_lock_bh+0x33/0x40 kernel/locking/spinlock.c:178 spin_lock_bh include/linux/spinlock.h:355 [inline] j1939_sk_errqueue+0xa3/0x1a0 net/can/j1939/socket.c:1081 __j1939_session_cancel+0x3b9/0x460 net/can/j1939/transport.c:1128 j1939_session_cancel net/can/j1939/transport.c:1139 [inline] j1939_xtp_rx_cts_one net/can/j1939/transport.c:1464 [inline] j1939_xtp_rx_cts+0xabc/0x11b0 net/can/j1939/transport.c:1477 j1939_tp_cmd_recv net/can/j1939/transport.c:2062 [inline] j1939_tp_recv+0xd58/0xf50 net/can/j1939/transport.c:2137 j1939_can_recv net/can/j1939/main.c:112 [inline] j1939_can_recv+0x78e/0xa80 net/can/j1939/main.c:38 deliver net/can/af_can.c:572 [inline] can_rcv_filter+0x5d4/0x8d0 net/can/af_can.c:606 can_receive+0x31d/0x5c0 net/can/af_can.c:663 can_rcv+0x1e1/0x280 net/can/af_can.c:687 __netif_receive_skb_one_core+0x114/0x180 net/core/dev.c:5479 __netif_receive_skb+0x1f/0x1c0 net/core/dev.c:5593 process_backlog+0x279/0x850 net/core/dev.c:5921 __napi_poll+0xb8/0x870 net/core/dev.c:6482 napi_poll net/core/dev.c:6549 [inline] net_rx_action+0x9fd/0xdc0 net/core/dev.c:6659 __do_softirq+0x2e3/0xae3 kernel/softirq.c:571 run_ksoftirqd kernel/softirq.c:934 [inline] run_ksoftirqd+0x31/0x60 kernel/softirq.c:926 smpboot_thread_fn+0x659/0xa20 kernel/smpboot.c:164 kthread+0x2e8/0x3a0 kernel/kthread.c:376 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 vxcan1: j1939_xtp_rx_abort_one: 0xffff888023ea7000: 0x00000: (8) Duplicate sequence number (and software is not able to recover) vxcan1: j1939_xtp_rx_abort_one: 0xffff8880259ce400: 0x00000: (8) Duplicate sequence number (and software is not able to recover) vxcan0: j1939_tp_rxtimer: 0xffff888023ea7400: abort rx timeout. Force session deactivation vxcan1: j1939_xtp_rx_abort_one: 0xffff88801aa36000: 0x00000: (8) Duplicate sequence number (and software is not able to recover) vxcan1: j1939_xtp_rx_abort_one: 0xffff88802af51000: 0x00000: (8) Duplicate sequence number (and software is not able to recover) vxcan0: j1939_xtp_rx_abort_one: 0xffff888029ef1400: 0x00000: (8) Duplicate sequence number (and software is not able to recover)