====================================================== WARNING: possible circular locking dependency detected 4.19.211-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.4/31007 is trying to acquire lock: 00000000f7821a6e (&sbi->alloc_mutex){+.+.}, at: hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182 but task is already holding lock: 0000000017d81b27 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}: hfsplus_get_block+0x292/0x960 fs/hfsplus/extents.c:260 block_read_full_page+0x288/0xd10 fs/buffer.c:2259 do_read_cache_page+0x533/0x1170 mm/filemap.c:2828 read_mapping_page include/linux/pagemap.h:402 [inline] hfsplus_block_allocate+0x197/0xa60 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x436/0xf40 fs/hfsplus/extents.c:468 hfsplus_get_block+0x196/0x960 fs/hfsplus/extents.c:245 __block_write_begin_int+0x46c/0x17b0 fs/buffer.c:1978 __block_write_begin fs/buffer.c:2028 [inline] block_write_begin+0x58/0x2e0 fs/buffer.c:2087 cont_write_begin+0x55a/0x820 fs/buffer.c:2440 hfsplus_write_begin+0x87/0x150 fs/hfsplus/inode.c:52 cont_expand_zero fs/buffer.c:2367 [inline] cont_write_begin+0x2ee/0x820 fs/buffer.c:2430 hfsplus_write_begin+0x87/0x150 fs/hfsplus/inode.c:52 generic_cont_expand_simple+0x106/0x170 fs/buffer.c:2331 hfsplus_setattr+0x18b/0x310 fs/hfsplus/inode.c:257 notify_change+0x70b/0xfc0 fs/attr.c:334 do_truncate+0x134/0x1f0 fs/open.c:63 do_sys_ftruncate+0x492/0x560 fs/open.c:194 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #0 (&sbi->alloc_mutex){+.+.}: __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x228/0x520 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0xd96/0x1040 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419 hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405 hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545 vfs_rename+0x67e/0x1bc0 fs/namei.c:4479 do_renameat2+0xb59/0xc70 fs/namei.c:4629 __do_sys_rename fs/namei.c:4675 [inline] __se_sys_rename fs/namei.c:4673 [inline] __x64_sys_rename+0x5d/0x80 fs/namei.c:4673 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 8 locks held by syz-executor.4/31007: #0: 00000000e5e3d9fa (sb_writers#23){.+.+}, at: sb_start_write include/linux/fs.h:1579 [inline] #0: 00000000e5e3d9fa (sb_writers#23){.+.+}, at: mnt_want_write+0x3a/0xb0 fs/namespace.c:360 #1: 000000000d5b2d57 (&type->s_vfs_rename_key#2){+.+.}, at: lock_rename+0x54/0x280 fs/namei.c:2867 #2: 00000000baeb5c9a (&type->i_mutex_dir_key#11/1){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline] #2: 00000000baeb5c9a (&type->i_mutex_dir_key#11/1){+.+.}, at: lock_rename+0x132/0x280 fs/namei.c:2878 #3: 00000000d759a46c (&type->i_mutex_dir_key#11/2){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline] #3: 00000000d759a46c (&type->i_mutex_dir_key#11/2){+.+.}, at: lock_rename+0x166/0x280 fs/namei.c:2879 #4: 00000000f5b4e28e (&sb->s_type->i_mutex_key#29){+.+.}, at: inode_lock include/linux/fs.h:748 [inline] #4: 00000000f5b4e28e (&sb->s_type->i_mutex_key#29){+.+.}, at: lock_two_nondirectories+0xec/0x110 fs/inode.c:1015 #5: 00000000c4148135 (&sb->s_type->i_mutex_key#29/4){+.+.}, at: inode_lock_nested include/linux/fs.h:783 [inline] #5: 00000000c4148135 (&sb->s_type->i_mutex_key#29/4){+.+.}, at: lock_two_nondirectories+0xd1/0x110 fs/inode.c:1017 #6: 000000008c1e51f9 (&sbi->vh_mutex){+.+.}, at: hfsplus_unlink+0x140/0x820 fs/hfsplus/dir.c:370 #7: 0000000017d81b27 (&HFSPLUS_I(inode)->extents_lock){+.+.}, at: hfsplus_file_truncate+0x1e2/0x1040 fs/hfsplus/extents.c:576 stack backtrace: CPU: 1 PID: 31007 Comm: syz-executor.4 Not tainted 4.19.211-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 10/26/2022 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1fc/0x2ef lib/dump_stack.c:118 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222 check_prev_add kernel/locking/lockdep.c:1866 [inline] check_prevs_add kernel/locking/lockdep.c:1979 [inline] validate_chain kernel/locking/lockdep.c:2420 [inline] __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908 __mutex_lock_common kernel/locking/mutex.c:937 [inline] __mutex_lock+0xd7/0x1190 kernel/locking/mutex.c:1078 hfsplus_block_free+0xdb/0x5d0 fs/hfsplus/bitmap.c:182 hfsplus_free_extents+0x228/0x520 fs/hfsplus/extents.c:363 hfsplus_file_truncate+0xd96/0x1040 fs/hfsplus/extents.c:591 hfsplus_delete_inode+0x18d/0x220 fs/hfsplus/inode.c:419 hfsplus_unlink+0x595/0x820 fs/hfsplus/dir.c:405 hfsplus_rename+0xbe/0x200 fs/hfsplus/dir.c:545 vfs_rename+0x67e/0x1bc0 fs/namei.c:4479 do_renameat2+0xb59/0xc70 fs/namei.c:4629 __do_sys_rename fs/namei.c:4675 [inline] __se_sys_rename fs/namei.c:4673 [inline] __x64_sys_rename+0x5d/0x80 fs/namei.c:4673 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x7fcdec4d50a9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fcdeaa47168 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 00007fcdec5f4f80 RCX: 00007fcdec4d50a9 RDX: 0000000000000000 RSI: 0000000020000140 RDI: 0000000020000000 RBP: 00007fcdec530ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffc8a89402f R14: 00007fcdeaa47300 R15: 0000000000022000 IPVS: ftp: loaded support on port[0] = 21 attempt to access beyond end of device loop4: rw=0, want=201326594, limit=1024 Buffer I/O error on dev loop4, logical block 100663296, async page read hfsplus: unable to mark blocks free: error -5 hfsplus: can't free extent audit: type=1800 audit(1672060605.950:474): pid=31006 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=15729 res=0 IPVS: ftp: loaded support on port[0] = 21 attempt to access beyond end of device loop4: rw=0, want=201326594, limit=1024 IPVS: ftp: loaded support on port[0] = 21 audit: type=1800 audit(1672060606.160:475): pid=31115 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=14210 res=0 Buffer I/O error on dev loop4, logical block 100663296, async page read overlayfs: failed to resolve './bus': -40 hfsplus: unable to mark blocks free: error -5 hfsplus: can't free extent audit: type=1800 audit(1672060606.710:476): pid=31189 uid=0 auid=4294967295 ses=4294967295 subj==unconfined op=collect_data cause=failed(directio) comm="syz-executor.2" name="file0" dev="sda1" ino=13892 res=0 9pnet: Insufficient options for proto=fd IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 9pnet: Insufficient options for proto=fd netlink: 'syz-executor.2': attribute type 11 has an invalid length. IPVS: ftp: loaded support on port[0] = 21 netlink: 4 bytes leftover after parsing attributes in process `syz-executor.2'. (unnamed net_device) (uninitialized): option primary: mode dependency failed, not supported in mode broadcast(3) netlink: 'syz-executor.2': attribute type 11 has an invalid length. IPVS: ftp: loaded support on port[0] = 21 netlink: 4 bytes leftover after parsing attributes in process `syz-executor.2'. (unnamed net_device) (uninitialized): option primary: mode dependency failed, not supported in mode broadcast(3) IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 netlink: 'syz-executor.2': attribute type 11 has an invalid length. netlink: 4 bytes leftover after parsing attributes in process `syz-executor.2'. (unnamed net_device) (uninitialized): option primary: mode dependency failed, not supported in mode broadcast(3) netlink: 'syz-executor.2': attribute type 11 has an invalid length. netlink: 4 bytes leftover after parsing attributes in process `syz-executor.2'. (unnamed net_device) (uninitialized): option primary: mode dependency failed, not supported in mode broadcast(3) IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21 IPVS: ftp: loaded support on port[0] = 21