hfsplus: inconsistency in B*Tree (1793,1,255,1,0) ====================================================== WARNING: possible circular locking dependency detected 6.7.0-syzkaller-12377-g9d1694dc91ce #0 Not tainted ------------------------------------------------------ syz-executor.1/13957 is trying to acquire lock: ffff888033ed60f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff888037c66d08 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 hfsplus_get_block+0x383/0x14e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x422/0xe10 fs/buffer.c:2382 filemap_read_folio+0x19c/0x780 mm/filemap.c:2324 do_read_cache_folio+0x134/0x810 mm/filemap.c:3701 do_read_cache_page+0x30/0x200 mm/filemap.c:3767 read_mapping_page include/linux/pagemap.h:888 [inline] hfsplus_block_allocate+0xee/0x8b0 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_get_block+0x406/0x14e0 fs/hfsplus/extents.c:245 __block_write_begin_int+0x50b/0x1a70 fs/buffer.c:2103 __block_write_begin fs/buffer.c:2152 [inline] block_write_begin+0x9b/0x1e0 fs/buffer.c:2211 cont_write_begin+0x643/0x880 fs/buffer.c:2565 hfsplus_write_begin+0x8a/0xd0 fs/hfsplus/inode.c:47 page_symlink+0x2c5/0x4e0 fs/namei.c:5228 hfsplus_symlink+0xca/0x260 fs/hfsplus/dir.c:449 vfs_symlink+0x12f/0x2a0 fs/namei.c:4480 do_symlinkat+0x222/0x3a0 fs/namei.c:4506 __do_sys_symlink fs/namei.c:4527 [inline] __se_sys_symlink fs/namei.c:4525 [inline] __x64_sys_symlink+0x7e/0x90 fs/namei.c:4525 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x1909/0x5ab0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 hfsplus_create_attr+0x1c8/0x630 fs/hfsplus/attributes.c:221 __hfsplus_setxattr+0x6fe/0x22d0 fs/hfsplus/xattr.c:354 hfsplus_initxattrs+0x158/0x220 fs/hfsplus/xattr_security.c:59 security_inode_init_security+0x2a7/0x470 security/security.c:1752 hfsplus_fill_super+0x14d3/0x1c90 fs/hfsplus/super.c:567 mount_bdev+0x206/0x2d0 fs/super.c:1663 legacy_get_tree+0xef/0x190 fs/fs_context.c:662 vfs_get_tree+0x8c/0x2a0 fs/super.c:1784 do_new_mount+0x2be/0xb40 fs/namespace.c:3352 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3875 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 5 locks held by syz-executor.1/13957: #0: ffff8880305760e0 (&type->s_umount_key#71/1){+.+.}-{3:3}, at: alloc_super+0x20e/0x8f0 fs/super.c:345 #1: ffff888033ed6198 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_fill_super+0x137c/0x1c90 fs/hfsplus/super.c:553 #2: ffff888023c520b0 (&tree->tree_lock){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 #3: ffff88807bda60b0 (&tree->tree_lock/2){+.+.}-{3:3}, at: hfsplus_find_init+0x14a/0x1c0 #4: ffff888037c66d08 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x21b/0x1b70 fs/hfsplus/extents.c:457 stack backtrace: CPU: 1 PID: 13957 Comm: syz-executor.1 Not tainted 6.7.0-syzkaller-12377-g9d1694dc91ce #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x366/0x490 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x1909/0x5ab0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 hfsplus_block_allocate+0x9e/0x8b0 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0xade/0x1b70 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x105/0x4e0 fs/hfsplus/btree.c:358 hfsplus_create_attr+0x1c8/0x630 fs/hfsplus/attributes.c:221 __hfsplus_setxattr+0x6fe/0x22d0 fs/hfsplus/xattr.c:354 hfsplus_initxattrs+0x158/0x220 fs/hfsplus/xattr_security.c:59 security_inode_init_security+0x2a7/0x470 security/security.c:1752 hfsplus_fill_super+0x14d3/0x1c90 fs/hfsplus/super.c:567 mount_bdev+0x206/0x2d0 fs/super.c:1663 legacy_get_tree+0xef/0x190 fs/fs_context.c:662 vfs_get_tree+0x8c/0x2a0 fs/super.c:1784 do_new_mount+0x2be/0xb40 fs/namespace.c:3352 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount+0x2d9/0x3c0 fs/namespace.c:3875 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f9bcce7e4aa Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f9bcdb3aef8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007f9bcdb3af80 RCX: 00007f9bcce7e4aa RDX: 0000000020000240 RSI: 0000000020000200 RDI: 00007f9bcdb3af40 RBP: 0000000020000240 R08: 00007f9bcdb3af80 R09: 00000000010108d4 R10: 00000000010108d4 R11: 0000000000000202 R12: 0000000020000200 R13: 00007f9bcdb3af40 R14: 0000000000000685 R15: 00000000200000c0 hfsplus: inconsistency in B*Tree (1793,1,255,1,0) hfsplus: xattr search failed