====================================================== WARNING: possible circular locking dependency detected 6.9.0-rc6-syzkaller-00022-g98369dccd2f8 #0 Not tainted ------------------------------------------------------ syz-executor.2/7239 is trying to acquire lock: ffff8880470048f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0xe9/0x990 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff888054abbdc8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 hfsplus_get_block+0x277/0x9e0 fs/hfsplus/extents.c:260 block_read_full_folio+0x38f/0xa70 fs/buffer.c:2384 filemap_read_folio+0xe5/0x2c0 mm/filemap.c:2331 do_read_cache_folio+0x203/0x540 mm/filemap.c:3747 do_read_cache_page mm/filemap.c:3813 [inline] read_cache_page+0x5b/0x160 mm/filemap.c:3822 read_mapping_page include/linux/pagemap.h:888 [inline] hfsplus_block_allocate+0x148/0x990 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x440/0x1090 fs/hfsplus/extents.c:468 hfsplus_get_block+0x1ae/0x9e0 fs/hfsplus/extents.c:245 get_more_blocks fs/direct-io.c:649 [inline] do_direct_IO fs/direct-io.c:937 [inline] __blockdev_direct_IO+0x2456/0x3d50 fs/direct-io.c:1250 blockdev_direct_IO include/linux/fs.h:3190 [inline] hfsplus_direct_IO+0x10c/0x2d0 fs/hfsplus/inode.c:130 generic_file_direct_write+0x139/0x3a0 mm/filemap.c:3899 __generic_file_write_iter+0x121/0x240 mm/filemap.c:4055 generic_file_write_iter+0xe7/0x350 mm/filemap.c:4095 call_write_iter include/linux/fs.h:2110 [inline] new_sync_write fs/read_write.c:497 [inline] vfs_write+0x6db/0x1100 fs/read_write.c:590 ksys_write+0x12f/0x260 fs/read_write.c:643 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 hfsplus_block_allocate+0xe9/0x990 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x440/0x1090 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358 hfsplus_create_cat+0x213/0x10d0 fs/hfsplus/catalog.c:272 hfsplus_fill_super+0x16ce/0x1bc0 fs/hfsplus/super.c:566 mount_bdev+0x1e3/0x2d0 fs/super.c:1658 legacy_get_tree+0x109/0x220 fs/fs_context.c:662 vfs_get_tree+0x8f/0x380 fs/super.c:1779 do_new_mount fs/namespace.c:3352 [inline] path_mount+0x14e6/0x1f20 fs/namespace.c:3679 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount fs/namespace.c:3875 [inline] __x64_sys_mount+0x297/0x320 fs/namespace.c:3875 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 4 locks held by syz-executor.2/7239: #0: ffff8880251900e0 (&type->s_umount_key#82/1){+.+.}-{3:3}, at: alloc_super+0x23d/0xbd0 fs/super.c:343 #1: ffff888047004998 (&sbi->vh_mutex){+.+.}-{3:3}, at: hfsplus_fill_super+0x1657/0x1bc0 fs/hfsplus/super.c:559 #2: ffff8880251940b0 (&tree->tree_lock#2){+.+.}-{3:3}, at: hfsplus_find_init+0x1a7/0x200 fs/hfsplus/bfind.c:30 #3: ffff888054abbdc8 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x1c1/0x1090 fs/hfsplus/extents.c:457 stack backtrace: CPU: 2 PID: 7239 Comm: syz-executor.2 Not tainted 6.9.0-rc6-syzkaller-00022-g98369dccd2f8 #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:114 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2478/0x3b30 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1b1/0x560 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x175/0x9c0 kernel/locking/mutex.c:752 hfsplus_block_allocate+0xe9/0x990 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x440/0x1090 fs/hfsplus/extents.c:468 hfsplus_bmap_reserve+0x31c/0x410 fs/hfsplus/btree.c:358 hfsplus_create_cat+0x213/0x10d0 fs/hfsplus/catalog.c:272 hfsplus_fill_super+0x16ce/0x1bc0 fs/hfsplus/super.c:566 mount_bdev+0x1e3/0x2d0 fs/super.c:1658 legacy_get_tree+0x109/0x220 fs/fs_context.c:662 vfs_get_tree+0x8f/0x380 fs/super.c:1779 do_new_mount fs/namespace.c:3352 [inline] path_mount+0x14e6/0x1f20 fs/namespace.c:3679 do_mount fs/namespace.c:3692 [inline] __do_sys_mount fs/namespace.c:3898 [inline] __se_sys_mount fs/namespace.c:3875 [inline] __x64_sys_mount+0x297/0x320 fs/namespace.c:3875 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcf/0x260 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fb32f07f5aa Code: d8 64 89 02 48 c7 c0 ff ff ff ff eb a6 e8 de 09 00 00 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fb32fddeef8 EFLAGS: 00000202 ORIG_RAX: 00000000000000a5 RAX: ffffffffffffffda RBX: 00007fb32fddef80 RCX: 00007fb32f07f5aa RDX: 0000000020000600 RSI: 0000000020000080 RDI: 00007fb32fddef40 RBP: 0000000020000600 R08: 00007fb32fddef80 R09: 0000000000a00010 R10: 0000000000a00010 R11: 0000000000000202 R12: 0000000020000080 R13: 00007fb32fddef40 R14: 000000000000063b R15: 0000000020000000