====================================================== WARNING: possible circular locking dependency detected 6.2.0-syzkaller-13563-gf915322fe014 #0 Not tainted ------------------------------------------------------ syz-executor.4/18561 is trying to acquire lock: ffff88814b18c990 (jbd2_handle){++++}-{0:0}, at: jbd2_log_wait_commit+0x153/0x4a0 fs/jbd2/journal.c:692 but task is already holding lock: ffff8880488b8400 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] ffff8880488b8400 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename fs/ext4/namei.c:3879 [inline] ffff8880488b8400 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename2+0x2633/0x4410 fs/ext4/namei.c:4193 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}: lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669 down_write_nested+0x3d/0x50 kernel/locking/rwsem.c:1689 inode_lock_nested include/linux/fs.h:793 [inline] ext4_rename fs/ext4/namei.c:3879 [inline] ext4_rename2+0x2633/0x4410 fs/ext4/namei.c:4193 vfs_rename+0xb1b/0xfa0 fs/namei.c:4772 do_renameat2+0xb9b/0x13c0 fs/namei.c:4923 __do_sys_renameat2 fs/namei.c:4956 [inline] __se_sys_renameat2 fs/namei.c:4953 [inline] __x64_sys_renameat2+0xd2/0xe0 fs/namei.c:4953 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd -> #0 (jbd2_handle){++++}-{0:0}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669 jbd2_log_wait_commit+0x173/0x4a0 fs/jbd2/journal.c:692 jbd2_journal_stop+0x95b/0xf50 fs/jbd2/transaction.c:1959 __ext4_journal_stop+0xfc/0x1a0 fs/ext4/ext4_jbd2.c:133 ext4_rename fs/ext4/namei.c:4014 [inline] ext4_rename2+0x3c40/0x4410 fs/ext4/namei.c:4193 vfs_rename+0xb1b/0xfa0 fs/namei.c:4772 do_renameat2+0xb9b/0x13c0 fs/namei.c:4923 __do_sys_renameat2 fs/namei.c:4956 [inline] __se_sys_renameat2 fs/namei.c:4953 [inline] __x64_sys_renameat2+0xd2/0xe0 fs/namei.c:4953 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#3/4); lock(jbd2_handle); lock(&type->i_mutex_dir_key#3/4); lock(jbd2_handle); *** DEADLOCK *** 4 locks held by syz-executor.4/18561: #0: ffff88814b188460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:394 #1: ffff88804c5b2c20 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: lock_rename+0x186/0x1a0 #2: ffff88804c74c030 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff88804c74c030 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: vfs_rename+0x617/0xfa0 fs/namei.c:4744 #3: ffff8880488b8400 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #3: ffff8880488b8400 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename fs/ext4/namei.c:3879 [inline] #3: ffff8880488b8400 (&type->i_mutex_dir_key#3/4){+.+.}-{3:3}, at: ext4_rename2+0x2633/0x4410 fs/ext4/namei.c:4193 stack backtrace: CPU: 1 PID: 18561 Comm: syz-executor.4 Not tainted 6.2.0-syzkaller-13563-gf915322fe014 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2fe/0x3b0 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain+0x166b/0x58e0 kernel/locking/lockdep.c:3832 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5056 lock_acquire+0x23e/0x630 kernel/locking/lockdep.c:5669 jbd2_log_wait_commit+0x173/0x4a0 fs/jbd2/journal.c:692 jbd2_journal_stop+0x95b/0xf50 fs/jbd2/transaction.c:1959 __ext4_journal_stop+0xfc/0x1a0 fs/ext4/ext4_jbd2.c:133 ext4_rename fs/ext4/namei.c:4014 [inline] ext4_rename2+0x3c40/0x4410 fs/ext4/namei.c:4193 vfs_rename+0xb1b/0xfa0 fs/namei.c:4772 do_renameat2+0xb9b/0x13c0 fs/namei.c:4923 __do_sys_renameat2 fs/namei.c:4956 [inline] __se_sys_renameat2 fs/namei.c:4953 [inline] __x64_sys_renameat2+0xd2/0xe0 fs/namei.c:4953 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x41/0xc0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fc85f48c0f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fc860180168 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 00007fc85f5abf80 RCX: 00007fc85f48c0f9 RDX: 0000000000000005 RSI: 0000000020005780 RDI: 0000000000000006 RBP: 00007fc85f4e7ae9 R08: 0000000000000000 R09: 0000000000000000 R10: 00000000200016c0 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffe8d69308f R14: 00007fc860180300 R15: 0000000000022000