====================================================== WARNING: possible circular locking dependency detected 6.1.111-syzkaller #0 Not tainted ------------------------------------------------------ syz.3.461/6321 is trying to acquire lock: ffff88804c022aa8 (&ei->i_data_sem/2){++++}-{3:3}, at: ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 but task is already holding lock: ffff88807be00208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:357 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&s->s_dquot.dqio_sem){++++}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 v2_read_dquot+0x4a/0x100 fs/quota/quota_v2.c:335 dquot_acquire+0x188/0x680 fs/quota/dquot.c:463 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6796 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_process_orphan+0x57/0x2d0 fs/ext4/orphan.c:329 ext4_orphan_cleanup+0xb70/0x1400 fs/ext4/orphan.c:474 __ext4_fill_super fs/ext4/super.c:5533 [inline] ext4_fill_super+0x83ff/0x8b50 fs/ext4/super.c:5664 get_tree_bdev+0x3fe/0x620 fs/super.c:1366 vfs_get_tree+0x88/0x270 fs/super.c:1573 do_new_mount+0x2ba/0xb40 fs/namespace.c:3051 do_mount fs/namespace.c:3394 [inline] __do_sys_mount fs/namespace.c:3602 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3579 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&dquot->dq_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 dquot_commit+0x57/0x510 fs/quota/dquot.c:507 ext4_write_dquot+0x1fd/0x360 fs/ext4/super.c:6776 mark_dquot_dirty fs/quota/dquot.c:372 [inline] mark_all_dquot_dirty+0xf7/0x400 fs/quota/dquot.c:412 __dquot_alloc_space+0xb68/0x10e0 fs/quota/dquot.c:1750 dquot_alloc_space_nodirty include/linux/quotaops.h:300 [inline] dquot_alloc_space include/linux/quotaops.h:313 [inline] dquot_alloc_block include/linux/quotaops.h:337 [inline] ext4_mb_new_blocks+0x1302/0x4b80 fs/ext4/mballoc.c:5730 ext4_ext_map_blocks+0x1c1c/0x7ab0 fs/ext4/extents.c:4318 ext4_map_blocks+0xa2b/0x1cb0 fs/ext4/inode.c:678 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_append+0x31f/0x5c0 fs/ext4/namei.c:83 ext4_init_new_dir+0x33a/0xa20 fs/ext4/namei.c:3028 ext4_mkdir+0x4f2/0xce0 fs/ext4/namei.c:3074 vfs_mkdir+0x3b6/0x590 fs/namei.c:4108 do_mkdirat+0x225/0x360 fs/namei.c:4133 __do_sys_mkdirat fs/namei.c:4148 [inline] __se_sys_mkdirat fs/namei.c:4146 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4146 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ei->i_data_sem/2){++++}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7170 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:136 do_insert_tree+0x298/0x1440 fs/quota/quota_tree.c:347 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x483/0x5a0 fs/quota/quota_tree.c:451 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:361 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6796 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_rename fs/ext4/namei.c:3869 [inline] ext4_rename2+0xaa6/0x4420 fs/ext4/namei.c:4256 vfs_rename+0xd32/0x10f0 fs/namei.c:4876 do_renameat2+0xde0/0x1440 fs/namei.c:5029 __do_sys_renameat2 fs/namei.c:5062 [inline] __se_sys_renameat2 fs/namei.c:5059 [inline] __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5059 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &ei->i_data_sem/2 --> &dquot->dq_lock --> &s->s_dquot.dqio_sem Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&s->s_dquot.dqio_sem); lock(&dquot->dq_lock); lock(&s->s_dquot.dqio_sem); lock(&ei->i_data_sem/2); *** DEADLOCK *** 5 locks held by syz.3.461/6321: #0: ffff88807be00460 (sb_writers#4){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff8880684ef258 (&type->i_mutex_dir_key#3/1){+.+.}-{3:3}, at: do_renameat2+0x65a/0x1440 fs/namei.c:4968 #2: ffff88804c021810 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #2: ffff88804c021810 (&type->i_mutex_dir_key#3){++++}-{3:3}, at: vfs_rename+0x814/0x10f0 fs/namei.c:4841 #3: ffff8880684ac268 (&dquot->dq_lock){+.+.}-{3:3}, at: dquot_acquire+0x64/0x680 fs/quota/dquot.c:460 #4: ffff88807be00208 (&s->s_dquot.dqio_sem){++++}-{3:3}, at: v2_write_dquot+0x9b/0x190 fs/quota/quota_v2.c:357 stack backtrace: CPU: 1 PID: 6321 Comm: syz.3.461 Not tainted 6.1.111-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_read+0xad/0xa30 kernel/locking/rwsem.c:1520 ext4_map_blocks+0x379/0x1cb0 fs/ext4/inode.c:603 ext4_getblk+0x1eb/0x7c0 fs/ext4/inode.c:889 ext4_bread+0x2a/0x170 fs/ext4/inode.c:945 ext4_quota_write+0x21e/0x570 fs/ext4/super.c:7170 write_blk fs/quota/quota_tree.c:70 [inline] get_free_dqblk+0x340/0x6c0 fs/quota/quota_tree.c:136 do_insert_tree+0x298/0x1440 fs/quota/quota_tree.c:347 do_insert_tree+0xb94/0x1440 fs/quota/quota_tree.c:402 dq_insert_tree fs/quota/quota_tree.c:432 [inline] qtree_write_dquot+0x483/0x5a0 fs/quota/quota_tree.c:451 v2_write_dquot+0x11c/0x190 fs/quota/quota_v2.c:361 dquot_acquire+0x34d/0x680 fs/quota/dquot.c:472 ext4_acquire_dquot+0x2eb/0x4a0 fs/ext4/super.c:6796 dqget+0x762/0xe90 fs/quota/dquot.c:986 __dquot_initialize+0x2d9/0xea0 fs/quota/dquot.c:1515 ext4_rename fs/ext4/namei.c:3869 [inline] ext4_rename2+0xaa6/0x4420 fs/ext4/namei.c:4256 vfs_rename+0xd32/0x10f0 fs/namei.c:4876 do_renameat2+0xde0/0x1440 fs/namei.c:5029 __do_sys_renameat2 fs/namei.c:5062 [inline] __se_sys_renameat2 fs/namei.c:5059 [inline] __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5059 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f69bb57def9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f69bc41a038 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 00007f69bb736130 RCX: 00007f69bb57def9 RDX: 0000000000000008 RSI: 00000000200001c0 RDI: 0000000000000008 RBP: 00007f69bb5f0b76 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000020000100 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f69bb736130 R15: 00007ffd322dde38