====================================================== WARNING: possible circular locking dependency detected 6.1.90-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.3/6060 is trying to acquire lock: ffff0000ce290ae0 (&sdp->sd_quota_mutex){+.+.}-{3:3}, at: do_qc+0xbc/0x664 fs/gfs2/quota.c:682 but task is already holding lock: ffff0000f4a585e8 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1512 [inline] ffff0000f4a585e8 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1fb0/0x2ff0 fs/gfs2/bmap.c:1836 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ip->i_rw_mutex){++++}-{3:3}: down_read+0x64/0x308 kernel/locking/rwsem.c:1520 __gfs2_iomap_get+0x138/0x1058 fs/gfs2/bmap.c:856 gfs2_iomap_get+0xd8/0x154 fs/gfs2/bmap.c:1396 bh_get+0x210/0x6b8 fs/gfs2/quota.c:385 qdsb_get+0x1e0/0x398 fs/gfs2/quota.c:522 gfs2_quota_hold+0x16c/0x558 fs/gfs2/quota.c:608 punch_hole+0xc14/0x2ff0 fs/gfs2/bmap.c:1797 __gfs2_punch_hole+0x6d4/0x918 fs/gfs2/bmap.c:2451 gfs2_fallocate+0x384/0x48c fs/gfs2/file.c:1392 vfs_fallocate+0x478/0x5b4 fs/open.c:323 ioctl_preallocate+0x278/0x324 fs/ioctl.c:290 do_vfs_ioctl+0x1ad8/0x26f8 fs/ioctl.c:849 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 -> #0 (&sdp->sd_quota_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 do_qc+0xbc/0x664 fs/gfs2/quota.c:682 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 punch_hole+0x2aa8/0x2ff0 fs/gfs2/bmap.c:1937 __gfs2_punch_hole+0x6d4/0x918 fs/gfs2/bmap.c:2451 gfs2_fallocate+0x384/0x48c fs/gfs2/file.c:1392 vfs_fallocate+0x478/0x5b4 fs/open.c:323 ioctl_preallocate+0x278/0x324 fs/ioctl.c:290 do_vfs_ioctl+0x1ad8/0x26f8 fs/ioctl.c:849 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); lock(&ip->i_rw_mutex); lock(&sdp->sd_quota_mutex); *** DEADLOCK *** 5 locks held by syz-executor.3/6060: #0: ffff0000dd742460 (sb_writers#25){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:3010 [inline] #0: ffff0000dd742460 (sb_writers#25){.+.+}-{0:0}, at: vfs_fallocate+0x404/0x5b4 fs/open.c:322 #1: ffff0000f4a58150 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] #1: ffff0000f4a58150 (&sb->s_type->i_mutex_key#30){+.+.}-{3:3}, at: gfs2_fallocate+0x188/0x48c fs/gfs2/file.c:1373 #2: ffff0000dd742650 (sb_internal#4){.+.+}-{0:0}, at: gfs2_trans_begin+0xa8/0x11c fs/gfs2/trans.c:118 #3: ffff0000ce291058 (&sdp->sd_log_flush_lock){.+.+}-{3:3}, at: __gfs2_trans_begin+0x524/0x91c fs/gfs2/trans.c:87 #4: ffff0000f4a585e8 (&ip->i_rw_mutex){++++}-{3:3}, at: sweep_bh_for_rgrps fs/gfs2/bmap.c:1512 [inline] #4: ffff0000f4a585e8 (&ip->i_rw_mutex){++++}-{3:3}, at: punch_hole+0x1fb0/0x2ff0 fs/gfs2/bmap.c:1836 stack backtrace: CPU: 1 PID: 6060 Comm: syz-executor.3 Not tainted 6.1.90-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x58 lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2048 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain kernel/locking/lockdep.c:3825 [inline] __lock_acquire+0x3338/0x7680 kernel/locking/lockdep.c:5049 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5662 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 do_qc+0xbc/0x664 fs/gfs2/quota.c:682 gfs2_quota_change+0x238/0x718 fs/gfs2/quota.c:1295 punch_hole+0x2aa8/0x2ff0 fs/gfs2/bmap.c:1937 __gfs2_punch_hole+0x6d4/0x918 fs/gfs2/bmap.c:2451 gfs2_fallocate+0x384/0x48c fs/gfs2/file.c:1392 vfs_fallocate+0x478/0x5b4 fs/open.c:323 ioctl_preallocate+0x278/0x324 fs/ioctl.c:290 do_vfs_ioctl+0x1ad8/0x26f8 fs/ioctl.c:849 __do_sys_ioctl fs/ioctl.c:868 [inline] __se_sys_ioctl fs/ioctl.c:856 [inline] __arm64_sys_ioctl+0xe4/0x1c8 fs/ioctl.c:856 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:585