ocfs2: Mounting device (7,5) on (node local, slot 0) with ordered data mode. ====================================================== WARNING: possible circular locking dependency detected 6.14.0-rc1-syzkaller-g2014c95afece #0 Not tainted ------------------------------------------------------ syz.5.243/7653 is trying to acquire lock: ffff0000f23eeab8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_get+0x104/0x28c fs/ocfs2/xattr.c:1338 but task is already holding lock: ffff0000e771c950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0xf0c/0x11c4 fs/jbd2/transaction.c:446 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #6 (jbd2_handle){++++}-{0:0}: start_this_handle+0xf34/0x11c4 fs/jbd2/transaction.c:448 jbd2__journal_start+0x298/0x544 fs/jbd2/transaction.c:505 jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:544 ocfs2_start_trans+0x3d0/0x71c fs/ocfs2/journal.c:352 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x840/0x4254 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2837 [inline] ocfs2_extend_dir+0xb7c/0x4608 fs/ocfs2/dir.c:3199 ocfs2_prepare_dir_for_insert+0x2cdc/0x5018 fs/ocfs2/dir.c:4304 ocfs2_symlink+0x760/0x24d0 fs/ocfs2/namei.c:1872 vfs_symlink+0x138/0x28c fs/namei.c:4671 do_symlinkat+0x1c4/0x46c fs/namei.c:4697 __do_sys_symlinkat fs/namei.c:4713 [inline] __se_sys_symlinkat fs/namei.c:4710 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4710 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #5 (&journal->j_trans_barrier){.+.+}-{4:4}: down_read+0x58/0x2fc kernel/locking/rwsem.c:1524 ocfs2_start_trans+0x3c4/0x71c fs/ocfs2/journal.c:350 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x840/0x4254 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2837 [inline] ocfs2_extend_dir+0xb7c/0x4608 fs/ocfs2/dir.c:3199 ocfs2_prepare_dir_for_insert+0x2cdc/0x5018 fs/ocfs2/dir.c:4304 ocfs2_symlink+0x760/0x24d0 fs/ocfs2/namei.c:1872 vfs_symlink+0x138/0x28c fs/namei.c:4671 do_symlinkat+0x1c4/0x46c fs/namei.c:4697 __do_sys_symlinkat fs/namei.c:4713 [inline] __se_sys_symlinkat fs/namei.c:4710 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4710 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #4 (sb_internal#4){.+.+}-{0:0}: percpu_down_read include/linux/percpu-rwsem.h:51 [inline] __sb_start_write include/linux/fs.h:1773 [inline] sb_start_intwrite include/linux/fs.h:1956 [inline] ocfs2_start_trans+0x244/0x71c fs/ocfs2/journal.c:348 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:685 [inline] ocfs2_reserve_suballoc_bits+0x840/0x4254 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2837 [inline] ocfs2_extend_dir+0xb7c/0x4608 fs/ocfs2/dir.c:3199 ocfs2_prepare_dir_for_insert+0x2cdc/0x5018 fs/ocfs2/dir.c:4304 ocfs2_symlink+0x760/0x24d0 fs/ocfs2/namei.c:1872 vfs_symlink+0x138/0x28c fs/namei.c:4671 do_symlinkat+0x1c4/0x46c fs/namei.c:4697 __do_sys_symlinkat fs/namei.c:4713 [inline] __se_sys_symlinkat fs/namei.c:4710 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4710 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #3 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#3){+.+.}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:865 [inline] ocfs2_reserve_suballoc_bits+0x164/0x4254 fs/ocfs2/suballoc.c:786 ocfs2_reserve_cluster_bitmap_bits fs/ocfs2/suballoc.c:1132 [inline] ocfs2_reserve_clusters_with_limit+0x2ac/0xabc fs/ocfs2/suballoc.c:1177 ocfs2_block_group_alloc fs/ocfs2/suballoc.c:674 [inline] ocfs2_reserve_suballoc_bits+0x820/0x4254 fs/ocfs2/suballoc.c:832 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2837 [inline] ocfs2_extend_dir+0xb7c/0x4608 fs/ocfs2/dir.c:3199 ocfs2_prepare_dir_for_insert+0x2cdc/0x5018 fs/ocfs2/dir.c:4304 ocfs2_symlink+0x760/0x24d0 fs/ocfs2/namei.c:1872 vfs_symlink+0x138/0x28c fs/namei.c:4671 do_symlinkat+0x1c4/0x46c fs/namei.c:4697 __do_sys_symlinkat fs/namei.c:4713 [inline] __se_sys_symlinkat fs/namei.c:4710 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4710 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #2 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#2){+.+.}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:865 [inline] ocfs2_reserve_suballoc_bits+0x164/0x4254 fs/ocfs2/suballoc.c:786 ocfs2_reserve_new_metadata_blocks+0x384/0x848 fs/ocfs2/suballoc.c:982 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2837 [inline] ocfs2_extend_dir+0xb7c/0x4608 fs/ocfs2/dir.c:3199 ocfs2_prepare_dir_for_insert+0x2cdc/0x5018 fs/ocfs2/dir.c:4304 ocfs2_symlink+0x760/0x24d0 fs/ocfs2/namei.c:1872 vfs_symlink+0x138/0x28c fs/namei.c:4671 do_symlinkat+0x1c4/0x46c fs/namei.c:4697 __do_sys_symlinkat fs/namei.c:4713 [inline] __se_sys_symlinkat fs/namei.c:4710 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4710 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}: down_write+0x50/0xc0 kernel/locking/rwsem.c:1577 ocfs2_try_remove_refcount_tree+0xb4/0x2f0 fs/ocfs2/refcounttree.c:932 ocfs2_xattr_set+0x670/0x1448 fs/ocfs2/xattr.c:3669 ocfs2_set_acl+0x410/0x4b4 fs/ocfs2/acl.c:254 ocfs2_iop_set_acl+0x230/0x374 fs/ocfs2/acl.c:286 set_posix_acl fs/posix_acl.c:954 [inline] vfs_set_acl+0x7a0/0xa24 fs/posix_acl.c:1133 do_set_acl+0xc8/0x1ac fs/posix_acl.c:1278 do_setxattr fs/xattr.c:633 [inline] filename_setxattr+0x2e4/0x3fc fs/xattr.c:665 path_setxattrat+0x370/0x41c fs/xattr.c:713 __do_sys_setxattr fs/xattr.c:747 [inline] __se_sys_setxattr fs/xattr.c:743 [inline] __arm64_sys_setxattr+0xc0/0xdc fs/xattr.c:743 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 -> #0 (&oi->ip_xattr_sem){++++}-{4:4}: check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain kernel/locking/lockdep.c:3906 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5228 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5851 down_read+0x58/0x2fc kernel/locking/rwsem.c:1524 ocfs2_xattr_get+0x104/0x28c fs/ocfs2/xattr.c:1338 ocfs2_xattr_security_get+0x40/0x54 fs/ocfs2/xattr.c:7231 __vfs_getxattr+0x394/0x3c0 fs/xattr.c:423 smk_fetch+0xc8/0x150 security/smack/smack_lsm.c:290 smack_d_instantiate+0x594/0x880 security/smack/smack_lsm.c:3599 security_d_instantiate+0x100/0x204 security/security.c:4079 d_instantiate+0x5c/0xa0 fs/dcache.c:1919 ocfs2_symlink+0x1dc8/0x24d0 fs/ocfs2/namei.c:2040 vfs_symlink+0x138/0x28c fs/namei.c:4671 do_symlinkat+0x1c4/0x46c fs/namei.c:4697 __do_sys_symlinkat fs/namei.c:4713 [inline] __se_sys_symlinkat fs/namei.c:4710 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4710 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600 other info that might help us debug this: Chain exists of: &oi->ip_xattr_sem --> &journal->j_trans_barrier --> jbd2_handle Possible unsafe locking scenario: CPU0 CPU1 ---- ---- rlock(jbd2_handle); lock(&journal->j_trans_barrier); lock(jbd2_handle); rlock(&oi->ip_xattr_sem); *** DEADLOCK *** 7 locks held by syz.5.243/7653: #0: ffff0000f00ce420 (sb_writers#24){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:547 #1: ffff0000f23eb480 (&type->i_mutex_dir_key#12/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:900 [inline] #1: ffff0000f23eb480 (&type->i_mutex_dir_key#12/1){+.+.}-{4:4}, at: filename_create+0x204/0x468 fs/namei.c:4082 #2: ffff0000f23e2640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:865 [inline] #2: ffff0000f23e2640 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#5){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x164/0x4254 fs/ocfs2/suballoc.c:786 #3: ffff0000dca5df40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:865 [inline] #3: ffff0000dca5df40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#6){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x108/0x24cc fs/ocfs2/localalloc.c:636 #4: ffff0000f00ce610 (sb_internal#4){.+.+}-{0:0}, at: ocfs2_symlink+0xc68/0x24d0 fs/ocfs2/namei.c:1927 #5: ffff0000cc6a54e8 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x3c4/0x71c fs/ocfs2/journal.c:350 #6: ffff0000e771c950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0xf0c/0x11c4 fs/jbd2/transaction.c:446 stack backtrace: CPU: 0 UID: 0 PID: 7653 Comm: syz.5.243 Not tainted 6.14.0-rc1-syzkaller-g2014c95afece #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call trace: show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C) __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120 dump_stack+0x1c/0x28 lib/dump_stack.c:129 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2076 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2208 check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain kernel/locking/lockdep.c:3906 [inline] __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5228 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5851 down_read+0x58/0x2fc kernel/locking/rwsem.c:1524 ocfs2_xattr_get+0x104/0x28c fs/ocfs2/xattr.c:1338 ocfs2_xattr_security_get+0x40/0x54 fs/ocfs2/xattr.c:7231 __vfs_getxattr+0x394/0x3c0 fs/xattr.c:423 smk_fetch+0xc8/0x150 security/smack/smack_lsm.c:290 smack_d_instantiate+0x594/0x880 security/smack/smack_lsm.c:3599 security_d_instantiate+0x100/0x204 security/security.c:4079 d_instantiate+0x5c/0xa0 fs/dcache.c:1919 ocfs2_symlink+0x1dc8/0x24d0 fs/ocfs2/namei.c:2040 vfs_symlink+0x138/0x28c fs/namei.c:4671 do_symlinkat+0x1c4/0x46c fs/namei.c:4697 __do_sys_symlinkat fs/namei.c:4713 [inline] __se_sys_symlinkat fs/namei.c:4710 [inline] __arm64_sys_symlinkat+0x9c/0xb4 fs/namei.c:4710 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline] invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600