====================================================== WARNING: possible circular locking dependency detected 6.1.24-syzkaller #0 Not tainted ------------------------------------------------------ syz-executor.2/13451 is trying to acquire lock: ffff0000d87e40f8 (&sbi->alloc_mutex){+.+.}-{3:3}, at: hfsplus_block_allocate+0x90/0x818 fs/hfsplus/bitmap.c:35 but task is already holding lock: ffff00012a1a8108 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 ( &HFSPLUS_I(inode)->extents_lock ){+.+.}-{3:3}: __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_get_block+0x2c4/0x1168 fs/hfsplus/extents.c:260 block_read_full_folio+0x2f4/0x98c fs/buffer.c:2271 hfsplus_read_folio+0x28/0x38 fs/hfsplus/inode.c:28 filemap_read_folio+0x14c/0x39c mm/filemap.c:2407 do_read_cache_folio+0x24c/0x544 mm/filemap.c:3535 do_read_cache_page mm/filemap.c:3577 [inline] read_cache_page+0x6c/0x180 mm/filemap.c:3586 read_mapping_page include/linux/pagemap.h:756 [inline] hfsplus_block_allocate+0xe0/0x818 fs/hfsplus/bitmap.c:37 hfsplus_file_extend+0x770/0x14cc fs/hfsplus/extents.c:468 hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245 __block_write_begin_int+0x340/0x13b4 fs/buffer.c:1991 __block_write_begin fs/buffer.c:2041 [inline] block_write_begin fs/buffer.c:2102 [inline] cont_write_begin+0x5c0/0x7d8 fs/buffer.c:2456 hfsplus_write_begin+0x98/0xe4 fs/hfsplus/inode.c:52 page_symlink+0x278/0x4a4 fs/namei.c:5121 hfsplus_symlink+0xc0/0x224 fs/hfsplus/dir.c:449 vfs_symlink+0x244/0x3a8 fs/namei.c:4401 do_symlinkat+0x364/0x6b0 fs/namei.c:4430 __do_sys_symlinkat fs/namei.c:4447 [inline] __se_sys_symlinkat fs/namei.c:4444 [inline] __arm64_sys_symlinkat+0xa4/0xbc fs/namei.c:4444 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 -> #0 (&sbi->alloc_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_block_allocate+0x90/0x818 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x770/0x14cc fs/hfsplus/extents.c:468 hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245 __block_write_full_page+0x2f8/0xef4 fs/buffer.c:1745 block_write_full_page+0x124/0x154 __mpage_writepage+0x10b4/0x13bc fs/mpage.c:629 write_cache_pages+0x7fc/0xf60 mm/page-writeback.c:2360 mpage_writepages+0x10c/0x1d0 fs/mpage.c:664 hfsplus_writepages+0x30/0x40 fs/hfsplus/inode.c:155 do_writepages+0x2e8/0x56c mm/page-writeback.c:2469 filemap_fdatawrite_wbc+0x124/0x174 mm/filemap.c:388 __filemap_fdatawrite_range mm/filemap.c:421 [inline] filemap_write_and_wait_range+0x17c/0x268 mm/filemap.c:674 filemap_write_and_wait include/linux/pagemap.h:60 [inline] hfsplus_file_fsync+0x368/0x4c8 fs/hfsplus/inode.c:349 vfs_fsync_range+0x168/0x188 fs/sync.c:188 generic_write_sync include/linux/fs.h:2897 [inline] generic_file_write_iter+0x228/0x2b4 mm/filemap.c:3918 call_write_iter include/linux/fs.h:2205 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x610/0x914 fs/read_write.c:584 ksys_write+0x15c/0x26c fs/read_write.c:637 __do_sys_write fs/read_write.c:649 [inline] __se_sys_write fs/read_write.c:646 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:646 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); lock(&HFSPLUS_I(inode)->extents_lock); lock(&sbi->alloc_mutex); *** DEADLOCK *** 4 locks held by syz-executor.2/13451: #0: ffff0000d9fbb4e8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0xd8/0x104 fs/file.c:1047 #1: ffff00011e634460 (sb_writers#18){.+.+}-{0:0}, at: vfs_write+0x244/0x914 fs/read_write.c:580 #2: ffff00012a1aab80 (&sb->s_type->i_mutex_key#24){++++}-{3:3}, at: inode_lock include/linux/fs.h:756 [inline] #2: ffff00012a1aab80 (&sb->s_type->i_mutex_key#24){++++}-{3:3}, at: hfsplus_file_fsync+0xd8/0x4c8 fs/hfsplus/inode.c:316 #3: ffff00012a1a8108 (&HFSPLUS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfsplus_file_extend+0x198/0x14cc fs/hfsplus/extents.c:457 stack backtrace: CPU: 1 PID: 13451 Comm: syz-executor.2 Not tainted 6.1.24-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call trace: dump_backtrace+0x1c8/0x1f4 arch/arm64/kernel/stacktrace.c:158 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:165 __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x108/0x170 lib/dump_stack.c:106 dump_stack+0x1c/0x5c lib/dump_stack.c:113 print_circular_bug+0x150/0x1b8 kernel/locking/lockdep.c:2056 check_noncircular+0x2cc/0x378 kernel/locking/lockdep.c:2178 check_prev_add kernel/locking/lockdep.c:3098 [inline] check_prevs_add kernel/locking/lockdep.c:3217 [inline] validate_chain kernel/locking/lockdep.c:3832 [inline] __lock_acquire+0x3338/0x764c kernel/locking/lockdep.c:5056 lock_acquire+0x26c/0x7cc kernel/locking/lockdep.c:5669 __mutex_lock_common+0x190/0x21a0 kernel/locking/mutex.c:603 __mutex_lock kernel/locking/mutex.c:747 [inline] mutex_lock_nested+0x38/0x44 kernel/locking/mutex.c:799 hfsplus_block_allocate+0x90/0x818 fs/hfsplus/bitmap.c:35 hfsplus_file_extend+0x770/0x14cc fs/hfsplus/extents.c:468 hfsplus_get_block+0x398/0x1168 fs/hfsplus/extents.c:245 __block_write_full_page+0x2f8/0xef4 fs/buffer.c:1745 block_write_full_page+0x124/0x154 __mpage_writepage+0x10b4/0x13bc fs/mpage.c:629 write_cache_pages+0x7fc/0xf60 mm/page-writeback.c:2360 mpage_writepages+0x10c/0x1d0 fs/mpage.c:664 hfsplus_writepages+0x30/0x40 fs/hfsplus/inode.c:155 do_writepages+0x2e8/0x56c mm/page-writeback.c:2469 filemap_fdatawrite_wbc+0x124/0x174 mm/filemap.c:388 __filemap_fdatawrite_range mm/filemap.c:421 [inline] filemap_write_and_wait_range+0x17c/0x268 mm/filemap.c:674 filemap_write_and_wait include/linux/pagemap.h:60 [inline] hfsplus_file_fsync+0x368/0x4c8 fs/hfsplus/inode.c:349 vfs_fsync_range+0x168/0x188 fs/sync.c:188 generic_write_sync include/linux/fs.h:2897 [inline] generic_file_write_iter+0x228/0x2b4 mm/filemap.c:3918 call_write_iter include/linux/fs.h:2205 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x610/0x914 fs/read_write.c:584 ksys_write+0x15c/0x26c fs/read_write.c:637 __do_sys_write fs/read_write.c:649 [inline] __se_sys_write fs/read_write.c:646 [inline] __arm64_sys_write+0x7c/0x90 fs/read_write.c:646 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline] invoke_syscall+0x98/0x2c0 arch/arm64/kernel/syscall.c:52 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142 do_el0_svc+0x64/0x218 arch/arm64/kernel/syscall.c:206 el0_svc+0x58/0x168 arch/arm64/kernel/entry-common.c:637 el0t_64_sync_handler+0x84/0xf0 arch/arm64/kernel/entry-common.c:655 el0t_64_sync+0x18c/0x190 arch/arm64/kernel/entry.S:581