===================================================== WARNING: SOFTIRQ-safe -> SOFTIRQ-unsafe lock order detected 5.7.0-rc1-syzkaller #0 Not tainted ----------------------------------------------------- syz-executor.4/26856 [HC0[0]:SC0[0]:HE0:SE1] is trying to acquire: ffff8880580239d8 (&info->lock){+.+.}-{2:2}, at: shmem_uncharge+0x34/0x4c0 mm/shmem.c:341 and this task is already holding: ffff888058023d28 (&xa->xa_lock#4){..-.}-{2:2}, at: spin_lock include/linux/spinlock.h:353 [inline] ffff888058023d28 (&xa->xa_lock#4){..-.}-{2:2}, at: split_huge_page_to_list+0xb89/0x15f0 mm/huge_memory.c:2864 which would create a new lock dependency: (&xa->xa_lock#4){..-.}-{2:2} -> (&info->lock){+.+.}-{2:2} but this new dependency connects a SOFTIRQ-irq-safe lock: (&xa->xa_lock#4){..-.}-{2:2} ... which became SOFTIRQ-irq-safe at: lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x9e/0xc0 kernel/locking/spinlock.c:159 test_clear_page_writeback+0x2d8/0xac0 mm/page-writeback.c:2728 end_page_writeback+0x212/0x390 mm/filemap.c:1317 end_bio_bh_io_sync+0xb1/0x110 fs/buffer.c:3012 req_bio_endio block/blk-core.c:245 [inline] blk_update_request+0x437/0x1070 block/blk-core.c:1472 scsi_end_request+0x7a/0x7f0 drivers/scsi/scsi_lib.c:575 scsi_io_completion+0x178/0x1be0 drivers/scsi/scsi_lib.c:959 blk_done_softirq+0x2f2/0x360 block/blk-softirq.c:37 __do_softirq+0x268/0x80c kernel/softirq.c:292 invoke_softirq kernel/softirq.c:373 [inline] irq_exit+0x223/0x230 kernel/softirq.c:413 exiting_irq arch/x86/include/asm/apic.h:546 [inline] do_IRQ+0xfb/0x1d0 arch/x86/kernel/irq.c:263 ret_from_intr+0x0/0x2b __read_once_size include/linux/compiler.h:199 [inline] check_kcov_mode kernel/kcov.c:155 [inline] __sanitizer_cov_trace_pc+0x22/0x50 kernel/kcov.c:187 tomoyo_domain_quota_is_ok+0x328/0x590 security/tomoyo/util.c:1032 tomoyo_supervisor+0x270/0x1310 security/tomoyo/common.c:2089 tomoyo_audit_path_log security/tomoyo/file.c:168 [inline] tomoyo_path_permission security/tomoyo/file.c:587 [inline] tomoyo_path_perm+0x4e3/0x740 security/tomoyo/file.c:838 security_inode_getattr+0xc0/0x140 security/security.c:1273 vfs_getattr+0x27/0x6e0 fs/stat.c:117 vfs_statx_fd fs/stat.c:147 [inline] vfs_fstat include/linux/fs.h:3295 [inline] __do_sys_newfstat fs/stat.c:388 [inline] __se_sys_newfstat fs/stat.c:385 [inline] __x64_sys_newfstat+0x9c/0x130 fs/stat.c:385 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 to a SOFTIRQ-irq-unsafe lock: (&info->lock){+.+.}-{2:2} ... which became SOFTIRQ-irq-unsafe at: ... lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151 spin_lock include/linux/spinlock.h:353 [inline] shmem_mfill_atomic_pte+0x13f4/0x1e10 mm/shmem.c:2402 shmem_mcopy_atomic_pte+0x3a/0x50 mm/shmem.c:2440 mfill_atomic_pte mm/userfaultfd.c:449 [inline] __mcopy_atomic mm/userfaultfd.c:582 [inline] mcopy_atomic+0x84f/0x1ba0 mm/userfaultfd.c:632 userfaultfd_copy fs/userfaultfd.c:1743 [inline] userfaultfd_ioctl+0x2289/0x4890 fs/userfaultfd.c:1941 vfs_ioctl fs/ioctl.c:47 [inline] ksys_ioctl fs/ioctl.c:763 [inline] __do_sys_ioctl fs/ioctl.c:772 [inline] __se_sys_ioctl+0xf9/0x160 fs/ioctl.c:770 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 other info that might help us debug this: Possible interrupt unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&info->lock); local_irq_disable(); lock(&xa->xa_lock#4); lock(&info->lock); lock(&xa->xa_lock#4); *** DEADLOCK *** 5 locks held by syz-executor.4/26856: #0: ffff88809d1b0450 (sb_writers#7){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2908 [inline] #0: ffff88809d1b0450 (sb_writers#7){.+.+}-{0:0}, at: vfs_fallocate+0x4cc/0x840 fs/open.c:308 #1: ffff888058023c30 (&sb->s_type->i_mutex_key#16){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:797 [inline] #1: ffff888058023c30 (&sb->s_type->i_mutex_key#16){+.+.}-{3:3}, at: shmem_fallocate+0xef/0xdb0 mm/shmem.c:2731 #2: ffff888058023df0 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: i_mmap_lock_read include/linux/fs.h:541 [inline] #2: ffff888058023df0 (&mapping->i_mmap_rwsem){++++}-{3:3}, at: split_huge_page_to_list+0x458/0x15f0 mm/huge_memory.c:2825 #3: ffff88812ffffcd8 (&pgdat->lru_lock){....}-{2:2}, at: split_huge_page_to_list+0x8ff/0x15f0 mm/huge_memory.c:2855 #4: ffff888058023d28 (&xa->xa_lock#4){..-.}-{2:2}, at: spin_lock include/linux/spinlock.h:353 [inline] #4: ffff888058023d28 (&xa->xa_lock#4){..-.}-{2:2}, at: split_huge_page_to_list+0xb89/0x15f0 mm/huge_memory.c:2864 the dependencies between SOFTIRQ-irq-safe lock and the holding lock: -> (&xa->xa_lock#4){..-.}-{2:2} { IN-SOFTIRQ-W at: lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x9e/0xc0 kernel/locking/spinlock.c:159 test_clear_page_writeback+0x2d8/0xac0 mm/page-writeback.c:2728 end_page_writeback+0x212/0x390 mm/filemap.c:1317 end_bio_bh_io_sync+0xb1/0x110 fs/buffer.c:3012 req_bio_endio block/blk-core.c:245 [inline] blk_update_request+0x437/0x1070 block/blk-core.c:1472 scsi_end_request+0x7a/0x7f0 drivers/scsi/scsi_lib.c:575 scsi_io_completion+0x178/0x1be0 drivers/scsi/scsi_lib.c:959 blk_done_softirq+0x2f2/0x360 block/blk-softirq.c:37 __do_softirq+0x268/0x80c kernel/softirq.c:292 invoke_softirq kernel/softirq.c:373 [inline] irq_exit+0x223/0x230 kernel/softirq.c:413 exiting_irq arch/x86/include/asm/apic.h:546 [inline] do_IRQ+0xfb/0x1d0 arch/x86/kernel/irq.c:263 ret_from_intr+0x0/0x2b __read_once_size include/linux/compiler.h:199 [inline] check_kcov_mode kernel/kcov.c:155 [inline] __sanitizer_cov_trace_pc+0x22/0x50 kernel/kcov.c:187 tomoyo_domain_quota_is_ok+0x328/0x590 security/tomoyo/util.c:1032 tomoyo_supervisor+0x270/0x1310 security/tomoyo/common.c:2089 tomoyo_audit_path_log security/tomoyo/file.c:168 [inline] tomoyo_path_permission security/tomoyo/file.c:587 [inline] tomoyo_path_perm+0x4e3/0x740 security/tomoyo/file.c:838 security_inode_getattr+0xc0/0x140 security/security.c:1273 vfs_getattr+0x27/0x6e0 fs/stat.c:117 vfs_statx_fd fs/stat.c:147 [inline] vfs_fstat include/linux/fs.h:3295 [inline] __do_sys_newfstat fs/stat.c:388 [inline] __se_sys_newfstat fs/stat.c:385 [inline] __x64_sys_newfstat+0x9c/0x130 fs/stat.c:385 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 INITIAL USE at: lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:128 [inline] _raw_spin_lock_irq+0x67/0x80 kernel/locking/spinlock.c:167 spin_lock_irq include/linux/spinlock.h:378 [inline] __add_to_page_cache_locked+0x53d/0xc70 mm/filemap.c:855 add_to_page_cache_lru+0x17f/0x4d0 mm/filemap.c:921 do_read_cache_page+0x209/0xd00 mm/filemap.c:2755 read_mapping_page include/linux/pagemap.h:397 [inline] read_part_sector+0xd8/0x2d0 block/partitions/core.c:643 adfspart_check_ICS+0x45/0x640 block/partitions/acorn.c:360 check_partition block/partitions/core.c:140 [inline] blk_add_partitions+0x3ce/0x1240 block/partitions/core.c:571 bdev_disk_changed+0x446/0x5d0 fs/block_dev.c:1544 __blkdev_get+0xb2b/0x13d0 fs/block_dev.c:1647 register_disk block/genhd.c:763 [inline] __device_add_disk+0x95f/0x1040 block/genhd.c:853 add_disk include/linux/genhd.h:294 [inline] brd_init+0x349/0x42a drivers/block/brd.c:533 do_one_initcall+0x14b/0x350 init/main.c:1157 do_initcall_level+0x101/0x14c init/main.c:1230 do_initcalls+0x59/0x9b init/main.c:1246 kernel_init_freeable+0x2fa/0x418 init/main.c:1450 kernel_init+0xd/0x290 init/main.c:1357 ret_from_fork+0x24/0x30 arch/x86/entry/entry_64.S:352 } ... key at: [] xa_init_flags.__key+0x0/0x10 ... acquired at: lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x9e/0xc0 kernel/locking/spinlock.c:159 shmem_uncharge+0x34/0x4c0 mm/shmem.c:341 __split_huge_page+0xda8/0x1900 mm/huge_memory.c:2613 split_huge_page_to_list+0x10a4/0x15f0 mm/huge_memory.c:2886 split_huge_page include/linux/huge_mm.h:204 [inline] shmem_punch_compound+0x17d/0x1c0 mm/shmem.c:814 shmem_undo_range+0x5da/0x1d00 mm/shmem.c:870 shmem_fallocate+0xcc2/0xdb0 mm/shmem.c:2810 vfs_fallocate+0x56e/0x840 fs/open.c:309 ksys_fallocate fs/open.c:332 [inline] __do_sys_fallocate fs/open.c:340 [inline] __se_sys_fallocate fs/open.c:338 [inline] __x64_sys_fallocate+0xb9/0x100 fs/open.c:338 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 the dependencies between the lock to be acquired and SOFTIRQ-irq-unsafe lock: -> (&info->lock){+.+.}-{2:2} { HARDIRQ-ON-W at: lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151 spin_lock include/linux/spinlock.h:353 [inline] shmem_mfill_atomic_pte+0x13f4/0x1e10 mm/shmem.c:2402 shmem_mcopy_atomic_pte+0x3a/0x50 mm/shmem.c:2440 mfill_atomic_pte mm/userfaultfd.c:449 [inline] __mcopy_atomic mm/userfaultfd.c:582 [inline] mcopy_atomic+0x84f/0x1ba0 mm/userfaultfd.c:632 userfaultfd_copy fs/userfaultfd.c:1743 [inline] userfaultfd_ioctl+0x2289/0x4890 fs/userfaultfd.c:1941 vfs_ioctl fs/ioctl.c:47 [inline] ksys_ioctl fs/ioctl.c:763 [inline] __do_sys_ioctl fs/ioctl.c:772 [inline] __se_sys_ioctl+0xf9/0x160 fs/ioctl.c:770 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 SOFTIRQ-ON-W at: lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock include/linux/spinlock_api_smp.h:142 [inline] _raw_spin_lock+0x2a/0x40 kernel/locking/spinlock.c:151 spin_lock include/linux/spinlock.h:353 [inline] shmem_mfill_atomic_pte+0x13f4/0x1e10 mm/shmem.c:2402 shmem_mcopy_atomic_pte+0x3a/0x50 mm/shmem.c:2440 mfill_atomic_pte mm/userfaultfd.c:449 [inline] __mcopy_atomic mm/userfaultfd.c:582 [inline] mcopy_atomic+0x84f/0x1ba0 mm/userfaultfd.c:632 userfaultfd_copy fs/userfaultfd.c:1743 [inline] userfaultfd_ioctl+0x2289/0x4890 fs/userfaultfd.c:1941 vfs_ioctl fs/ioctl.c:47 [inline] ksys_ioctl fs/ioctl.c:763 [inline] __do_sys_ioctl fs/ioctl.c:772 [inline] __se_sys_ioctl+0xf9/0x160 fs/ioctl.c:770 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 INITIAL USE at: lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock_irq include/linux/spinlock_api_smp.h:128 [inline] _raw_spin_lock_irq+0x67/0x80 kernel/locking/spinlock.c:167 spin_lock_irq include/linux/spinlock.h:378 [inline] shmem_getpage_gfp+0x2160/0x3120 mm/shmem.c:1882 shmem_getpage mm/shmem.c:154 [inline] shmem_write_begin+0xcd/0x1a0 mm/shmem.c:2483 generic_perform_write+0x23b/0x4e0 mm/filemap.c:3302 __generic_file_write_iter+0x22b/0x4e0 mm/filemap.c:3431 generic_file_write_iter+0x4a6/0x650 mm/filemap.c:3463 call_write_iter include/linux/fs.h:1907 [inline] new_sync_write fs/read_write.c:484 [inline] __vfs_write+0x54c/0x710 fs/read_write.c:497 vfs_write+0x274/0x580 fs/read_write.c:559 ksys_write+0x11b/0x220 fs/read_write.c:612 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 } ... key at: [] shmem_get_inode.__key+0x0/0x10 ... acquired at: lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x9e/0xc0 kernel/locking/spinlock.c:159 shmem_uncharge+0x34/0x4c0 mm/shmem.c:341 __split_huge_page+0xda8/0x1900 mm/huge_memory.c:2613 split_huge_page_to_list+0x10a4/0x15f0 mm/huge_memory.c:2886 split_huge_page include/linux/huge_mm.h:204 [inline] shmem_punch_compound+0x17d/0x1c0 mm/shmem.c:814 shmem_undo_range+0x5da/0x1d00 mm/shmem.c:870 shmem_fallocate+0xcc2/0xdb0 mm/shmem.c:2810 vfs_fallocate+0x56e/0x840 fs/open.c:309 ksys_fallocate fs/open.c:332 [inline] __do_sys_fallocate fs/open.c:340 [inline] __se_sys_fallocate fs/open.c:338 [inline] __x64_sys_fallocate+0xb9/0x100 fs/open.c:338 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 stack backtrace: CPU: 1 PID: 26856 Comm: syz-executor.4 Not tainted 5.7.0-rc1-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x1e9/0x30e lib/dump_stack.c:118 print_bad_irq_dependency kernel/locking/lockdep.c:2132 [inline] check_irq_usage kernel/locking/lockdep.c:2330 [inline] check_prev_add kernel/locking/lockdep.c:2519 [inline] check_prevs_add kernel/locking/lockdep.c:2620 [inline] validate_chain+0x8479/0x8920 kernel/locking/lockdep.c:3237 __lock_acquire+0x116c/0x2c30 kernel/locking/lockdep.c:4355 lock_acquire+0x169/0x480 kernel/locking/lockdep.c:4934 __raw_spin_lock_irqsave include/linux/spinlock_api_smp.h:110 [inline] _raw_spin_lock_irqsave+0x9e/0xc0 kernel/locking/spinlock.c:159 shmem_uncharge+0x34/0x4c0 mm/shmem.c:341 __split_huge_page+0xda8/0x1900 mm/huge_memory.c:2613 split_huge_page_to_list+0x10a4/0x15f0 mm/huge_memory.c:2886 split_huge_page include/linux/huge_mm.h:204 [inline] shmem_punch_compound+0x17d/0x1c0 mm/shmem.c:814 shmem_undo_range+0x5da/0x1d00 mm/shmem.c:870 shmem_fallocate+0xcc2/0xdb0 mm/shmem.c:2810 vfs_fallocate+0x56e/0x840 fs/open.c:309 ksys_fallocate fs/open.c:332 [inline] __do_sys_fallocate fs/open.c:340 [inline] __se_sys_fallocate fs/open.c:338 [inline] __x64_sys_fallocate+0xb9/0x100 fs/open.c:338 do_syscall_64+0xf3/0x1b0 arch/x86/entry/common.c:295 entry_SYSCALL_64_after_hwframe+0x49/0xb3 RIP: 0033:0x45c889 Code: ad b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 7b b6 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007fb6825d7c78 EFLAGS: 00000246 ORIG_RAX: 000000000000011d RAX: ffffffffffffffda RBX: 00007fb6825d86d4 RCX: 000000000045c889 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000008 RBP: 000000000076bfa0 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000008800000 R11: 0000000000000246 R12: 00000000ffffffff R13: 00000000000000ae R14: 00000000004c342d R15: 000000000076bfac