WARNING: possible circular locking dependency detected 6.8.0-rc1-syzkaller-00169-gecb1b8288dc7 #0 Not tainted ------------------------------------------------------ syz-executor.4/11090 is trying to acquire lock: ffff88807a697700 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ffff88807a697700 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0x787/0x1070 fs/ntfs3/file.c:548 but task is already holding lock: ffff88807a697b40 (mapping.invalidate_lock#3){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:847 [inline] ffff88807a697b40 (mapping.invalidate_lock#3){++++}-{3:3}, at: ntfs_fallocate+0x3ac/0x1070 fs/ntfs3/file.c:484 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (mapping.invalidate_lock#3){++++}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 filemap_invalidate_lock_shared include/linux/fs.h:857 [inline] filemap_fault+0x646/0x1670 mm/filemap.c:3237 __do_fault+0x131/0x450 mm/memory.c:4376 do_read_fault mm/memory.c:4738 [inline] do_fault mm/memory.c:4868 [inline] do_pte_missing mm/memory.c:3745 [inline] handle_pte_fault mm/memory.c:5144 [inline] __handle_mm_fault+0x49d7/0x72b0 mm/memory.c:5285 handle_mm_fault+0x27e/0x770 mm/memory.c:5450 faultin_page mm/gup.c:958 [inline] __get_user_pages+0x6bd/0x15f0 mm/gup.c:1241 __get_user_pages_locked mm/gup.c:1509 [inline] __gup_longterm_locked+0x24e1/0x2bf0 mm/gup.c:2211 internal_get_user_pages_fast+0x27ed/0x2f60 mm/gup.c:3215 pin_user_pages_fast+0xcc/0x160 mm/gup.c:3321 iov_iter_extract_user_pages lib/iov_iter.c:1604 [inline] iov_iter_extract_pages+0x3db/0x720 lib/iov_iter.c:1667 dio_refill_pages fs/direct-io.c:173 [inline] dio_get_page fs/direct-io.c:214 [inline] do_direct_IO fs/direct-io.c:914 [inline] __blockdev_direct_IO+0x1506/0x49a0 fs/direct-io.c:1248 blockdev_direct_IO include/linux/fs.h:3118 [inline] ntfs_direct_IO+0x195/0x370 fs/ntfs3/inode.c:792 generic_file_direct_write+0x1e3/0x3f0 mm/filemap.c:3855 __generic_file_write_iter+0x125/0x230 mm/filemap.c:4011 ntfs_file_write_iter+0x5fe/0x6e0 fs/ntfs3/file.c:1082 do_iter_readv_writev+0x469/0x630 vfs_writev+0x395/0xba0 fs/read_write.c:971 do_pwritev fs/read_write.c:1072 [inline] __do_sys_pwritev2 fs/read_write.c:1131 [inline] __se_sys_pwritev2+0x1ca/0x2d0 fs/read_write.c:1122 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #2 (&mm->mmap_lock){++++}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __might_fault+0xc1/0x120 mm/memory.c:6060 _copy_to_user+0x2a/0xa0 lib/usercopy.c:36 copy_to_user include/linux/uaccess.h:191 [inline] fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145 ni_fiemap+0xa5e/0x1230 fs/ntfs3/frecord.c:2065 ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1164 ioctl_fiemap fs/ioctl.c:220 [inline] do_vfs_ioctl+0x19ea/0x2b40 fs/ioctl.c:811 __do_sys_ioctl fs/ioctl.c:869 [inline] __se_sys_ioctl+0x81/0x170 fs/ioctl.c:857 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #1 (&indx->run_lock){.+.+}-{3:3}: lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526 indx_read+0x2a5/0xc40 fs/ntfs3/index.c:1066 indx_find+0x46b/0xb60 fs/ntfs3/index.c:1181 dir_search_u+0x1b7/0x3a0 fs/ntfs3/dir.c:254 ntfs_lookup+0x106/0x1f0 fs/ntfs3/namei.c:85 __lookup_slow+0x282/0x3e0 fs/namei.c:1693 lookup_slow+0x53/0x70 fs/namei.c:1710 walk_component+0x2d0/0x400 fs/namei.c:2001 lookup_last fs/namei.c:2458 [inline] path_lookupat+0x16f/0x450 fs/namei.c:2482 filename_lookup+0x255/0x610 fs/namei.c:2511 user_path_at_empty+0x42/0x60 fs/namei.c:2920 user_path_at include/linux/namei.h:57 [inline] do_fchownat+0xf0/0x240 fs/open.c:813 __do_sys_lchown fs/open.c:844 [inline] __se_sys_lchown fs/open.c:842 [inline] __x64_sys_lchown+0x85/0x90 fs/open.c:842 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x1909/0x5ab0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ntfs_fallocate+0x787/0x1070 fs/ntfs3/file.c:548 vfs_fallocate+0x55c/0x6c0 fs/open.c:328 ksys_fallocate fs/open.c:351 [inline] __do_sys_fallocate fs/open.c:359 [inline] __se_sys_fallocate fs/open.c:357 [inline] __x64_sys_fallocate+0xbd/0x100 fs/open.c:357 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Chain exists of: &ni->ni_lock/4 --> &mm->mmap_lock --> mapping.invalidate_lock#3 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(mapping.invalidate_lock#3); lock(&mm->mmap_lock); lock(mapping.invalidate_lock#3); lock(&ni->ni_lock/4); *** DEADLOCK *** 3 locks held by syz-executor.4/11090: #0: ffff8880338ae420 (sb_writers#18){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2795 [inline] #0: ffff8880338ae420 (sb_writers#18){.+.+}-{0:0}, at: vfs_fallocate+0x4cf/0x6c0 fs/open.c:327 #1: ffff88807a6979a0 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #1: ffff88807a6979a0 (&sb->s_type->i_mutex_key#24){+.+.}-{3:3}, at: ntfs_fallocate+0x2dd/0x1070 fs/ntfs3/file.c:470 #2: ffff88807a697b40 (mapping.invalidate_lock#3){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:847 [inline] #2: ffff88807a697b40 (mapping.invalidate_lock#3){++++}-{3:3}, at: ntfs_fallocate+0x3ac/0x1070 fs/ntfs3/file.c:484 stack backtrace: CPU: 0 PID: 11090 Comm: syz-executor.4 Not tainted 6.8.0-rc1-syzkaller-00169-gecb1b8288dc7 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/17/2023 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e7/0x2d0 lib/dump_stack.c:106 check_noncircular+0x366/0x490 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain+0x1909/0x5ab0 kernel/locking/lockdep.c:3869 __lock_acquire+0x1345/0x1fd0 kernel/locking/lockdep.c:5137 lock_acquire+0x1e3/0x530 kernel/locking/lockdep.c:5754 __mutex_lock_common kernel/locking/mutex.c:608 [inline] __mutex_lock+0x136/0xd60 kernel/locking/mutex.c:752 ni_lock fs/ntfs3/ntfs_fs.h:1124 [inline] ntfs_fallocate+0x787/0x1070 fs/ntfs3/file.c:548 vfs_fallocate+0x55c/0x6c0 fs/open.c:328 ksys_fallocate fs/open.c:351 [inline] __do_sys_fallocate fs/open.c:359 [inline] __se_sys_fallocate fs/open.c:357 [inline] __x64_sys_fallocate+0xbd/0x100 fs/open.c:357 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf5/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f0780a7cda9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f07817a10c8 EFLAGS: 00000246 ORIG_RAX: 000000000000011d RAX: ffffffffffffffda RBX: 00007f0780bac050 RCX: 00007f0780a7cda9 RDX: 0000000000000000 RSI: 0000000000000008 RDI: 0000000000000004 RBP: 00007f0780ac947a R08: 0000000000000000 R09: 0000000000000000 R10: 00000000000000c0 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000006e R14: 00007f0780bac050 R15: 00007ffd7acf4488