======================================================
WARNING: possible circular locking dependency detected
6.9.0-rc6-syzkaller-00133-g19e35f24750d #0 Not tainted
------------------------------------------------------
syz-executor.0/28799 is trying to acquire lock:
ffff888064c9f238 (&psock->ingress_lock){+...}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff888064c9f238 (&psock->ingress_lock){+...}-{2:2}, at: sk_psock_stop net/core/skmsg.c:802 [inline]
ffff888064c9f238 (&psock->ingress_lock){+...}-{2:2}, at: sk_psock_drop+0x2fb/0x500 net/core/skmsg.c:846

but task is already holding lock:
ffff88805d532200 (&stab->lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
ffff88805d532200 (&stab->lock){+.-.}-{2:2}, at: __sock_map_delete net/core/sock_map.c:417 [inline]
ffff88805d532200 (&stab->lock){+.-.}-{2:2}, at: sock_map_delete_elem+0x175/0x250 net/core/sock_map.c:449

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&stab->lock){+.-.}-{2:2}:
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:356 [inline]
       __sock_map_delete net/core/sock_map.c:417 [inline]
       sock_map_delete_elem+0x175/0x250 net/core/sock_map.c:449
       0xffffffffa000216a
       bpf_dispatcher_nop_func include/linux/bpf.h:1234 [inline]
       __bpf_prog_run include/linux/filter.h:657 [inline]
       bpf_prog_run include/linux/filter.h:664 [inline]
       __bpf_trace_run kernel/trace/bpf_trace.c:2381 [inline]
       bpf_trace_run2+0x204/0x420 kernel/trace/bpf_trace.c:2420
       trace_kfree include/trace/events/kmem.h:94 [inline]
       kfree+0x2af/0x3a0 mm/slub.c:4377
       sk_psock_cork_free include/linux/skmsg.h:430 [inline]
       sk_psock_stop+0xc5/0x110 net/core/skmsg.c:804
       sock_map_close+0x1b2/0x2d0 net/core/sock_map.c:1651
       inet_release+0x17d/0x200 net/ipv4/af_inet.c:437
       __sock_release net/socket.c:659 [inline]
       sock_close+0xbc/0x240 net/socket.c:1421
       __fput+0x429/0x8a0 fs/file_table.c:422
       task_work_run+0x24f/0x310 kernel/task_work.c:180
       exit_task_work include/linux/task_work.h:38 [inline]
       do_exit+0xa1b/0x27e0 kernel/exit.c:878
       do_group_exit+0x207/0x2c0 kernel/exit.c:1027
       get_signal+0x16a1/0x1740 kernel/signal.c:2911
       arch_do_signal_or_restart+0x96/0x860 arch/x86/kernel/signal.c:310
       exit_to_user_mode_loop kernel/entry/common.c:111 [inline]
       exit_to_user_mode_prepare include/linux/entry-common.h:328 [inline]
       __syscall_exit_to_user_mode_work kernel/entry/common.c:207 [inline]
       syscall_exit_to_user_mode+0xc9/0x370 kernel/entry/common.c:218
       do_syscall_64+0x102/0x240 arch/x86/entry/common.c:89
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&psock->ingress_lock){+...}-{2:2}:
       check_prev_add kernel/locking/lockdep.c:3134 [inline]
       check_prevs_add kernel/locking/lockdep.c:3253 [inline]
       validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869
       __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
       lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
       __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
       _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
       spin_lock_bh include/linux/spinlock.h:356 [inline]
       sk_psock_stop net/core/skmsg.c:802 [inline]
       sk_psock_drop+0x2fb/0x500 net/core/skmsg.c:846
       __sock_map_delete net/core/sock_map.c:423 [inline]
       sock_map_delete_elem+0x1a2/0x250 net/core/sock_map.c:449
       bpf_prog_8a405b5ced52e191+0x4a/0x4e
       bpf_dispatcher_nop_func include/linux/bpf.h:1234 [inline]
       __bpf_prog_run include/linux/filter.h:657 [inline]
       bpf_prog_run include/linux/filter.h:664 [inline]
       __bpf_trace_run kernel/trace/bpf_trace.c:2381 [inline]
       bpf_trace_run1+0x1e0/0x3f0 kernel/trace/bpf_trace.c:2419
       trace_ext4_request_blocks include/trace/events/ext4.h:818 [inline]
       ext4_mb_new_blocks+0x4718/0x4bf0 fs/ext4/mballoc.c:6140
       ext4_ext_map_blocks+0x1c74/0x77b0 fs/ext4/extents.c:4317
       ext4_map_blocks+0xa5e/0x1d20 fs/ext4/inode.c:623
       mpage_map_one_extent fs/ext4/inode.c:2163 [inline]
       mpage_map_and_submit_extent fs/ext4/inode.c:2216 [inline]
       ext4_do_writepages+0x1605/0x3d40 fs/ext4/inode.c:2679
       ext4_writepages+0x213/0x3c0 fs/ext4/inode.c:2768
       do_writepages+0x359/0x870 mm/page-writeback.c:2612
       filemap_fdatawrite_wbc+0x125/0x180 mm/filemap.c:397
       __filemap_fdatawrite_range mm/filemap.c:430 [inline]
       filemap_write_and_wait_range+0x198/0x290 mm/filemap.c:685
       ext4_punch_hole+0x1b2/0xc00 fs/ext4/inode.c:3893
       ext4_fallocate+0x322/0x1ff0 fs/ext4/extents.c:4741
       vfs_fallocate+0x564/0x6c0 fs/open.c:330
       do_vfs_ioctl+0x2592/0x2e50 fs/ioctl.c:883
       __do_sys_ioctl fs/ioctl.c:902 [inline]
       __se_sys_ioctl+0x81/0x170 fs/ioctl.c:890
       do_syscall_x64 arch/x86/entry/common.c:52 [inline]
       do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&stab->lock);
                               lock(&psock->ingress_lock);
                               lock(&stab->lock);
  lock(&psock->ingress_lock);

 *** DEADLOCK ***

6 locks held by syz-executor.0/28799:
 #0: ffff8880424bc420 (sb_writers#4){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2855 [inline]
 #0: ffff8880424bc420 (sb_writers#4){.+.+}-{0:0}, at: vfs_fallocate+0x4d3/0x6c0 fs/open.c:329
 #1: ffff8880424beb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_writepages_down_read fs/ext4/ext4.h:1769 [inline]
 #1: ffff8880424beb98 (&sbi->s_writepages_rwsem){++++}-{0:0}, at: ext4_writepages+0x1bf/0x3c0 fs/ext4/inode.c:2767
 #2: ffff8880424c8950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x203f/0x22a0 fs/jbd2/transaction.c:463
 #3: ffff88806075e688 (&ei->i_data_sem){++++}-{3:3}, at: ext4_map_blocks+0x988/0x1d20 fs/ext4/inode.c:616
 #4: ffffffff8e334da0 (rcu_read_lock){....}-{1:2}, at: rcu_lock_acquire include/linux/rcupdate.h:329 [inline]
 #4: ffffffff8e334da0 (rcu_read_lock){....}-{1:2}, at: rcu_read_lock include/linux/rcupdate.h:781 [inline]
 #4: ffffffff8e334da0 (rcu_read_lock){....}-{1:2}, at: __bpf_trace_run kernel/trace/bpf_trace.c:2380 [inline]
 #4: ffffffff8e334da0 (rcu_read_lock){....}-{1:2}, at: bpf_trace_run1+0xf0/0x3f0 kernel/trace/bpf_trace.c:2419
 #5: ffff88805d532200 (&stab->lock){+.-.}-{2:2}, at: spin_lock_bh include/linux/spinlock.h:356 [inline]
 #5: ffff88805d532200 (&stab->lock){+.-.}-{2:2}, at: __sock_map_delete net/core/sock_map.c:417 [inline]
 #5: ffff88805d532200 (&stab->lock){+.-.}-{2:2}, at: sock_map_delete_elem+0x175/0x250 net/core/sock_map.c:449

stack backtrace:
CPU: 1 PID: 28799 Comm: syz-executor.0 Not tainted 6.9.0-rc6-syzkaller-00133-g19e35f24750d #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/27/2024
Call Trace:
 <TASK>
 __dump_stack lib/dump_stack.c:88 [inline]
 dump_stack_lvl+0x241/0x360 lib/dump_stack.c:114
 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2187
 check_prev_add kernel/locking/lockdep.c:3134 [inline]
 check_prevs_add kernel/locking/lockdep.c:3253 [inline]
 validate_chain+0x18cb/0x58e0 kernel/locking/lockdep.c:3869
 __lock_acquire+0x1346/0x1fd0 kernel/locking/lockdep.c:5137
 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5754
 __raw_spin_lock_bh include/linux/spinlock_api_smp.h:126 [inline]
 _raw_spin_lock_bh+0x35/0x50 kernel/locking/spinlock.c:178
 spin_lock_bh include/linux/spinlock.h:356 [inline]
 sk_psock_stop net/core/skmsg.c:802 [inline]
 sk_psock_drop+0x2fb/0x500 net/core/skmsg.c:846
 __sock_map_delete net/core/sock_map.c:423 [inline]
 sock_map_delete_elem+0x1a2/0x250 net/core/sock_map.c:449
 bpf_prog_8a405b5ced52e191+0x4a/0x4e
 bpf_dispatcher_nop_func include/linux/bpf.h:1234 [inline]
 __bpf_prog_run include/linux/filter.h:657 [inline]
 bpf_prog_run include/linux/filter.h:664 [inline]
 __bpf_trace_run kernel/trace/bpf_trace.c:2381 [inline]
 bpf_trace_run1+0x1e0/0x3f0 kernel/trace/bpf_trace.c:2419
 trace_ext4_request_blocks include/trace/events/ext4.h:818 [inline]
 ext4_mb_new_blocks+0x4718/0x4bf0 fs/ext4/mballoc.c:6140
 ext4_ext_map_blocks+0x1c74/0x77b0 fs/ext4/extents.c:4317
 ext4_map_blocks+0xa5e/0x1d20 fs/ext4/inode.c:623
 mpage_map_one_extent fs/ext4/inode.c:2163 [inline]
 mpage_map_and_submit_extent fs/ext4/inode.c:2216 [inline]
 ext4_do_writepages+0x1605/0x3d40 fs/ext4/inode.c:2679
 ext4_writepages+0x213/0x3c0 fs/ext4/inode.c:2768
 do_writepages+0x359/0x870 mm/page-writeback.c:2612
 filemap_fdatawrite_wbc+0x125/0x180 mm/filemap.c:397
 __filemap_fdatawrite_range mm/filemap.c:430 [inline]
 filemap_write_and_wait_range+0x198/0x290 mm/filemap.c:685
 ext4_punch_hole+0x1b2/0xc00 fs/ext4/inode.c:3893
 ext4_fallocate+0x322/0x1ff0 fs/ext4/extents.c:4741
 vfs_fallocate+0x564/0x6c0 fs/open.c:330
 do_vfs_ioctl+0x2592/0x2e50 fs/ioctl.c:883
 __do_sys_ioctl fs/ioctl.c:902 [inline]
 __se_sys_ioctl+0x81/0x170 fs/ioctl.c:890
 do_syscall_x64 arch/x86/entry/common.c:52 [inline]
 do_syscall_64+0xf5/0x240 arch/x86/entry/common.c:83
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7eff4747dd69
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007eff482360c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007eff475abf80 RCX: 00007eff4747dd69
RDX: 0000000020000280 RSI: 000000004030582b RDI: 0000000000000011
RBP: 00007eff474ca49e R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 000000000000000b R14: 00007eff475abf80 R15: 00007ffcb3f67cb8
 </TASK>