======================================================
WARNING: possible circular locking dependency detected
4.19.205-syzkaller #0 Not tainted
------------------------------------------------------
syz-executor.1/20897 is trying to acquire lock:
00000000ae070643 (&ovl_i_mutex_dir_key[depth]){++++}, at: inode_lock_shared include/linux/fs.h:758 [inline]
00000000ae070643 (&ovl_i_mutex_dir_key[depth]){++++}, at: lookup_slow fs/namei.c:1688 [inline]
00000000ae070643 (&ovl_i_mutex_dir_key[depth]){++++}, at: lookup_one_len_unlocked+0x111/0x140 fs/namei.c:2573

but task is already holding lock:
00000000fe06e293 (&ovl_i_mutex_dir_key[depth]#2){.+.+}, at: inode_lock_shared include/linux/fs.h:758 [inline]
00000000fe06e293 (&ovl_i_mutex_dir_key[depth]#2){.+.+}, at: lookup_slow fs/namei.c:1688 [inline]
00000000fe06e293 (&ovl_i_mutex_dir_key[depth]#2){.+.+}, at: walk_component+0x798/0xda0 fs/namei.c:1811

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&ovl_i_mutex_dir_key[depth]#2){.+.+}:
       inode_lock_shared include/linux/fs.h:758 [inline]
       lookup_slow fs/namei.c:1688 [inline]
       walk_component+0x798/0xda0 fs/namei.c:1811
       link_path_walk.part.0+0x901/0x1230 fs/namei.c:2142
       link_path_walk fs/namei.c:2073 [inline]
       path_openat+0x1db/0x2df0 fs/namei.c:3536
       do_filp_open+0x18c/0x3f0 fs/namei.c:3567
       do_open_execat+0x11d/0x5b0 fs/exec.c:853
       __do_execve_file+0x1a8b/0x2360 fs/exec.c:1770
       do_execveat_common fs/exec.c:1879 [inline]
       do_execve+0x35/0x50 fs/exec.c:1896
       __do_sys_execve fs/exec.c:1977 [inline]
       __se_sys_execve fs/exec.c:1972 [inline]
       __x64_sys_execve+0x7c/0xa0 fs/exec.c:1972
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #3 (&sig->cred_guard_mutex){+.+.}:
       lock_trace fs/proc/base.c:402 [inline]
       proc_pid_stack+0x160/0x350 fs/proc/base.c:452
       proc_single_show+0xeb/0x170 fs/proc/base.c:755
       seq_read+0x4e0/0x11c0 fs/seq_file.c:232
       do_loop_readv_writev fs/read_write.c:701 [inline]
       do_loop_readv_writev fs/read_write.c:688 [inline]
       do_iter_read+0x471/0x630 fs/read_write.c:925
       vfs_readv+0xe5/0x150 fs/read_write.c:987
       kernel_readv fs/splice.c:362 [inline]
       default_file_splice_read+0x457/0xa00 fs/splice.c:417
       do_splice_to+0x10e/0x160 fs/splice.c:881
       splice_direct_to_actor+0x2b9/0x8d0 fs/splice.c:959
       do_splice_direct+0x1a7/0x270 fs/splice.c:1068
       do_sendfile+0x550/0xc30 fs/read_write.c:1447
       __do_sys_sendfile64 fs/read_write.c:1508 [inline]
       __se_sys_sendfile64+0x147/0x160 fs/read_write.c:1494
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #2 (&p->lock){+.+.}:
       seq_read+0x6b/0x11c0 fs/seq_file.c:164
       proc_reg_read+0x1bd/0x2d0 fs/proc/inode.c:231
       do_loop_readv_writev fs/read_write.c:701 [inline]
       do_loop_readv_writev fs/read_write.c:688 [inline]
       do_iter_read+0x471/0x630 fs/read_write.c:925
       vfs_readv+0xe5/0x150 fs/read_write.c:987
       kernel_readv fs/splice.c:362 [inline]
       default_file_splice_read+0x457/0xa00 fs/splice.c:417
       do_splice_to+0x10e/0x160 fs/splice.c:881
       splice_direct_to_actor+0x2b9/0x8d0 fs/splice.c:959
       do_splice_direct+0x1a7/0x270 fs/splice.c:1068
       do_sendfile+0x550/0xc30 fs/read_write.c:1447
       __do_sys_sendfile64 fs/read_write.c:1508 [inline]
       __se_sys_sendfile64+0x147/0x160 fs/read_write.c:1494
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #1 (sb_writers#3){.+.+}:
       sb_start_write include/linux/fs.h:1579 [inline]
       mnt_want_write+0x3a/0xb0 fs/namespace.c:360
       ovl_do_remove+0xf0/0xdb0 fs/overlayfs/dir.c:843
       vfs_rmdir.part.0+0x10f/0x3d0 fs/namei.c:3882
       vfs_rmdir fs/namei.c:3868 [inline]
       do_rmdir+0x3fd/0x490 fs/namei.c:3943
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

-> #0 (&ovl_i_mutex_dir_key[depth]){++++}:
       down_read+0x36/0x80 kernel/locking/rwsem.c:24
       inode_lock_shared include/linux/fs.h:758 [inline]
       lookup_slow fs/namei.c:1688 [inline]
       lookup_one_len_unlocked+0x111/0x140 fs/namei.c:2573
       ovl_lookup_single+0x60/0x920 fs/overlayfs/namei.c:206
       ovl_lookup_layer+0x3bd/0x440 fs/overlayfs/namei.c:292
       ovl_lookup+0x729/0x1a00 fs/overlayfs/namei.c:903
       __lookup_slow+0x246/0x4a0 fs/namei.c:1672
       lookup_slow fs/namei.c:1689 [inline]
       walk_component+0x7ac/0xda0 fs/namei.c:1811
       link_path_walk.part.0+0x901/0x1230 fs/namei.c:2142
       link_path_walk fs/namei.c:2073 [inline]
       path_openat+0x1db/0x2df0 fs/namei.c:3536
       do_filp_open+0x18c/0x3f0 fs/namei.c:3567
       do_open_execat+0x11d/0x5b0 fs/exec.c:853
       __do_execve_file+0x1a8b/0x2360 fs/exec.c:1770
       do_execveat_common fs/exec.c:1879 [inline]
       do_execve+0x35/0x50 fs/exec.c:1896
       __do_sys_execve fs/exec.c:1977 [inline]
       __se_sys_execve fs/exec.c:1972 [inline]
       __x64_sys_execve+0x7c/0xa0 fs/exec.c:1972
       do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
       entry_SYSCALL_64_after_hwframe+0x49/0xbe

other info that might help us debug this:

Chain exists of:
  &ovl_i_mutex_dir_key[depth] --> &sig->cred_guard_mutex --> &ovl_i_mutex_dir_key[depth]#2

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ovl_i_mutex_dir_key[depth]#2);
                               lock(&sig->cred_guard_mutex);
                               lock(&ovl_i_mutex_dir_key[depth]#2);
  lock(&ovl_i_mutex_dir_key[depth]);

 *** DEADLOCK ***

2 locks held by syz-executor.1/20897:
 #0: 000000009442ff36 (&sig->cred_guard_mutex){+.+.}, at: prepare_bprm_creds fs/exec.c:1419 [inline]
 #0: 000000009442ff36 (&sig->cred_guard_mutex){+.+.}, at: __do_execve_file+0x38c/0x2360 fs/exec.c:1762
 #1: 00000000fe06e293 (&ovl_i_mutex_dir_key[depth]#2){.+.+}, at: inode_lock_shared include/linux/fs.h:758 [inline]
 #1: 00000000fe06e293 (&ovl_i_mutex_dir_key[depth]#2){.+.+}, at: lookup_slow fs/namei.c:1688 [inline]
 #1: 00000000fe06e293 (&ovl_i_mutex_dir_key[depth]#2){.+.+}, at: walk_component+0x798/0xda0 fs/namei.c:1811

stack backtrace:
CPU: 0 PID: 20897 Comm: syz-executor.1 Not tainted 4.19.205-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Call Trace:
 __dump_stack lib/dump_stack.c:77 [inline]
 dump_stack+0x1fc/0x2ef lib/dump_stack.c:118
 print_circular_bug.constprop.0.cold+0x2d7/0x41e kernel/locking/lockdep.c:1222
 check_prev_add kernel/locking/lockdep.c:1866 [inline]
 check_prevs_add kernel/locking/lockdep.c:1979 [inline]
 validate_chain kernel/locking/lockdep.c:2420 [inline]
 __lock_acquire+0x30c9/0x3ff0 kernel/locking/lockdep.c:3416
 lock_acquire+0x170/0x3c0 kernel/locking/lockdep.c:3908
 down_read+0x36/0x80 kernel/locking/rwsem.c:24
 inode_lock_shared include/linux/fs.h:758 [inline]
 lookup_slow fs/namei.c:1688 [inline]
 lookup_one_len_unlocked+0x111/0x140 fs/namei.c:2573
 ovl_lookup_single+0x60/0x920 fs/overlayfs/namei.c:206
 ovl_lookup_layer+0x3bd/0x440 fs/overlayfs/namei.c:292
 ovl_lookup+0x729/0x1a00 fs/overlayfs/namei.c:903
 __lookup_slow+0x246/0x4a0 fs/namei.c:1672
 lookup_slow fs/namei.c:1689 [inline]
 walk_component+0x7ac/0xda0 fs/namei.c:1811
 link_path_walk.part.0+0x901/0x1230 fs/namei.c:2142
 link_path_walk fs/namei.c:2073 [inline]
 path_openat+0x1db/0x2df0 fs/namei.c:3536
 do_filp_open+0x18c/0x3f0 fs/namei.c:3567
 do_open_execat+0x11d/0x5b0 fs/exec.c:853
 __do_execve_file+0x1a8b/0x2360 fs/exec.c:1770
 do_execveat_common fs/exec.c:1879 [inline]
 do_execve+0x35/0x50 fs/exec.c:1896
 __do_sys_execve fs/exec.c:1977 [inline]
 __se_sys_execve fs/exec.c:1972 [inline]
 __x64_sys_execve+0x7c/0xa0 fs/exec.c:1972
 do_syscall_64+0xf9/0x620 arch/x86/entry/common.c:293
 entry_SYSCALL_64_after_hwframe+0x49/0xbe
RIP: 0033:0x4665f9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 bc ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f46ea27f188 EFLAGS: 00000246 ORIG_RAX: 000000000000003b
RAX: ffffffffffffffda RBX: 000000000056bf80 RCX: 00000000004665f9
RDX: 0000000020000600 RSI: 0000000020000580 RDI: 00000000200002c0
RBP: 00000000004bfcc4 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 000000000056bf80
R13: 00007ffd84d91e0f R14: 00007f46ea27f300 R15: 0000000000022000
overlayfs: 'file0' not a directory
overlayfs: filesystem on './bus' not supported as upperdir
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './bus' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: "xino" feature enabled using 1 upper inode bits.
overlayfs: upperdir is in-use as upperdir/workdir of another mount, mount with '-o index=off' to override exclusive upperdir protection.
overlayfs: fs on './bus' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: "xino" feature enabled using 1 upper inode bits.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: failed to resolve './file1': -2
overlayfs: failed to resolve './file1': -2
overlayfs: failed to resolve './file1': -2
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: overlapping lowerdir path
overlayfs: overlapping lowerdir path
overlayfs: overlapping lowerdir path
overlayfs: failed to resolve './file0': -2
overlayfs: failed to resolve './file0': -2
overlayfs: failed to resolve './file0': -2
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: fs on './file0' does not support file handles, falling back to index=off,nfs_export=off.
overlayfs: failed to resolve './file0': -2
overlayfs: failed to resolve './file0': -2
overlayfs: failed to resolve './file0': -2
overlayfs: overlapping lowerdir path