======================================================
WARNING: possible circular locking dependency detected
6.14.0-rc1-syzkaller-g2014c95afece #0 Not tainted
------------------------------------------------------
syz.2.145/7585 is trying to acquire lock:
ffff0000f14800a0 (&bp->b_lock){+.+.}-{3:3}, at: spin_lock include/linux/spinlock.h:351 [inline]
ffff0000f14800a0 (&bp->b_lock){+.+.}-{3:3}, at: xfs_buf_try_hold fs/xfs/xfs_buf.c:578 [inline]
ffff0000f14800a0 (&bp->b_lock){+.+.}-{3:3}, at: xfs_buf_find_insert+0xf44/0x1310 fs/xfs/xfs_buf.c:663

but task is already holding lock:
ffff0000d6478180 (&bch->bc_lock){+.+.}-{3:3}, at: spin_lock include/linux/spinlock.h:351 [inline]
ffff0000d6478180 (&bch->bc_lock){+.+.}-{3:3}, at: xfs_buf_find_insert+0x3c0/0x1310 fs/xfs/xfs_buf.c:655

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&bch->bc_lock){+.+.}-{3:3}:
       __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
       _raw_spin_lock+0x48/0x60 kernel/locking/spinlock.c:154
       spin_lock include/linux/spinlock.h:351 [inline]
       xfs_buf_rele_cached fs/xfs/xfs_buf.c:1093 [inline]
       xfs_buf_rele+0x200/0x127c fs/xfs/xfs_buf.c:1147
       xfs_trans_brelse+0xf0/0x460
       xfs_imap_lookup+0x268/0x5ec fs/xfs/libxfs/xfs_ialloc.c:2431
       xfs_imap+0x44c/0xd84 fs/xfs/libxfs/xfs_ialloc.c:2514
       xfs_iget_cache_miss fs/xfs/xfs_icache.c:644 [inline]
       xfs_iget+0x930/0x2d0c fs/xfs/xfs_icache.c:806
       xfs_mountfs+0xf70/0x1c44 fs/xfs/xfs_mount.c:933
       xfs_fs_fill_super+0xee4/0x1198 fs/xfs/xfs_super.c:1813
       get_tree_bdev_flags+0x38c/0x494 fs/super.c:1636
       get_tree_bdev+0x2c/0x3c fs/super.c:1659
       xfs_fs_get_tree+0x28/0x38 fs/xfs/xfs_super.c:1860
       vfs_get_tree+0x90/0x28c fs/super.c:1814
       do_new_mount+0x278/0x900 fs/namespace.c:3560
       path_mount+0x590/0xe04 fs/namespace.c:3887
       do_mount fs/namespace.c:3900 [inline]
       __do_sys_mount fs/namespace.c:4111 [inline]
       __se_sys_mount fs/namespace.c:4088 [inline]
       __arm64_sys_mount+0x4d8/0x5ac fs/namespace.c:4088
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

-> #0 (&bp->b_lock){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3163 [inline]
       check_prevs_add kernel/locking/lockdep.c:3282 [inline]
       validate_chain kernel/locking/lockdep.c:3906 [inline]
       __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5228
       lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5851
       __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
       _raw_spin_lock+0x48/0x60 kernel/locking/spinlock.c:154
       spin_lock include/linux/spinlock.h:351 [inline]
       xfs_buf_try_hold fs/xfs/xfs_buf.c:578 [inline]
       xfs_buf_find_insert+0xf44/0x1310 fs/xfs/xfs_buf.c:663
       xfs_buf_get_map+0x1224/0x19a0 fs/xfs/xfs_buf.c:754
       xfs_buf_read_map+0xe8/0x9f0 fs/xfs/xfs_buf.c:862
       xfs_trans_read_buf_map+0x20c/0xae8 fs/xfs/xfs_trans_buf.c:304
       xfs_trans_read_buf fs/xfs/xfs_trans.h:212 [inline]
       xfs_read_agf+0x278/0x644 fs/xfs/libxfs/xfs_alloc.c:3378
       xfs_alloc_read_agf+0x188/0xba8 fs/xfs/libxfs/xfs_alloc.c:3413
       xfs_bmap_longest_free_extent fs/xfs/libxfs/xfs_bmap.c:3308 [inline]
       xfs_bmap_btalloc_select_lengths fs/xfs/libxfs/xfs_bmap.c:3371 [inline]
       xfs_bmap_btalloc_best_length fs/xfs/libxfs/xfs_bmap.c:3746 [inline]
       xfs_bmap_btalloc fs/xfs/libxfs/xfs_bmap.c:3808 [inline]
       xfs_bmapi_allocate+0xf90/0x2b10 fs/xfs/libxfs/xfs_bmap.c:4221
       xfs_bmapi_write+0x95c/0x1634 fs/xfs/libxfs/xfs_bmap.c:4550
       xfs_da_grow_inode_int+0x254/0x77c fs/xfs/libxfs/xfs_da_btree.c:2315
       xfs_dir2_grow_inode+0x214/0x6c8 fs/xfs/libxfs/xfs_dir2.c:628
       xfs_dir2_sf_to_block+0x348/0x15dc fs/xfs/libxfs/xfs_dir2_block.c:1129
       xfs_dir2_sf_addname+0x60c/0x15c0 fs/xfs/libxfs/xfs_dir2_sf.c:418
       xfs_dir_createname_args+0x134/0x21c fs/xfs/libxfs/xfs_dir2.c:308
       xfs_dir_createname+0x418/0x5e4 fs/xfs/libxfs/xfs_dir2.c:361
       xfs_dir_rename_children+0x350/0x95c fs/xfs/libxfs/xfs_dir2.c:1268
       xfs_rename+0x1308/0x1a24 fs/xfs/xfs_inode.c:2309
       xfs_vn_rename+0x2c8/0x408 fs/xfs/xfs_iops.c:500
       vfs_rename+0x9bc/0xc84 fs/namei.c:5069
       do_renameat2+0x9d8/0xe50 fs/namei.c:5226
       __do_sys_renameat2 fs/namei.c:5260 [inline]
       __se_sys_renameat2 fs/namei.c:5257 [inline]
       __arm64_sys_renameat2+0xd8/0xf4 fs/namei.c:5257
       __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
       el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
       do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
       el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
       el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
       el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&bch->bc_lock);
                               lock(&bp->b_lock);
                               lock(&bch->bc_lock);
  lock(&bp->b_lock);

 *** DEADLOCK ***

6 locks held by syz.2.145/7585:
 #0: ffff0000d77aa420 (sb_writers#23){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:547
 #1: ffff0000f7111a70 (&inode->i_sb->s_type->i_mutex_dir_key/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:900 [inline]
 #1: ffff0000f7111a70 (&inode->i_sb->s_type->i_mutex_dir_key/1){+.+.}-{4:4}, at: lock_rename fs/namei.c:3217 [inline]
 #1: ffff0000f7111a70 (&inode->i_sb->s_type->i_mutex_dir_key/1){+.+.}-{4:4}, at: do_renameat2+0x4ec/0xe50 fs/namei.c:5161
 #2: ffff0000d77aa610 (sb_internal#4){.+.+}-{0:0}, at: xfs_rename+0x8d4/0x1a24 fs/xfs/xfs_inode.c:2179
 #3: ffff0000f7111858 (&xfs_dir_ilock_class){++++}-{4:4}, at: xfs_ilock+0x1f0/0x418 fs/xfs/xfs_inode.c:165
 #4: ffff0000f757a7d8 (&xfs_dir_ilock_class/2){+.+.}-{4:4}, at: xfs_ilock+0x1f0/0x418 fs/xfs/xfs_inode.c:165
 #5: ffff0000d6478180 (&bch->bc_lock){+.+.}-{3:3}, at: spin_lock include/linux/spinlock.h:351 [inline]
 #5: ffff0000d6478180 (&bch->bc_lock){+.+.}-{3:3}, at: xfs_buf_find_insert+0x3c0/0x1310 fs/xfs/xfs_buf.c:655

stack backtrace:
CPU: 1 UID: 0 PID: 7585 Comm: syz.2.145 Not tainted 6.14.0-rc1-syzkaller-g2014c95afece #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024
Call trace:
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:466 (C)
 __dump_stack lib/dump_stack.c:94 [inline]
 dump_stack_lvl+0xe4/0x150 lib/dump_stack.c:120
 dump_stack+0x1c/0x28 lib/dump_stack.c:129
 print_circular_bug+0x154/0x1c0 kernel/locking/lockdep.c:2076
 check_noncircular+0x310/0x404 kernel/locking/lockdep.c:2208
 check_prev_add kernel/locking/lockdep.c:3163 [inline]
 check_prevs_add kernel/locking/lockdep.c:3282 [inline]
 validate_chain kernel/locking/lockdep.c:3906 [inline]
 __lock_acquire+0x34f0/0x7904 kernel/locking/lockdep.c:5228
 lock_acquire+0x23c/0x724 kernel/locking/lockdep.c:5851
 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline]
 _raw_spin_lock+0x48/0x60 kernel/locking/spinlock.c:154
 spin_lock include/linux/spinlock.h:351 [inline]
 xfs_buf_try_hold fs/xfs/xfs_buf.c:578 [inline]
 xfs_buf_find_insert+0xf44/0x1310 fs/xfs/xfs_buf.c:663
 xfs_buf_get_map+0x1224/0x19a0 fs/xfs/xfs_buf.c:754
 xfs_buf_read_map+0xe8/0x9f0 fs/xfs/xfs_buf.c:862
 xfs_trans_read_buf_map+0x20c/0xae8 fs/xfs/xfs_trans_buf.c:304
 xfs_trans_read_buf fs/xfs/xfs_trans.h:212 [inline]
 xfs_read_agf+0x278/0x644 fs/xfs/libxfs/xfs_alloc.c:3378
 xfs_alloc_read_agf+0x188/0xba8 fs/xfs/libxfs/xfs_alloc.c:3413
 xfs_bmap_longest_free_extent fs/xfs/libxfs/xfs_bmap.c:3308 [inline]
 xfs_bmap_btalloc_select_lengths fs/xfs/libxfs/xfs_bmap.c:3371 [inline]
 xfs_bmap_btalloc_best_length fs/xfs/libxfs/xfs_bmap.c:3746 [inline]
 xfs_bmap_btalloc fs/xfs/libxfs/xfs_bmap.c:3808 [inline]
 xfs_bmapi_allocate+0xf90/0x2b10 fs/xfs/libxfs/xfs_bmap.c:4221
 xfs_bmapi_write+0x95c/0x1634 fs/xfs/libxfs/xfs_bmap.c:4550
 xfs_da_grow_inode_int+0x254/0x77c fs/xfs/libxfs/xfs_da_btree.c:2315
 xfs_dir2_grow_inode+0x214/0x6c8 fs/xfs/libxfs/xfs_dir2.c:628
 xfs_dir2_sf_to_block+0x348/0x15dc fs/xfs/libxfs/xfs_dir2_block.c:1129
 xfs_dir2_sf_addname+0x60c/0x15c0 fs/xfs/libxfs/xfs_dir2_sf.c:418
 xfs_dir_createname_args+0x134/0x21c fs/xfs/libxfs/xfs_dir2.c:308
 xfs_dir_createname+0x418/0x5e4 fs/xfs/libxfs/xfs_dir2.c:361
 xfs_dir_rename_children+0x350/0x95c fs/xfs/libxfs/xfs_dir2.c:1268
 xfs_rename+0x1308/0x1a24 fs/xfs/xfs_inode.c:2309
 xfs_vn_rename+0x2c8/0x408 fs/xfs/xfs_iops.c:500
 vfs_rename+0x9bc/0xc84 fs/namei.c:5069
 do_renameat2+0x9d8/0xe50 fs/namei.c:5226
 __do_sys_renameat2 fs/namei.c:5260 [inline]
 __se_sys_renameat2 fs/namei.c:5257 [inline]
 __arm64_sys_renameat2+0xd8/0xf4 fs/namei.c:5257
 __invoke_syscall arch/arm64/kernel/syscall.c:35 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:49
 el0_svc_common+0x130/0x23c arch/arm64/kernel/syscall.c:132
 do_el0_svc+0x48/0x58 arch/arm64/kernel/syscall.c:151
 el0_svc+0x54/0x168 arch/arm64/kernel/entry-common.c:744
 el0t_64_sync_handler+0x84/0x108 arch/arm64/kernel/entry-common.c:762
 el0t_64_sync+0x198/0x19c arch/arm64/kernel/entry.S:600