====================================================== WARNING: possible circular locking dependency detected 6.1.112-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.945/6873 is trying to acquire lock: ffff888071fa34a0 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline] ffff888071fa34a0 (&ni->ni_lock/4){+.+.}-{3:3}, at: mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 but task is already holding lock: ffff888058bdc360 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1116 [inline] ffff888058bdc360 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x16b/0x1070 fs/ntfs3/frecord.c:3323 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ni->ni_lock){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ntfs_set_state+0x1fa/0x660 fs/ntfs3/fsntfs.c:920 ni_remove_name+0x2bc/0x9a0 fs/ntfs3/frecord.c:2998 ni_rename+0x13e/0x1e0 fs/ntfs3/frecord.c:3150 ntfs_rename+0x74a/0xd10 fs/ntfs3/namei.c:318 vfs_rename+0xd32/0x10f0 fs/namei.c:4876 do_renameat2+0xde0/0x1440 fs/namei.c:5029 __do_sys_rename fs/namei.c:5075 [inline] __se_sys_rename fs/namei.c:5073 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5073 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&ni->ni_lock/4){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline] mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x479/0x38e0 fs/ntfs3/inode.c:525 ni_update_parent+0x93f/0xdc0 fs/ntfs3/frecord.c:3279 ni_write_inode+0xe34/0x1070 fs/ntfs3/frecord.c:3377 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x67d/0x11e0 fs/fs-writeback.c:1677 writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1733 write_inode_now+0x1cf/0x260 fs/fs-writeback.c:2769 ntfs_extend+0x3c2/0x4c0 fs/ntfs3/file.c:453 ntfs_file_write_iter+0x304/0x6d0 fs/ntfs3/file.c:1158 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x857/0xbc0 fs/read_write.c:584 ksys_write+0x19c/0x2c0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ni->ni_lock); lock(&ni->ni_lock/4); lock(&ni->ni_lock); lock(&ni->ni_lock/4); *** DEADLOCK *** 4 locks held by syz.1.945/6873: #0: ffff88807cc41268 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0x2ba/0x360 fs/file.c:1058 #1: ffff88805da12460 (sb_writers#17){.+.+}-{0:0}, at: vfs_write+0x269/0xbc0 fs/read_write.c:580 #2: ffff888058bdc600 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: inode_trylock include/linux/fs.h:778 [inline] #2: ffff888058bdc600 (&sb->s_type->i_mutex_key#25){+.+.}-{3:3}, at: ntfs_file_write_iter+0x1c7/0x6d0 fs/ntfs3/file.c:1142 #3: ffff888058bdc360 (&ni->ni_lock){+.+.}-{3:3}, at: ni_trylock fs/ntfs3/ntfs_fs.h:1116 [inline] #3: ffff888058bdc360 (&ni->ni_lock){+.+.}-{3:3}, at: ni_write_inode+0x16b/0x1070 fs/ntfs3/frecord.c:3323 stack backtrace: CPU: 1 PID: 6873 Comm: syz.1.945 Not tainted 6.1.112-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x132/0xd80 kernel/locking/mutex.c:747 ni_lock fs/ntfs3/ntfs_fs.h:1101 [inline] mi_read+0x2dd/0x5a0 fs/ntfs3/record.c:148 ntfs_read_mft fs/ntfs3/inode.c:69 [inline] ntfs_iget5+0x479/0x38e0 fs/ntfs3/inode.c:525 ni_update_parent+0x93f/0xdc0 fs/ntfs3/frecord.c:3279 ni_write_inode+0xe34/0x1070 fs/ntfs3/frecord.c:3377 write_inode fs/fs-writeback.c:1460 [inline] __writeback_single_inode+0x67d/0x11e0 fs/fs-writeback.c:1677 writeback_single_inode+0x22c/0x960 fs/fs-writeback.c:1733 write_inode_now+0x1cf/0x260 fs/fs-writeback.c:2769 ntfs_extend+0x3c2/0x4c0 fs/ntfs3/file.c:453 ntfs_file_write_iter+0x304/0x6d0 fs/ntfs3/file.c:1158 call_write_iter include/linux/fs.h:2265 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x857/0xbc0 fs/read_write.c:584 ksys_write+0x19c/0x2c0 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f927237dff9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f927312d038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007f9272535f80 RCX: 00007f927237dff9 RDX: 000000000000000e RSI: 0000000020000040 RDI: 0000000000000004 RBP: 00007f92723f0296 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f9272535f80 R15: 00007ffdb38e5f08 ntfs3: loop1: ino=1d, "file1" failed to open parent directory r=400 to update ntfs3: loop1: ino=1d, "file1" failed to open parent directory r=400 to update