====================================================== WARNING: possible circular locking dependency detected 6.13.0-syzkaller-04858-g21266b8df522 #0 Not tainted ------------------------------------------------------ syz.3.30/6035 is trying to acquire lock: ffff88807ef41b40 (&lp->qli_lock){+.+.}-{3:3}, at: spin_lock include/linux/spinlock.h:351 [inline] ffff88807ef41b40 (&lp->qli_lock){+.+.}-{3:3}, at: xfs_dquot_detach_buf+0x25/0x200 fs/xfs/xfs_dquot.c:83 but task is already holding lock: ffff88807cba5a30 (&l->lock){+.+.}-{3:3}, at: spin_lock include/linux/spinlock.h:351 [inline] ffff88807cba5a30 (&l->lock){+.+.}-{3:3}, at: lock_list_lru_of_memcg+0x234/0x5e0 mm/list_lru.c:77 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #3 (&l->lock){+.+.}-{3:3}: __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:351 [inline] lock_list_lru_of_memcg+0x234/0x5e0 mm/list_lru.c:77 list_lru_add+0x59/0x2c0 mm/list_lru.c:163 list_lru_add_obj+0x194/0x2f0 mm/list_lru.c:189 xfs_buf_rele_cached fs/xfs/xfs_buf.c:1106 [inline] xfs_buf_rele+0xde0/0x1750 fs/xfs/xfs_buf.c:1151 xfs_buf_relse fs/xfs/xfs_buf.h:316 [inline] xfs_trans_brelse+0x3c4/0x450 fs/xfs/xfs_trans_buf.c:369 xfs_imap_lookup+0x38c/0x5c0 fs/xfs/libxfs/xfs_ialloc.c:2431 xfs_imap+0x7d8/0xd50 fs/xfs/libxfs/xfs_ialloc.c:2514 xfs_iget_cache_miss fs/xfs/xfs_icache.c:644 [inline] xfs_iget+0x989/0x2e80 fs/xfs/xfs_icache.c:806 xfs_mountfs+0x13e1/0x2230 fs/xfs/xfs_mount.c:919 xfs_fs_fill_super+0x1557/0x1f50 fs/xfs/xfs_super.c:1791 get_tree_bdev_flags+0x38e/0x620 fs/super.c:1636 vfs_get_tree+0x8e/0x340 fs/super.c:1814 do_new_mount fs/namespace.c:3560 [inline] path_mount+0x14e6/0x1f10 fs/namespace.c:3887 do_mount fs/namespace.c:3900 [inline] __do_sys_mount fs/namespace.c:4111 [inline] __se_sys_mount fs/namespace.c:4088 [inline] __x64_sys_mount+0x28f/0x310 fs/namespace.c:4088 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #2 (&bch->bc_lock){+.+.}-{3:3}: __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:351 [inline] _atomic_dec_and_lock+0xd2/0x120 lib/dec_and_lock.c:28 xfs_buf_rele_cached fs/xfs/xfs_buf.c:1085 [inline] xfs_buf_rele+0x116/0x1750 fs/xfs/xfs_buf.c:1151 xfs_buf_relse fs/xfs/xfs_buf.h:316 [inline] xfs_trans_brelse+0x3c4/0x450 fs/xfs/xfs_trans_buf.c:369 xfs_imap_lookup+0x38c/0x5c0 fs/xfs/libxfs/xfs_ialloc.c:2431 xfs_imap+0x7d8/0xd50 fs/xfs/libxfs/xfs_ialloc.c:2514 xfs_iget_cache_miss fs/xfs/xfs_icache.c:644 [inline] xfs_iget+0x989/0x2e80 fs/xfs/xfs_icache.c:806 xfs_mountfs+0x13e1/0x2230 fs/xfs/xfs_mount.c:919 xfs_fs_fill_super+0x1557/0x1f50 fs/xfs/xfs_super.c:1791 get_tree_bdev_flags+0x38e/0x620 fs/super.c:1636 vfs_get_tree+0x8e/0x340 fs/super.c:1814 do_new_mount fs/namespace.c:3560 [inline] path_mount+0x14e6/0x1f10 fs/namespace.c:3887 do_mount fs/namespace.c:3900 [inline] __do_sys_mount fs/namespace.c:4111 [inline] __se_sys_mount fs/namespace.c:4088 [inline] __x64_sys_mount+0x28f/0x310 fs/namespace.c:4088 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #1 (&bp->b_lock){+.+.}-{3:3}: __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:351 [inline] xfs_buf_rele_cached fs/xfs/xfs_buf.c:1084 [inline] xfs_buf_rele+0x109/0x1750 fs/xfs/xfs_buf.c:1151 xfs_buf_relse fs/xfs/xfs_buf.h:316 [inline] xfs_trans_brelse+0x3c4/0x450 fs/xfs/xfs_trans_buf.c:369 xfs_dquot_attach_buf+0x2eb/0x430 fs/xfs/xfs_dquot.c:1346 xfs_qm_quotacheck_dqadjust+0x114/0x570 fs/xfs/xfs_qm.c:1341 xfs_qm_dqusage_adjust+0x5cb/0x6f0 fs/xfs/xfs_qm.c:1464 xfs_iwalk_ag_recs+0x53f/0x870 fs/xfs/xfs_iwalk.c:209 xfs_iwalk_run_callbacks+0x1f3/0x540 fs/xfs/xfs_iwalk.c:370 xfs_iwalk_ag+0x81d/0xa30 fs/xfs/xfs_iwalk.c:476 xfs_iwalk_ag_work+0x144/0x1c0 fs/xfs/xfs_iwalk.c:625 xfs_pwork_work+0x82/0x160 fs/xfs/xfs_pwork.c:47 process_one_work+0x9c8/0x1ba0 kernel/workqueue.c:3236 process_scheduled_works kernel/workqueue.c:3317 [inline] worker_thread+0x6c8/0xf00 kernel/workqueue.c:3398 kthread+0x3b2/0x750 kernel/kthread.c:464 ret_from_fork+0x48/0x80 arch/x86/kernel/process.c:148 ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244 -> #0 (&lp->qli_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain kernel/locking/lockdep.c:3906 [inline] __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:351 [inline] xfs_dquot_detach_buf+0x25/0x200 fs/xfs/xfs_dquot.c:83 xfs_qm_dquot_isolate+0x1a8/0x1470 fs/xfs/xfs_qm.c:528 __list_lru_walk_one+0x160/0x4c0 mm/list_lru.c:300 list_lru_walk_one+0x3c/0x50 mm/list_lru.c:337 list_lru_shrink_walk include/linux/list_lru.h:240 [inline] xfs_qm_shrink_scan+0x1fc/0x3f0 fs/xfs/xfs_qm.c:574 do_shrink_slab+0x452/0x11c0 mm/shrinker.c:437 shrink_slab+0x32b/0x12a0 mm/shrinker.c:664 drop_slab_node mm/vmscan.c:421 [inline] drop_slab+0x14c/0x2c0 mm/vmscan.c:439 drop_caches_sysctl_handler+0x171/0x190 fs/drop_caches.c:68 proc_sys_call_handler+0x3c9/0x5a0 fs/proc/proc_sysctl.c:601 iter_file_splice_write+0x912/0x10b0 fs/splice.c:743 do_splice_from fs/splice.c:941 [inline] direct_splice_actor+0x192/0x6c0 fs/splice.c:1164 splice_direct_to_actor+0x349/0xa40 fs/splice.c:1108 do_splice_direct_actor fs/splice.c:1207 [inline] do_splice_direct+0x178/0x250 fs/splice.c:1233 do_sendfile+0xaed/0xe30 fs/read_write.c:1363 __do_sys_sendfile64 fs/read_write.c:1418 [inline] __se_sys_sendfile64 fs/read_write.c:1410 [inline] __x64_sys_sendfile64+0x155/0x220 fs/read_write.c:1410 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Chain exists of: &lp->qli_lock --> &bch->bc_lock --> &l->lock Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&l->lock); lock(&bch->bc_lock); lock(&l->lock); lock(&lp->qli_lock); *** DEADLOCK *** 3 locks held by syz.3.30/6035: #0: ffff888049540420 (sb_writers#3){.+.+}-{0:0}, at: splice_direct_to_actor+0x349/0xa40 fs/splice.c:1108 #1: ffff88807cba5a30 (&l->lock){+.+.}-{3:3}, at: spin_lock include/linux/spinlock.h:351 [inline] #1: ffff88807cba5a30 (&l->lock){+.+.}-{3:3}, at: lock_list_lru_of_memcg+0x234/0x5e0 mm/list_lru.c:77 #2: ffff88807ef41c28 (&dqp->q_qlock){+.+.}-{4:4}, at: xfs_dqlock_nowait fs/xfs/xfs_dquot.h:126 [inline] #2: ffff88807ef41c28 (&dqp->q_qlock){+.+.}-{4:4}, at: xfs_qm_dquot_isolate+0x80/0x1470 fs/xfs/xfs_qm.c:467 stack backtrace: CPU: 0 UID: 0 PID: 6035 Comm: syz.3.30 Not tainted 6.13.0-syzkaller-04858-g21266b8df522 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 12/27/2024 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x116/0x1f0 lib/dump_stack.c:120 print_circular_bug+0x490/0x760 kernel/locking/lockdep.c:2076 check_noncircular+0x31a/0x400 kernel/locking/lockdep.c:2208 check_prev_add kernel/locking/lockdep.c:3163 [inline] check_prevs_add kernel/locking/lockdep.c:3282 [inline] validate_chain kernel/locking/lockdep.c:3906 [inline] __lock_acquire+0x249e/0x3c40 kernel/locking/lockdep.c:5228 lock_acquire.part.0+0x11b/0x380 kernel/locking/lockdep.c:5851 __raw_spin_lock include/linux/spinlock_api_smp.h:133 [inline] _raw_spin_lock+0x2e/0x40 kernel/locking/spinlock.c:154 spin_lock include/linux/spinlock.h:351 [inline] xfs_dquot_detach_buf+0x25/0x200 fs/xfs/xfs_dquot.c:83 xfs_qm_dquot_isolate+0x1a8/0x1470 fs/xfs/xfs_qm.c:528 __list_lru_walk_one+0x160/0x4c0 mm/list_lru.c:300 list_lru_walk_one+0x3c/0x50 mm/list_lru.c:337 list_lru_shrink_walk include/linux/list_lru.h:240 [inline] xfs_qm_shrink_scan+0x1fc/0x3f0 fs/xfs/xfs_qm.c:574 do_shrink_slab+0x452/0x11c0 mm/shrinker.c:437 shrink_slab+0x32b/0x12a0 mm/shrinker.c:664 drop_slab_node mm/vmscan.c:421 [inline] drop_slab+0x14c/0x2c0 mm/vmscan.c:439 drop_caches_sysctl_handler+0x171/0x190 fs/drop_caches.c:68 proc_sys_call_handler+0x3c9/0x5a0 fs/proc/proc_sysctl.c:601 iter_file_splice_write+0x912/0x10b0 fs/splice.c:743 do_splice_from fs/splice.c:941 [inline] direct_splice_actor+0x192/0x6c0 fs/splice.c:1164 splice_direct_to_actor+0x349/0xa40 fs/splice.c:1108 do_splice_direct_actor fs/splice.c:1207 [inline] do_splice_direct+0x178/0x250 fs/splice.c:1233 do_sendfile+0xaed/0xe30 fs/read_write.c:1363 __do_sys_sendfile64 fs/read_write.c:1418 [inline] __se_sys_sendfile64 fs/read_write.c:1410 [inline] __x64_sys_sendfile64+0x155/0x220 fs/read_write.c:1410 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xcd/0x250 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7fede378cd29 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fede4682038 EFLAGS: 00000246 ORIG_RAX: 0000000000000028 RAX: ffffffffffffffda RBX: 00007fede39a5fa0 RCX: 00007fede378cd29 RDX: 0000000020002080 RSI: 0000000000000005 RDI: 0000000000000006 RBP: 00007fede380e2a0 R08: 0000000000000000 R09: 0000000000000000 R10: 000000000000023b R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fede39a5fa0 R15: 00007fffdacf1418 syz.3.30 (6035): drop_caches: 2