====================================================== WARNING: possible circular locking dependency detected 5.2.0+ #91 Not tainted ------------------------------------------------------ syz-executor.2/30777 is trying to acquire lock: 000000005b1e8609 (rtnl_mutex){+.+.}, at: rtnl_lock+0x17/0x20 /net/core/rtnetlink.c:72 but task is already holding lock: 000000000f2d5a4f (&xs->mutex){+.+.}, at: xsk_bind+0x16a/0xe80 /net/xdp/xsk.c:436 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&xs->mutex){+.+.}: __mutex_lock_common /kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 /kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 /kernel/locking/mutex.c:1088 xsk_notifier+0x145/0x2a0 /net/xdp/xsk.c:764 notifier_call_chain+0xc2/0x230 /kernel/notifier.c:95 __raw_notifier_call_chain /kernel/notifier.c:396 [inline] raw_notifier_call_chain+0x2e/0x40 /kernel/notifier.c:403 call_netdevice_notifiers_info+0x3f/0x90 /net/core/dev.c:1749 call_netdevice_notifiers_extack /net/core/dev.c:1761 [inline] call_netdevice_notifiers /net/core/dev.c:1775 [inline] rollback_registered_many+0x9b9/0xfc0 /net/core/dev.c:8196 rollback_registered+0x109/0x1d0 /net/core/dev.c:8238 unregister_netdevice_queue /net/core/dev.c:9285 [inline] unregister_netdevice_queue+0x1ee/0x2c0 /net/core/dev.c:9278 br_dev_delete+0x145/0x1a0 /net/bridge/br_if.c:383 br_del_bridge+0xd7/0x120 /net/bridge/br_if.c:483 br_ioctl_deviceless_stub+0x2b0/0x7c0 /net/bridge/br_ioctl.c:376 sock_ioctl+0x44b/0x790 /net/socket.c:1132 vfs_ioctl /fs/ioctl.c:46 [inline] file_ioctl /fs/ioctl.c:509 [inline] do_vfs_ioctl+0xd5f/0x1380 /fs/ioctl.c:696 ksys_ioctl+0xab/0xd0 /fs/ioctl.c:713 __do_sys_ioctl /fs/ioctl.c:720 [inline] __se_sys_ioctl /fs/ioctl.c:718 [inline] __x64_sys_ioctl+0x73/0xb0 /fs/ioctl.c:718 do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe -> #1 (&net->xdp.lock){+.+.}: __mutex_lock_common /kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 /kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 /kernel/locking/mutex.c:1088 xsk_notifier+0xa3/0x2a0 /net/xdp/xsk.c:760 notifier_call_chain+0xc2/0x230 /kernel/notifier.c:95 __raw_notifier_call_chain /kernel/notifier.c:396 [inline] raw_notifier_call_chain+0x2e/0x40 /kernel/notifier.c:403 call_netdevice_notifiers_info+0x3f/0x90 /net/core/dev.c:1749 call_netdevice_notifiers_extack /net/core/dev.c:1761 [inline] call_netdevice_notifiers /net/core/dev.c:1775 [inline] rollback_registered_many+0x9b9/0xfc0 /net/core/dev.c:8196 unregister_netdevice_many.part.0+0x1b/0x1f0 /net/core/dev.c:9304 unregister_netdevice_many+0x3b/0x50 /net/core/dev.c:9303 ip6gre_exit_batch_net+0x535/0x750 /net/ipv6/ip6_gre.c:1603 ops_exit_list.isra.0+0xfc/0x150 /net/core/net_namespace.c:175 cleanup_net+0x4e2/0xa70 /net/core/net_namespace.c:594 process_one_work+0x9af/0x1740 /kernel/workqueue.c:2269 worker_thread+0x98/0xe40 /kernel/workqueue.c:2415 kthread+0x361/0x430 /kernel/kthread.c:255 ret_from_fork+0x24/0x30 /arch/x86/entry/entry_64.S:352 -> #0 (rtnl_mutex){+.+.}: check_prev_add /kernel/locking/lockdep.c:2405 [inline] check_prevs_add /kernel/locking/lockdep.c:2507 [inline] validate_chain /kernel/locking/lockdep.c:2897 [inline] __lock_acquire+0x25a0/0x4690 /kernel/locking/lockdep.c:3880 lock_acquire+0x190/0x410 /kernel/locking/lockdep.c:4413 __mutex_lock_common /kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 /kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 /kernel/locking/mutex.c:1088 rtnl_lock+0x17/0x20 /net/core/rtnetlink.c:72 xdp_umem_assign_dev+0xbe/0x8f0 /net/xdp/xdp_umem.c:96 xsk_bind+0x4d7/0xe80 /net/xdp/xsk.c:502 __sys_bind+0x239/0x290 /net/socket.c:1643 __do_sys_bind /net/socket.c:1654 [inline] __se_sys_bind /net/socket.c:1652 [inline] __x64_sys_bind+0x73/0xb0 /net/socket.c:1652 do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe other info that might help us debug this: Chain exists of: rtnl_mutex --> &net->xdp.lock --> &xs->mutex Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&xs->mutex); lock(&net->xdp.lock); lock(&xs->mutex); lock(rtnl_mutex); *** DEADLOCK *** 1 lock held by syz-executor.2/30777: #0: 000000000f2d5a4f (&xs->mutex){+.+.}, at: xsk_bind+0x16a/0xe80 /net/xdp/xsk.c:436 stack backtrace: CPU: 0 PID: 30777 Comm: syz-executor.2 Not tainted 5.2.0+ #91 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 Call Trace: __dump_stack /lib/dump_stack.c:77 [inline] dump_stack+0x172/0x1f0 /lib/dump_stack.c:113 print_circular_bug.cold+0x163/0x172 /kernel/locking/lockdep.c:1617 check_noncircular+0x345/0x3e0 /kernel/locking/lockdep.c:1741 check_prev_add /kernel/locking/lockdep.c:2405 [inline] check_prevs_add /kernel/locking/lockdep.c:2507 [inline] validate_chain /kernel/locking/lockdep.c:2897 [inline] __lock_acquire+0x25a0/0x4690 /kernel/locking/lockdep.c:3880 lock_acquire+0x190/0x410 /kernel/locking/lockdep.c:4413 __mutex_lock_common /kernel/locking/mutex.c:926 [inline] __mutex_lock+0xf7/0x1340 /kernel/locking/mutex.c:1073 mutex_lock_nested+0x16/0x20 /kernel/locking/mutex.c:1088 rtnl_lock+0x17/0x20 /net/core/rtnetlink.c:72 xdp_umem_assign_dev+0xbe/0x8f0 /net/xdp/xdp_umem.c:96 xsk_bind+0x4d7/0xe80 /net/xdp/xsk.c:502 __sys_bind+0x239/0x290 /net/socket.c:1643 __do_sys_bind /net/socket.c:1654 [inline] __se_sys_bind /net/socket.c:1652 [inline] __x64_sys_bind+0x73/0xb0 /net/socket.c:1652 do_syscall_64+0xfd/0x6a0 /arch/x86/entry/common.c:296 entry_SYSCALL_64_after_hwframe+0x49/0xbe RIP: 0033:0x459819 Code: fd b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 00 66 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 0f 83 cb b7 fb ff c3 66 2e 0f 1f 84 00 00 00 00 RSP: 002b:00007fa356778c78 EFLAGS: 00000246 ORIG_RAX: 0000000000000031 RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 0000000000459819 RDX: 0000000000000010 RSI: 0000000020000080 RDI: 0000000000000004 RBP: 000000000075bf20 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 00007fa3567796d4 R13: 00000000004bfa6d R14: 00000000004d1450 R15: 00000000ffffffff