====================================================== WARNING: possible circular locking dependency detected 5.15.167-syzkaller #0 Not tainted ------------------------------------------------------ syz.1.338/5280 is trying to acquire lock: ffff88804a7ad488 (&osb->system_file_mutex){+.+.}-{3:3}, at: ocfs2_get_system_file_inode+0x1a1/0x7b0 fs/ocfs2/sysfile.c:101 but task is already holding lock: ffff888066ecdbe0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_expand_inline_dir fs/ocfs2/dir.c:2802 [inline] ffff888066ecdbe0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_extend_dir+0x7ed/0x5270 fs/ocfs2/dir.c:3183 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}: lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 down_read+0x45/0x2e0 kernel/locking/rwsem.c:1498 ocfs2_read_virt_blocks+0x2b3/0xa10 fs/ocfs2/extent_map.c:976 ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline] ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline] ocfs2_find_entry+0x437/0x26d0 fs/ocfs2/dir.c:1080 ocfs2_find_files_on_disk+0xea/0x310 fs/ocfs2/dir.c:1982 ocfs2_lookup_ino_from_name+0xad/0x1e0 fs/ocfs2/dir.c:2004 _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline] ocfs2_get_system_file_inode+0x314/0x7b0 fs/ocfs2/sysfile.c:112 ocfs2_init_global_system_inodes+0x328/0x720 fs/ocfs2/super.c:458 ocfs2_initialize_super fs/ocfs2/super.c:2276 [inline] ocfs2_fill_super+0x479e/0x58a0 fs/ocfs2/super.c:995 mount_bdev+0x2c9/0x3f0 fs/super.c:1398 legacy_get_tree+0xeb/0x180 fs/fs_context.c:611 vfs_get_tree+0x88/0x270 fs/super.c:1528 do_new_mount+0x2ba/0xb40 fs/namespace.c:3005 do_mount fs/namespace.c:3348 [inline] __do_sys_mount fs/namespace.c:3556 [inline] __se_sys_mount+0x2d5/0x3c0 fs/namespace.c:3533 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 -> #0 (&osb->system_file_mutex){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 ocfs2_get_system_file_inode+0x1a1/0x7b0 fs/ocfs2/sysfile.c:101 ocfs2_reserve_suballoc_bits+0x16b/0x4c70 fs/ocfs2/suballoc.c:776 ocfs2_reserve_new_metadata_blocks+0x418/0x9b0 fs/ocfs2/suballoc.c:978 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2821 [inline] ocfs2_extend_dir+0xdd4/0x5270 fs/ocfs2/dir.c:3183 ocfs2_prepare_dir_for_insert+0x34cd/0x5eb0 fs/ocfs2/dir.c:4304 ocfs2_mknod+0xd84/0x2cd0 fs/ocfs2/namei.c:292 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_creat fs/open.c:1343 [inline] __se_sys_creat fs/open.c:1337 [inline] __x64_sys_creat+0x11f/0x160 fs/open.c:1337 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ocfs2_file_ip_alloc_sem_key); lock(&osb->system_file_mutex); lock(&ocfs2_file_ip_alloc_sem_key); lock(&osb->system_file_mutex); *** DEADLOCK *** 3 locks held by syz.1.338/5280: #0: ffff88801f386460 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:377 #1: ffff888066ecdf48 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:789 [inline] #1: ffff888066ecdf48 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: open_last_lookups fs/namei.c:3529 [inline] #1: ffff888066ecdf48 (&sb->s_type->i_mutex_key#26){+.+.}-{3:3}, at: path_openat+0x824/0x2f20 fs/namei.c:3739 #2: ffff888066ecdbe0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_expand_inline_dir fs/ocfs2/dir.c:2802 [inline] #2: ffff888066ecdbe0 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}, at: ocfs2_extend_dir+0x7ed/0x5270 fs/ocfs2/dir.c:3183 stack backtrace: CPU: 0 PID: 5280 Comm: syz.1.338 Not tainted 5.15.167-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2d0 lib/dump_stack.c:106 check_noncircular+0x2f8/0x3b0 kernel/locking/lockdep.c:2133 check_prev_add kernel/locking/lockdep.c:3053 [inline] check_prevs_add kernel/locking/lockdep.c:3172 [inline] validate_chain+0x1649/0x5930 kernel/locking/lockdep.c:3788 __lock_acquire+0x1295/0x1ff0 kernel/locking/lockdep.c:5012 lock_acquire+0x1db/0x4f0 kernel/locking/lockdep.c:5623 __mutex_lock_common+0x1da/0x25a0 kernel/locking/mutex.c:596 __mutex_lock kernel/locking/mutex.c:729 [inline] mutex_lock_nested+0x17/0x20 kernel/locking/mutex.c:743 ocfs2_get_system_file_inode+0x1a1/0x7b0 fs/ocfs2/sysfile.c:101 ocfs2_reserve_suballoc_bits+0x16b/0x4c70 fs/ocfs2/suballoc.c:776 ocfs2_reserve_new_metadata_blocks+0x418/0x9b0 fs/ocfs2/suballoc.c:978 ocfs2_expand_inline_dir fs/ocfs2/dir.c:2821 [inline] ocfs2_extend_dir+0xdd4/0x5270 fs/ocfs2/dir.c:3183 ocfs2_prepare_dir_for_insert+0x34cd/0x5eb0 fs/ocfs2/dir.c:4304 ocfs2_mknod+0xd84/0x2cd0 fs/ocfs2/namei.c:292 ocfs2_create+0x194/0x430 fs/ocfs2/namei.c:672 lookup_open fs/namei.c:3462 [inline] open_last_lookups fs/namei.c:3532 [inline] path_openat+0x130a/0x2f20 fs/namei.c:3739 do_filp_open+0x21c/0x460 fs/namei.c:3769 do_sys_openat2+0x13b/0x4f0 fs/open.c:1253 do_sys_open fs/open.c:1269 [inline] __do_sys_creat fs/open.c:1343 [inline] __se_sys_creat fs/open.c:1337 [inline] __x64_sys_creat+0x11f/0x160 fs/open.c:1337 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x66/0xd0 RIP: 0033:0x7fe6c1a88ff9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007fe6bff01038 EFLAGS: 00000246 ORIG_RAX: 0000000000000055 RAX: ffffffffffffffda RBX: 00007fe6c1c40f80 RCX: 00007fe6c1a88ff9 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000020000580 RBP: 00007fe6c1afb296 R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007fe6c1c40f80 R15: 00007ffe32fc0c58 syz.1.338 (5280) used greatest stack depth: 16912 bytes left