====================================================== WARNING: possible circular locking dependency detected 6.7.0-rc4-syzkaller-00358-gf2e8a57ee903 #0 Not tainted ------------------------------------------------------ syz-executor.1/20137 is trying to acquire lock: ffff8880566ecf38 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xa2/0xb10 fs/hfs/extent.c:397 but task is already holding lock: ffff888055dea0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x17f/0x220 fs/hfs/bfind.c:33 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&tree->tree_lock/1){+.+.}-{3:3}: __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:747 hfs_find_init+0x17f/0x220 fs/hfs/bfind.c:33 hfs_ext_read_extent+0x19c/0x9d0 fs/hfs/extent.c:200 hfs_get_block+0x55b/0x820 fs/hfs/extent.c:366 block_read_full_folio+0x3df/0xaa0 fs/buffer.c:2399 filemap_read_folio+0xe9/0x2c0 mm/filemap.c:2323 do_read_cache_folio+0x205/0x540 mm/filemap.c:3691 do_read_cache_page mm/filemap.c:3757 [inline] read_cache_page+0x5b/0x160 mm/filemap.c:3766 read_mapping_page include/linux/pagemap.h:871 [inline] hfs_btree_open+0x662/0x1050 fs/hfs/btree.c:78 hfs_mdb_get+0x165f/0x2020 fs/hfs/mdb.c:204 hfs_fill_super+0xb1e/0x16e0 fs/hfs/super.c:406 mount_bdev+0x1f3/0x2e0 fs/super.c:1650 legacy_get_tree+0x109/0x220 fs/fs_context.c:662 vfs_get_tree+0x8c/0x370 fs/super.c:1771 do_new_mount fs/namespace.c:3337 [inline] path_mount+0x1492/0x1ed0 fs/namespace.c:3664 do_mount fs/namespace.c:3677 [inline] __do_sys_mount fs/namespace.c:3886 [inline] __se_sys_mount fs/namespace.c:3863 [inline] __x64_sys_mount+0x293/0x310 fs/namespace.c:3863 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b -> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2433/0x3b20 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:747 hfs_extend_file+0xa2/0xb10 fs/hfs/extent.c:397 hfs_bmap_reserve+0x29c/0x370 fs/hfs/btree.c:234 __hfs_ext_write_extent+0x3cb/0x520 fs/hfs/extent.c:121 __hfs_ext_cache_extent fs/hfs/extent.c:174 [inline] hfs_ext_read_extent+0x805/0x9d0 fs/hfs/extent.c:202 hfs_extend_file+0x4e0/0xb10 fs/hfs/extent.c:401 hfs_get_block+0x17f/0x820 fs/hfs/extent.c:353 __block_write_begin_int+0x3c0/0x1560 fs/buffer.c:2119 __block_write_begin fs/buffer.c:2168 [inline] block_write_begin+0xb1/0x490 fs/buffer.c:2227 cont_write_begin+0x530/0x730 fs/buffer.c:2582 hfs_write_begin+0x87/0x140 fs/hfs/inode.c:58 generic_perform_write+0x278/0x600 mm/filemap.c:3918 __generic_file_write_iter+0x1f9/0x240 mm/filemap.c:4013 generic_file_write_iter+0xe3/0x350 mm/filemap.c:4039 call_write_iter include/linux/fs.h:2020 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x64f/0xdf0 fs/read_write.c:584 ksys_write+0x12f/0x250 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&tree->tree_lock/1); lock(&HFS_I(tree->inode)->extents_lock); lock(&tree->tree_lock/1); lock(&HFS_I(tree->inode)->extents_lock); *** DEADLOCK *** 5 locks held by syz-executor.1/20137: #0: ffff8880294e1dc8 (&f->f_pos_lock){+.+.}-{3:3}, at: __fdget_pos+0xe7/0x170 fs/file.c:1177 #1: ffff888023224418 (sb_writers#15){.+.+}-{0:0}, at: ksys_write+0x12f/0x250 fs/read_write.c:637 #2: ffff888064640628 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:802 [inline] #2: ffff888064640628 (&sb->s_type->i_mutex_key#22){+.+.}-{3:3}, at: generic_file_write_iter+0x92/0x350 mm/filemap.c:4036 #3: ffff888064640478 (&HFS_I(inode)->extents_lock){+.+.}-{3:3}, at: hfs_extend_file+0xa2/0xb10 fs/hfs/extent.c:397 #4: ffff888055dea0b0 (&tree->tree_lock/1){+.+.}-{3:3}, at: hfs_find_init+0x17f/0x220 fs/hfs/bfind.c:33 stack backtrace: CPU: 3 PID: 20137 Comm: syz-executor.1 Not tainted 6.7.0-rc4-syzkaller-00358-gf2e8a57ee903 #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x1b0 lib/dump_stack.c:106 check_noncircular+0x317/0x400 kernel/locking/lockdep.c:2187 check_prev_add kernel/locking/lockdep.c:3134 [inline] check_prevs_add kernel/locking/lockdep.c:3253 [inline] validate_chain kernel/locking/lockdep.c:3869 [inline] __lock_acquire+0x2433/0x3b20 kernel/locking/lockdep.c:5137 lock_acquire kernel/locking/lockdep.c:5754 [inline] lock_acquire+0x1ae/0x520 kernel/locking/lockdep.c:5719 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x175/0x9d0 kernel/locking/mutex.c:747 hfs_extend_file+0xa2/0xb10 fs/hfs/extent.c:397 hfs_bmap_reserve+0x29c/0x370 fs/hfs/btree.c:234 __hfs_ext_write_extent+0x3cb/0x520 fs/hfs/extent.c:121 __hfs_ext_cache_extent fs/hfs/extent.c:174 [inline] hfs_ext_read_extent+0x805/0x9d0 fs/hfs/extent.c:202 hfs_extend_file+0x4e0/0xb10 fs/hfs/extent.c:401 hfs_get_block+0x17f/0x820 fs/hfs/extent.c:353 __block_write_begin_int+0x3c0/0x1560 fs/buffer.c:2119 __block_write_begin fs/buffer.c:2168 [inline] block_write_begin+0xb1/0x490 fs/buffer.c:2227 cont_write_begin+0x530/0x730 fs/buffer.c:2582 hfs_write_begin+0x87/0x140 fs/hfs/inode.c:58 generic_perform_write+0x278/0x600 mm/filemap.c:3918 __generic_file_write_iter+0x1f9/0x240 mm/filemap.c:4013 generic_file_write_iter+0xe3/0x350 mm/filemap.c:4039 call_write_iter include/linux/fs.h:2020 [inline] new_sync_write fs/read_write.c:491 [inline] vfs_write+0x64f/0xdf0 fs/read_write.c:584 ksys_write+0x12f/0x250 fs/read_write.c:637 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0x40/0x110 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x63/0x6b RIP: 0033:0x7f723e47cba9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 e1 20 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f723f1db0c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 RAX: ffffffffffffffda RBX: 00007f723e59bf80 RCX: 00007f723e47cba9 RDX: 00000000fffffff7 RSI: 0000000020000000 RDI: 0000000000000007 RBP: 00007f723e4c847a R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 000000000000000b R14: 00007f723e59bf80 R15: 00007ffff25fb198