====================================================== WARNING: possible circular locking dependency detected 6.1.104-syzkaller #0 Not tainted ------------------------------------------------------ syz.2.846/7101 is trying to acquire lock: ffff8880725316c0 (&type->i_mutex_dir_key#20){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:758 [inline] ffff8880725316c0 (&type->i_mutex_dir_key#20){+.+.}-{3:3}, at: vfs_rename+0x814/0x10f0 fs/namei.c:4841 but task is already holding lock: ffff888072532400 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] ffff888072532400 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}, at: vfs_rename+0x7a2/0x10f0 fs/namei.c:4839 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #2 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write_nested+0x39/0x60 kernel/locking/rwsem.c:1689 inode_lock_nested include/linux/fs.h:793 [inline] xattr_rmdir fs/reiserfs/xattr.c:106 [inline] delete_one_xattr+0x102/0x2f0 fs/reiserfs/xattr.c:338 reiserfs_for_each_xattr+0x9b2/0xb40 fs/reiserfs/xattr.c:311 reiserfs_delete_xattrs+0x1b/0x80 fs/reiserfs/xattr.c:364 reiserfs_evict_inode+0x20c/0x460 fs/reiserfs/inode.c:53 evict+0x2a4/0x620 fs/inode.c:666 __dentry_kill+0x436/0x650 fs/dcache.c:611 dentry_kill+0xbb/0x290 dput+0xfb/0x1d0 fs/dcache.c:918 path_put+0x35/0x60 fs/namei.c:561 path_setxattr+0x1ee/0x2a0 fs/xattr.c:640 __do_sys_lsetxattr fs/xattr.c:659 [inline] __se_sys_lsetxattr fs/xattr.c:655 [inline] __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:655 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #1 (&type->i_mutex_dir_key#20/3){+.+.}-{3:3}: lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write_nested+0x39/0x60 kernel/locking/rwsem.c:1689 inode_lock_nested include/linux/fs.h:793 [inline] open_xa_root fs/reiserfs/xattr.c:127 [inline] open_xa_dir+0x132/0x610 fs/reiserfs/xattr.c:152 xattr_lookup+0x24/0x280 fs/reiserfs/xattr.c:395 reiserfs_xattr_set_handle+0xf8/0xdc0 fs/reiserfs/xattr.c:533 reiserfs_xattr_set+0x44e/0x570 fs/reiserfs/xattr.c:633 __vfs_setxattr+0x3e7/0x420 fs/xattr.c:182 __vfs_setxattr_noperm+0x12a/0x5e0 fs/xattr.c:216 vfs_setxattr+0x21d/0x420 fs/xattr.c:309 do_setxattr fs/xattr.c:594 [inline] setxattr+0x250/0x2b0 fs/xattr.c:617 path_setxattr+0x1bc/0x2a0 fs/xattr.c:636 __do_sys_lsetxattr fs/xattr.c:659 [inline] __se_sys_lsetxattr fs/xattr.c:655 [inline] __x64_sys_lsetxattr+0xb4/0xd0 fs/xattr.c:655 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 -> #0 (&type->i_mutex_dir_key#20){+.+.}-{3:3}: check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] vfs_rename+0x814/0x10f0 fs/namei.c:4841 do_renameat2+0xde0/0x1440 fs/namei.c:5029 __do_sys_renameat2 fs/namei.c:5062 [inline] __se_sys_renameat2 fs/namei.c:5059 [inline] __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5059 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 other info that might help us debug this: Chain exists of: &type->i_mutex_dir_key#20 --> &type->i_mutex_dir_key#20/3 --> &type->i_mutex_dir_key#20/2 Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&type->i_mutex_dir_key#20/2); lock(&type->i_mutex_dir_key#20/3); lock(&type->i_mutex_dir_key#20/2); lock(&type->i_mutex_dir_key#20); *** DEADLOCK *** 5 locks held by syz.2.846/7101: #0: ffff888074310460 (sb_writers#33){.+.+}-{0:0}, at: mnt_want_write+0x3b/0x80 fs/namespace.c:393 #1: ffff888074310748 (&type->s_vfs_rename_key#4){+.+.}-{3:3}, at: lock_rename fs/namei.c:3040 [inline] #1: ffff888074310748 (&type->s_vfs_rename_key#4){+.+.}-{3:3}, at: do_renameat2+0x5a0/0x1440 fs/namei.c:4968 #2: ffff8880725302e0 (&type->i_mutex_dir_key#20/1){+.+.}-{3:3}, at: lock_rename fs/namei.c:3041 [inline] #2: ffff8880725302e0 (&type->i_mutex_dir_key#20/1){+.+.}-{3:3}, at: do_renameat2+0x61e/0x1440 fs/namei.c:4968 #3: ffff888072531d60 (&type->i_mutex_dir_key#20/5){+.+.}-{3:3}, at: do_renameat2+0x65a/0x1440 fs/namei.c:4968 #4: ffff888072532400 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}, at: inode_lock_nested include/linux/fs.h:793 [inline] #4: ffff888072532400 (&type->i_mutex_dir_key#20/2){+.+.}-{3:3}, at: vfs_rename+0x7a2/0x10f0 fs/namei.c:4839 stack backtrace: CPU: 1 PID: 7101 Comm: syz.2.846 Not tainted 6.1.104-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 06/27/2024 Call Trace: __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1e3/0x2cb lib/dump_stack.c:106 check_noncircular+0x2fa/0x3b0 kernel/locking/lockdep.c:2170 check_prev_add kernel/locking/lockdep.c:3090 [inline] check_prevs_add kernel/locking/lockdep.c:3209 [inline] validate_chain+0x1661/0x5950 kernel/locking/lockdep.c:3825 __lock_acquire+0x125b/0x1f80 kernel/locking/lockdep.c:5049 lock_acquire+0x1f8/0x5a0 kernel/locking/lockdep.c:5662 down_write+0x36/0x60 kernel/locking/rwsem.c:1573 inode_lock include/linux/fs.h:758 [inline] vfs_rename+0x814/0x10f0 fs/namei.c:4841 do_renameat2+0xde0/0x1440 fs/namei.c:5029 __do_sys_renameat2 fs/namei.c:5062 [inline] __se_sys_renameat2 fs/namei.c:5059 [inline] __x64_sys_renameat2+0xce/0xe0 fs/namei.c:5059 do_syscall_x64 arch/x86/entry/common.c:51 [inline] do_syscall_64+0x3b/0xb0 arch/x86/entry/common.c:81 entry_SYSCALL_64_after_hwframe+0x68/0xd2 RIP: 0033:0x7f1fc5b799f9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f1fc69bc038 EFLAGS: 00000246 ORIG_RAX: 000000000000013c RAX: ffffffffffffffda RBX: 00007f1fc5d16058 RCX: 00007f1fc5b799f9 RDX: 0000000000000005 RSI: 00000000200001c0 RDI: 0000000000000005 RBP: 00007f1fc5be78ee R08: 0000000000000000 R09: 0000000000000000 R10: 0000000020000140 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000001 R14: 00007f1fc5d16058 R15: 00007ffdc4c1dd48 REISERFS warning (device loop2): vs-13060 reiserfs_update_sd_size: stat data of object [1 2 0x0 SD] (nlink == 1) not found (pos 2)