======================================================
WARNING: possible circular locking dependency detected
5.15.185-syzkaller #0 Not tainted
------------------------------------------------------
syz.7.963/8065 is trying to acquire lock:
ffff0000dbd2d488 (&osb->system_file_mutex){+.+.}-{3:3}, at: ocfs2_get_system_file_inode+0x15c/0x5ec fs/ocfs2/sysfile.c:101

but task is already holding lock:
ffff0000f8c4dc78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x328/0xea8 fs/ocfs2/xattr.c:3587

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&oi->ip_xattr_sem){++++}-{3:3}:
       down_read+0xc0/0x390 kernel/locking/rwsem.c:1498
       ocfs2_init_acl+0x260/0x604 fs/ocfs2/acl.c:365
       ocfs2_mknod+0x114c/0x1e88 fs/ocfs2/namei.c:410
       ocfs2_create+0x180/0x468 fs/ocfs2/namei.c:674
       lookup_open fs/namei.c:3462 [inline]
       open_last_lookups fs/namei.c:3532 [inline]
       path_openat+0x1144/0x26e4 fs/namei.c:3739
       do_filp_open+0x164/0x330 fs/namei.c:3769
       do_sys_openat2+0x128/0x3d8 fs/open.c:1253
       do_sys_open fs/open.c:1269 [inline]
       __do_sys_openat fs/open.c:1285 [inline]
       __se_sys_openat fs/open.c:1280 [inline]
       __arm64_sys_openat+0x120/0x154 fs/open.c:1280
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #4 (jbd2_handle){++++}-{0:0}:
       start_this_handle+0xef4/0x11a4 fs/jbd2/transaction.c:464
       jbd2__journal_start+0x28c/0x744 fs/jbd2/transaction.c:521
       jbd2_journal_start+0x3c/0x4c fs/jbd2/transaction.c:560
       ocfs2_start_trans+0x43c/0x794 fs/ocfs2/journal.c:376
       ocfs2_shutdown_local_alloc+0x1ac/0x7e4 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1d4/0x8b4 fs/ocfs2/super.c:1885
       ocfs2_put_super+0xec/0x308 fs/ocfs2/super.c:1610
       generic_shutdown_super+0x130/0x2f0 fs/super.c:475
       kill_block_super+0x70/0xdc fs/super.c:1427
       deactivate_locked_super+0xb8/0x13c fs/super.c:335
       deactivate_super+0xf8/0x118 fs/super.c:366
       cleanup_mnt+0x3a4/0x458 fs/namespace.c:1139
       __cleanup_mnt+0x20/0x30 fs/namespace.c:1146
       task_work_run+0x12c/0x1e0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       do_notify_resume+0x24b4/0x3128 arch/arm64/kernel/signal.c:949
       prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
       exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
       el0_svc+0xf0/0x1e0 arch/arm64/kernel/entry-common.c:609
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #3 (&journal->j_trans_barrier){.+.+}-{3:3}:
       down_read+0xc0/0x390 kernel/locking/rwsem.c:1498
       ocfs2_start_trans+0x430/0x794 fs/ocfs2/journal.c:374
       ocfs2_shutdown_local_alloc+0x1ac/0x7e4 fs/ocfs2/localalloc.c:416
       ocfs2_dismount_volume+0x1d4/0x8b4 fs/ocfs2/super.c:1885
       ocfs2_put_super+0xec/0x308 fs/ocfs2/super.c:1610
       generic_shutdown_super+0x130/0x2f0 fs/super.c:475
       kill_block_super+0x70/0xdc fs/super.c:1427
       deactivate_locked_super+0xb8/0x13c fs/super.c:335
       deactivate_super+0xf8/0x118 fs/super.c:366
       cleanup_mnt+0x3a4/0x458 fs/namespace.c:1139
       __cleanup_mnt+0x20/0x30 fs/namespace.c:1146
       task_work_run+0x12c/0x1e0 kernel/task_work.c:188
       tracehook_notify_resume include/linux/tracehook.h:189 [inline]
       do_notify_resume+0x24b4/0x3128 arch/arm64/kernel/signal.c:949
       prepare_exit_to_user_mode arch/arm64/kernel/entry-common.c:133 [inline]
       exit_to_user_mode arch/arm64/kernel/entry-common.c:138 [inline]
       el0_svc+0xf0/0x1e0 arch/arm64/kernel/entry-common.c:609
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #2 (sb_internal#4){.+.+}-{0:0}:
       percpu_down_read include/linux/percpu-rwsem.h:51 [inline]
       __sb_start_write include/linux/fs.h:1811 [inline]
       sb_start_intwrite include/linux/fs.h:1928 [inline]
       ocfs2_start_trans+0x2c4/0x794 fs/ocfs2/journal.c:372
       ocfs2_write_begin_inline fs/ocfs2/aops.c:1482 [inline]
       ocfs2_try_to_write_inline_data fs/ocfs2/aops.c:1585 [inline]
       ocfs2_write_begin_nolock+0x8c8/0x3764 fs/ocfs2/aops.c:1671
       ocfs2_write_begin+0x1b4/0x30c fs/ocfs2/aops.c:1905
       generic_perform_write+0x204/0x480 mm/filemap.c:3785
       __generic_file_write_iter+0x23c/0x454 mm/filemap.c:3912
       ocfs2_file_write_iter+0x12e0/0x1b84 fs/ocfs2/file.c:2472
       do_iter_readv_writev+0x3a0/0x4f8 fs/read_write.c:-1
       do_iter_write+0x1c4/0x670 fs/read_write.c:855
       vfs_writev fs/read_write.c:928 [inline]
       do_writev+0x1e0/0x380 fs/read_write.c:971
       __do_sys_writev fs/read_write.c:1044 [inline]
       __se_sys_writev fs/read_write.c:1041 [inline]
       __arm64_sys_writev+0x80/0x94 fs/read_write.c:1041
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{3:3}:
       down_read+0xc0/0x390 kernel/locking/rwsem.c:1498
       ocfs2_read_virt_blocks+0x228/0x858 fs/ocfs2/extent_map.c:976
       ocfs2_read_dir_block fs/ocfs2/dir.c:508 [inline]
       ocfs2_find_entry_el fs/ocfs2/dir.c:715 [inline]
       ocfs2_find_entry+0x314/0x1b84 fs/ocfs2/dir.c:1091
       ocfs2_find_files_on_disk+0x10c/0x388 fs/ocfs2/dir.c:1995
       ocfs2_lookup_ino_from_name+0x60/0x114 fs/ocfs2/dir.c:2017
       _ocfs2_get_system_file_inode fs/ocfs2/sysfile.c:136 [inline]
       ocfs2_get_system_file_inode+0x288/0x5ec fs/ocfs2/sysfile.c:112
       ocfs2_init_global_system_inodes+0x2a8/0x594 fs/ocfs2/super.c:458
       ocfs2_initialize_super fs/ocfs2/super.c:2279 [inline]
       ocfs2_fill_super+0x3128/0x4074 fs/ocfs2/super.c:995
       mount_bdev+0x264/0x358 fs/super.c:1400
       ocfs2_mount+0x44/0x58 fs/ocfs2/super.c:1187
       legacy_get_tree+0xd4/0x16c fs/fs_context.c:611
       vfs_get_tree+0x90/0x274 fs/super.c:1530
       do_new_mount+0x228/0x810 fs/namespace.c:3010
       path_mount+0x5b4/0x1000 fs/namespace.c:3340
       do_mount fs/namespace.c:3353 [inline]
       __do_sys_mount fs/namespace.c:3561 [inline]
       __se_sys_mount fs/namespace.c:3538 [inline]
       __arm64_sys_mount+0x514/0x5e4 fs/namespace.c:3538
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

-> #0 (&osb->system_file_mutex){+.+.}-{3:3}:
       check_prev_add kernel/locking/lockdep.c:3053 [inline]
       check_prevs_add kernel/locking/lockdep.c:3172 [inline]
       validate_chain kernel/locking/lockdep.c:3788 [inline]
       __lock_acquire+0x2928/0x651c kernel/locking/lockdep.c:5012
       lock_acquire+0x1f4/0x620 kernel/locking/lockdep.c:5623
       __mutex_lock_common+0x194/0x1edc kernel/locking/mutex.c:596
       __mutex_lock kernel/locking/mutex.c:729 [inline]
       mutex_lock_nested+0xac/0x11c kernel/locking/mutex.c:743
       ocfs2_get_system_file_inode+0x15c/0x5ec fs/ocfs2/sysfile.c:101
       ocfs2_reserve_suballoc_bits+0x11c/0x3a68 fs/ocfs2/suballoc.c:776
       ocfs2_reserve_new_metadata_blocks+0x34c/0x7d8 fs/ocfs2/suballoc.c:978
       ocfs2_init_xattr_set_ctxt+0x2f8/0x750 fs/ocfs2/xattr.c:3281
       ocfs2_xattr_set+0x928/0xea8 fs/ocfs2/xattr.c:3638
       ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7349
       __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182
       __vfs_setxattr_noperm+0x120/0x564 fs/xattr.c:216
       __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
       vfs_setxattr+0x158/0x2ac fs/xattr.c:303
       do_setxattr fs/xattr.c:588 [inline]
       setxattr+0x248/0x2ac fs/xattr.c:611
       path_setxattr+0x12c/0x25c fs/xattr.c:630
       __do_sys_setxattr fs/xattr.c:646 [inline]
       __se_sys_setxattr fs/xattr.c:642 [inline]
       __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:642
       __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
       invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
       el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
       do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
       el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
       el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
       el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584

other info that might help us debug this:

Chain exists of:
  &osb->system_file_mutex --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&osb->system_file_mutex);

 *** DEADLOCK ***

3 locks held by syz.7.963/8065:
 #0: ffff0000dadb6460 (sb_writers#27){.+.+}-{0:0}, at: mnt_want_write+0x44/0x9c fs/namespace.c:377
 #1: ffff0000f8c4df48 (&type->i_mutex_dir_key#17){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:787 [inline]
 #1: ffff0000f8c4df48 (&type->i_mutex_dir_key#17){+.+.}-{3:3}, at: vfs_setxattr+0x138/0x2ac fs/xattr.c:302
 #2: ffff0000f8c4dc78 (&oi->ip_xattr_sem){++++}-{3:3}, at: ocfs2_xattr_set+0x328/0xea8 fs/ocfs2/xattr.c:3587

stack backtrace:
CPU: 1 PID: 8065 Comm: syz.7.963 Not tainted 5.15.185-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 05/07/2025
Call trace:
 dump_backtrace+0x0/0x43c arch/arm64/kernel/stacktrace.c:152
 show_stack+0x2c/0x3c arch/arm64/kernel/stacktrace.c:216
 __dump_stack+0x30/0x40 lib/dump_stack.c:88
 dump_stack_lvl+0xf8/0x160 lib/dump_stack.c:106
 dump_stack+0x1c/0x5c lib/dump_stack.c:113
 print_circular_bug+0x148/0x1b0 kernel/locking/lockdep.c:2011
 check_noncircular+0x240/0x2d4 kernel/locking/lockdep.c:2133
 check_prev_add kernel/locking/lockdep.c:3053 [inline]
 check_prevs_add kernel/locking/lockdep.c:3172 [inline]
 validate_chain kernel/locking/lockdep.c:3788 [inline]
 __lock_acquire+0x2928/0x651c kernel/locking/lockdep.c:5012
 lock_acquire+0x1f4/0x620 kernel/locking/lockdep.c:5623
 __mutex_lock_common+0x194/0x1edc kernel/locking/mutex.c:596
 __mutex_lock kernel/locking/mutex.c:729 [inline]
 mutex_lock_nested+0xac/0x11c kernel/locking/mutex.c:743
 ocfs2_get_system_file_inode+0x15c/0x5ec fs/ocfs2/sysfile.c:101
 ocfs2_reserve_suballoc_bits+0x11c/0x3a68 fs/ocfs2/suballoc.c:776
 ocfs2_reserve_new_metadata_blocks+0x34c/0x7d8 fs/ocfs2/suballoc.c:978
 ocfs2_init_xattr_set_ctxt+0x2f8/0x750 fs/ocfs2/xattr.c:3281
 ocfs2_xattr_set+0x928/0xea8 fs/ocfs2/xattr.c:3638
 ocfs2_xattr_trusted_set+0x4c/0x64 fs/ocfs2/xattr.c:7349
 __vfs_setxattr+0x388/0x3a4 fs/xattr.c:182
 __vfs_setxattr_noperm+0x120/0x564 fs/xattr.c:216
 __vfs_setxattr_locked+0x1ec/0x218 fs/xattr.c:277
 vfs_setxattr+0x158/0x2ac fs/xattr.c:303
 do_setxattr fs/xattr.c:588 [inline]
 setxattr+0x248/0x2ac fs/xattr.c:611
 path_setxattr+0x12c/0x25c fs/xattr.c:630
 __do_sys_setxattr fs/xattr.c:646 [inline]
 __se_sys_setxattr fs/xattr.c:642 [inline]
 __arm64_sys_setxattr+0xbc/0xd8 fs/xattr.c:642
 __invoke_syscall arch/arm64/kernel/syscall.c:38 [inline]
 invoke_syscall+0x98/0x2b8 arch/arm64/kernel/syscall.c:52
 el0_svc_common+0x138/0x258 arch/arm64/kernel/syscall.c:142
 do_el0_svc+0x58/0x14c arch/arm64/kernel/syscall.c:181
 el0_svc+0x78/0x1e0 arch/arm64/kernel/entry-common.c:608
 el0t_64_sync_handler+0xcc/0xe4 arch/arm64/kernel/entry-common.c:626
 el0t_64_sync+0x1a0/0x1a4 arch/arm64/kernel/entry.S:584